From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0087.outbound.protection.outlook.com [104.47.40.87]) by dpdk.org (Postfix) with ESMTP id C48485F13 for ; Thu, 20 Sep 2018 10:21:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJJxEwtuxvJCC/eKxQBxWH4+1tBZo6WY0eftkrkoB+Q=; b=Amw6lR5DU2KeZOomUOSN1pmtm0iBKbSCsM29pBZjZtt32UtLnTBguFPpTLO2oM6h7RHY6RbvU7uK8bwApIsj2kEtM7w1er+TljibiafeCXbeSsC6vSjk+B5z1UpcjWmweuIpOH8bvSZTFY6mwbUHnJwiEg7fMdawgQ/0iYeK8Cg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Thu, 20 Sep 2018 08:21:41 +0000 Date: Thu, 20 Sep 2018 13:51:26 +0530 From: Jerin Jacob To: Phil Yang Cc: dev@dpdk.org, nd@arm.com, kkokkilagadda@caviumnetworks.com, Honnappa.Nagarahalli@arm.com, Gavin.Hu@arm.com Message-ID: <20180920082124.GA19425@jerin> References: <1537363820-3827-1-git-send-email-phil.yang@arm.com> <1537364560-4124-1-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537364560-4124-1-git-send-email-phil.yang@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:c::23) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ce2063b-8130-45c6-1a44-08d61ed21922 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4997; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 3:Xl7nFugNGSHPDb+th01I1B1WzTU7bjwou+XrkzkMOtiEyCoxrMK3zuCyy77ryEbfJnJHD6YG0nP+ZhZLn2pQ2R12BHs6uS77bY4rbPifIiSXCdYh/xDJRmdxyXtZNlXs2aR8ZTtVUFNCKACeYYdbzMekw27Dj/BI3BGF4ptvKCNcBHDoplDHMQpfgWvDkhWWw+YLwf81sdCD9jBhzClG71K6ZwwOvt6PYFDRumL5TwD/G8Gm/crqC9vRSpZZs7kQ; 25:qL9EHx15QKP4hUNR3QXLZ2Yk31WQ7H8lqwh7G3ISq0vK68olkB4sIIfzpQeLX+R3eN2iEdiOulzxgBTQHs6Vn3dMpxMC5qzwzqVBL6f7qBtDe2NuBxTkkm1JStl5XkCEB3OrPTgcEGhxfxRjOZRk+B4jWXFo2yEkQ1WwA4uza+ws4hWF8ZRa0k4x2J4SkgXxxHPxIyDXVtx3TXtlQM4/Iu7Yqwbi8SxDDmWZAra6FAM/0NRYFKRi4rPOUtYNwS+lDyAxZxyU/RvrZ2zlu8u75QSoECAKfibTUFCpz5YTbcesO1UHz/wnovbyrJddJ6onfTZ1D3WNEIczIhr1h1W0Ww==; 31:lVyVwWYym+b5UBv/cM8BSbSlJYbp/9NqiTbcQiwqwKhH3QGlBzDZPeyzZ1gQaJ0WtO0Xv7wJQG9D3un92q+sF1bdO4RAKpVNoCZxWgeXpnOjFo4ugpYauKZq7aM9dHLxf2F/eosCG/hdwUbFeqV2grxT6shY3wL1pkI8k1+f1vASzdb+d8XL3pHfuTDmSqRbzuvXyaiYaI+soUbZPhFTqwpEpq3plIjYx6HZFqJvYxM= X-MS-TrafficTypeDiagnostic: BYAPR07MB4997: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 20:nj4N+qi5xmU/oM+t3hgi1rvOuXGVL7nXl6u3nn1YlMkB36shv2z/iozvZk47120317Ji8ozvvbXEsxGbsEllbN6FFbjGJQqTllhb6wNZeAsjrOMYNZH2BBHGupj1G05aOkRVh/nyPMzfCafuTgrDmW3Fgo42ldcesjONVpDrfnez81m7JNZo+WIZliYWn54EpWjoyR9haDOiFG5irEVZ18FkZedYQf7o9hjL/iKv47xLVBF0J6A9uv25XdUofXzW00YwvdvTNp6//pvRuLq4qoR+1JGPdaDYpTpkpT2nQXFodWG0KlfBH2ekVrHc8FZ2M/RN0Dg3ihgMu5rBX5jogPcTyo2MtyutsuBwK0h4Bml0o2YRXKmKP5uIjZLtQSvuLy0CzOLYKOKVq8ESfel3PP3kwy5tBv84q5HOvSCriDfTHzHiT79epzlLGzVctGR2FAVmwLVKOz3OA5TYpAHLYz/50UXLRTfy/X/4cHLfXiFPVVa477RVfbZ4fMg0UXnpZTYXM3jp6mK2aWN34tQWTANzeYzzilX3eRqkyqZ7BhMzYOMO6T1VfGFsTBYH96fD2VHq0NuP/k50Uq2L3qX6AAfzzgbobHv0zZeGaCih7gM=; 4:MluGPtT1qh5YF2x2gb7ATQkYyVcB2RoquO8onzF9LoMAU15vTUOhsVkL1i1XnicY+rwDkgENP8olMFE1PmWmn8jimsxYiNDCy9C8csVj3lheH4Ohf3wdUZ0oOo6pB+/HIBkt595LonFq13m2rH3zIVB/OyLhXPZeniadJkuf9NW3e/haWfuWTGa41TTR9u0Fl2ZhjeJ74OrpMH6P2c6TxF80XSmRTVsAgtCmuJ7sdyWHeouriNK3ERbyPPnywInXolh4Kj/mzncFsdegFj1pSqVTp3acCNLFu8id/agcmuolO8OB3xgaZ0XhLR0c2PNy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231355)(944501410)(52105095)(93006095)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(201708071742011)(7699051); SRVR:BYAPR07MB4997; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4997; X-Forefront-PRVS: 0801F2E62B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(346002)(136003)(366004)(189003)(199004)(13464003)(23726003)(476003)(7736002)(478600001)(72206003)(76176011)(68736007)(316002)(55016002)(4326008)(2906002)(47776003)(66066001)(33896004)(5009440100003)(81156014)(6246003)(81166006)(6496006)(8676002)(6666003)(52116002)(6916009)(97736004)(8936002)(386003)(186003)(53936002)(1076002)(956004)(33656002)(6116002)(16526019)(486006)(3846002)(33716001)(58126008)(5660300001)(16586007)(229853002)(305945005)(50466002)(44832011)(11346002)(106356001)(9686003)(446003)(42882007)(25786009)(105586002)(26005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4997; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4997; 23:w0Emb9m46NKSshrBHpffgzbNtm6aXP4QjbZIF5gSY?= =?us-ascii?Q?dwsAp6K6ZeZr1MV2N2Ku81J5rd4w0SFxTJc1/F85Ej0jwGFUTKUrbN0lxnOB?= =?us-ascii?Q?wLGizcf1ieEVrc1aRs1Y0VsWfsB4bQMcxB/C9KLmAvdfpCr7sDO18pSvjdJu?= =?us-ascii?Q?c0sCUnPrT++fh5f1x1NJC39eVbD+LB+g2NbREP/EcJBDHwLGX6LK1KRSXKzU?= =?us-ascii?Q?FDA8d3NTKX7BUKUhv3VwqDH5CPiPjoE3o2VPSa+5890ljs97pXse8sV+svpd?= =?us-ascii?Q?nN2HNZg8BStSNT+Tu5so7uP3f0UexglClMOOKvGAEZBScJ66r54pEXq1Npqo?= =?us-ascii?Q?WL/Z/rBuaVHOkgog9YruWiHtZX8OX3KnBIYQlfjYMj8qpXEF6bDupjay5Ixs?= =?us-ascii?Q?O3btabih/EOvcXRuVd0FY3+Dke/WE8z5VdXwHNyONjvLDfV11CyFl3Ip2o2R?= =?us-ascii?Q?/wYc16OL8XVHbtoQZgtqc7+KexO/L9r+KVcmWqoPO++7EOAGoHmKfvRPU5vK?= =?us-ascii?Q?aXwUWzZ9NsNkkPWiz/OqyAtnUJ2N91PyzGUL3bo3xgm7IfRL19W49OwsMGXz?= =?us-ascii?Q?uGvQfIQwk4GuSjJ1SEUdpqB9QSrqpTDvbA8aisJs8qQGlKoArhIhdjvCASZW?= =?us-ascii?Q?OGd6zoyqkZ67hrSjrLMgEw+HJ3qyTMY5d9Kz1ALGK+mgIcoW/SVQJXQmK/bf?= =?us-ascii?Q?Rh5JO7KSDlW9oPMg9cw7d3m5CpuCDgfiDI7fnFiKSdHUF5MQ5PYoYflnOJt/?= =?us-ascii?Q?MPqEoN0qEXVyjUt5SNxklrNARXbG9xL3k27SMYU+bcdB8elmUCs/0kPkdY0/?= =?us-ascii?Q?HIbDKWdO13I6LTOuDuYpbTsvqCAMXwyTYCV1h3xUgNAvgEpXxoOdp5Z+Pl5A?= =?us-ascii?Q?OLrc8daLJ/d023I9GRaWuzVxQJEEq5J3/Z5/8SAW3rcpP/9nLWCdzvgZjd6s?= =?us-ascii?Q?mqK6f2C3RVFR/scm5+K60MjpiuiZrARtVFDD4tlK7D03qcDXS9r4Zs99NtWh?= =?us-ascii?Q?TjGm59zKkmNdQ2ecAY2AmngqJhWrG+5SAtDh4kiTSe2g5dUGVB6980Oz7kBL?= =?us-ascii?Q?43361YOZbwUSBfNoIvwO9JZMeWC+boWoT5Wb5MaYkML3FCCHx8DcokLEUfka?= =?us-ascii?Q?sb4ssIQhPHWAf455vEQYQG18BOsd5mYP0WPIrEa//JbeECk6V09FygWABQ9g?= =?us-ascii?Q?yYchJKC1+FnF+Gr0+O/Mg30oxw0oSUay2998TeTr7G6RSrAMlh+pSs7r5Xu7?= =?us-ascii?Q?7CM6lK3Wyt+Up98TMdIPRGfWJy8oDu7D9oSUlX5/rePUEW81d8H00QOkzJ8Q?= =?us-ascii?Q?1Sk91p9TewhDZRCI1N9Wcj0J4J6zSyHD5XF+2K6tcoNCpXsixOfGIahnnLLY?= =?us-ascii?Q?6XVpA=3D=3D?= X-Microsoft-Antispam-Message-Info: 7GwODMYFh6V3d+3uYaSe1Aa3qnODvumUfBdIhGorIgBMVauL9GGMX22p+ThPun5w3dRXhXd6lIvSeKxjpJjRQdYNZRvwJu6cvJ3ws6hNC7aJae4vkw/n8HPbKPCHelz/8sGaSgjl3QJlXRHxogDJ5Fr93hjIFXpW6Ve2d3haLCdiv+L3Ww9CazwCCkvvkT/FY3YKb5W8iMZrYiQb1k9aN0E4lYG8EEDDBxscjEYlJlnuYCSMKIPaN+PXspL7vC9bHoZZ96Vvchxci//daiubR3tY9KzfzAfd6QyN4N7FbviUfLfPCpfs5EuVHGdQHK7NzUboOyrIKEoth7r9HsBhnyYqRL52dQ9B8YgqMQb+WUI= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 6:fQwf00ayoqkEYLWH2k0GFh5Ay46xa2cxw7Eot/1rrmcNlzT3b1BulWxf9GH0t0vWpZzD/ifTRCKOJmlovUeaHY+KRbwVmhNrxM9b/uPHzF0rH9v0A7NcgD9bZj7N1lAgb7DWXfgbB1LEnh0x74Ii4umJX9IPRuFF8PzTCybQmLMURurVrWBC3N4cbl3iKwzkmjWFYaTBTJdOgSU+uiyPPSuCVAEZqiGmU6PMuplGH3OYO271YMI+zspybyedd9nwRmxrbJ8gigrBjbdvoiIp5+DQKOt+Ef9NB/pbzh9wqj3bfwcSYteBwVUHHaPQaYzKSOi8uOjNYIynABODwUq0XrBYBQ0drRT6b+wpVSdGDi2wHA8/RZskpxeQpYK6bDEnA2LG/Hi4fX7srJjqZDv+VxXpgI3GGfWONpu/nyE2HSsDEuk3urEV412wx5XviHmCqW4WRB6XnPay8q7fqRYJcw==; 5:JD+7PAJ/3eo7+9pMsXy4bli0m172VD7B2sS1qQWRZb6k2NDN0+7mrYW0NjddsFtD8s3lBss8PF1wAlX/XTUGhmKbL7kW2zw0yID4qEgcRxPhOeLLQVH+bzFE9OxelKKUxmGJDe5N2byuerz1voSwQNE1onDWXmgy6MAtxx6bwLA=; 7:FaHj4+IpZP4i5OQ8YOrx/QI60fEp63So7AHUSZvpxu/5Y4AK1iS71XI+1Yet1gTMh82r4Ixk2WuVEXuxqNmQNJn8V4X5ezMPAyVNHimdYUWN7GeE/XYvMjjPoydtabgddfIZuTjoYq/oqOwL27Mzx3ijBrF132ruvaAdISEIxRBd1RmSB8bnR9DgQDMEpng/UfTp5e2ubO0mA+InkapzjCD56FghC6UbGUlbqXcbVSrQZJn6XBftVk3FZFhWeRnL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2018 08:21:41.0268 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce2063b-8130-45c6-1a44-08d61ed21922 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4997 Subject: Re: [dpdk-dev] [PATCH v2 1/3] config: use one single config option for C11 memory model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2018 08:21:46 -0000 -----Original Message----- > Date: Wed, 19 Sep 2018 21:42:38 +0800 > From: Phil Yang > To: dev@dpdk.org > CC: nd@arm.com, jerin.jacob@caviumnetworks.com, > kkokkilagadda@caviumnetworks.com, Honnappa.Nagarahalli@arm.com, > Gavin.Hu@arm.com > Subject: [PATCH v2 1/3] config: use one single config option for C11 memory > model > X-Mailer: git-send-email 2.7.4 > > External Email > > Keep only single config option RTE_USE_C11_MEM_MODEL for C11 memory > model, so all modules can leverage C11 atomic extension by enable this > option. > > Fixes: 39368eb ("ring: introduce C11 memory model barrier option") IMO, Fixes is not required as you are not fixing anything in the existing code. Other than that, it looks good. With above change: Acked-by: Jerin Jacob > Signed-off-by: Phil Yang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > --- > config/arm/meson.build | 2 +- > config/common_armv8a_linuxapp | 2 +- > config/common_base | 2 +- > config/defconfig_arm64-thunderx-linuxapp-gcc | 2 +- > lib/librte_ring/rte_ring.h | 4 ++-- > 5 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 94cca49..4b23b39 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -53,7 +53,7 @@ flags_cavium = [ > ['RTE_MAX_NUMA_NODES', 2], > ['RTE_MAX_LCORE', 96], > ['RTE_MAX_VFIO_GROUPS', 128], > - ['RTE_RING_USE_C11_MEM_MODEL', false]] > + ['RTE_USE_C11_MEM_MODEL', false]] > flags_dpaa = [ > ['RTE_MACHINE', '"dpaa"'], > ['RTE_CACHE_LINE_SIZE', 64], > diff --git a/config/common_armv8a_linuxapp b/config/common_armv8a_linuxapp > index 111c005..54e6987 100644 > --- a/config/common_armv8a_linuxapp > +++ b/config/common_armv8a_linuxapp > @@ -29,7 +29,7 @@ CONFIG_RTE_ARCH_ARM64_MEMCPY=n > #CONFIG_RTE_ARM64_MEMCPY_ALIGN_MASK=0xF > #CONFIG_RTE_ARM64_MEMCPY_STRICT_ALIGN=n > > -CONFIG_RTE_RING_USE_C11_MEM_MODEL=y > +CONFIG_RTE_USE_C11_MEM_MODEL=y > > CONFIG_RTE_LIBRTE_FM10K_PMD=n > CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n > diff --git a/config/common_base b/config/common_base > index 155c7d4..ccd2670 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -661,7 +661,7 @@ CONFIG_RTE_LIBRTE_PMD_IFPGA_RAWDEV=y > # Compile librte_ring > # > CONFIG_RTE_LIBRTE_RING=y > -CONFIG_RTE_RING_USE_C11_MEM_MODEL=n > +CONFIG_RTE_USE_C11_MEM_MODEL=n > > # > # Compile librte_mempool > diff --git a/config/defconfig_arm64-thunderx-linuxapp-gcc b/config/defconfig_arm64-thunderx-linuxapp-gcc > index 2bed66c..f11e758 100644 > --- a/config/defconfig_arm64-thunderx-linuxapp-gcc > +++ b/config/defconfig_arm64-thunderx-linuxapp-gcc > @@ -10,7 +10,7 @@ CONFIG_RTE_CACHE_LINE_SIZE=128 > CONFIG_RTE_MAX_NUMA_NODES=2 > CONFIG_RTE_MAX_LCORE=96 > CONFIG_RTE_MAX_VFIO_GROUPS=128 > -CONFIG_RTE_RING_USE_C11_MEM_MODEL=n > +CONFIG_RTE_USE_C11_MEM_MODEL=n > > # > # Compile PMD for octeontx sso event device > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h > index 7a731d0..af5444a 100644 > --- a/lib/librte_ring/rte_ring.h > +++ b/lib/librte_ring/rte_ring.h > @@ -303,11 +303,11 @@ void rte_ring_dump(FILE *f, const struct rte_ring *r); > * There are 2 choices for the users > * 1.use rmb() memory barrier > * 2.use one-direcion load_acquire/store_release barrier,defined by > - * CONFIG_RTE_RING_USE_C11_MEM_MODEL=y > + * CONFIG_RTE_USE_C11_MEM_MODEL=y > * It depends on performance test results. > * By default, move common functions to rte_ring_generic.h > */ > -#ifdef RTE_RING_USE_C11_MEM_MODEL > +#ifdef RTE_USE_C11_MEM_MODEL > #include "rte_ring_c11_mem.h" > #else > #include "rte_ring_generic.h" > -- > 2.7.4 >