From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 6B9471B112 for ; Fri, 21 Sep 2018 18:43:42 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id x17-v6so6225280pfh.5 for ; Fri, 21 Sep 2018 09:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PFutk/MiK0C0ThH4A3tqhXSk5BH7xuE+aK3YA+48uCo=; b=TL7wOmXxqs94hQWu2RQB9Yo6xEEvjqvg9qrDdTNW4aDvV/QVFF1mo+n1ZjIGtCLeDl 39vLYspPEwmZQhUeRCb2GffoLiPjpH3P6Tu1tXsv8p1fzwEqHd3ctA627X0GcdrZcfzC /ax5x43nXTdWNR0TDwqPRX65G4w7i+HVYHjbOEMshBAxBbYNh9pbHt+a2j6Ov/tOa7oB Izgws3LtW26cZK8Hb5hpZMxPhVEJ8hXUaXES/g68Wiyd7Mc0r/YkswZhg4pt0qNxayDf 4JAWaTPTSqa8euZ00e9l598OyE8BlOCAp82khRMSyKtn6wu6p3l1/GkMekM7JNNJw06g pNJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PFutk/MiK0C0ThH4A3tqhXSk5BH7xuE+aK3YA+48uCo=; b=oI/unIKQPcaEKPUygbt5NFrV2BUXnYggkdxPHgzq8onz6sXqSHnBPj18wlvu8vYyYa Eh8HJ0xClheE1PHWEErhygx9pZhl/SlaP3v2M4Qw2r2NTQMywQJ9sMWNamJ6BjfZNWve v1UPH1Rz4UKb7+k2vEDOBM7e4dJqCQbMwY1fXguNOPY+uDJ6/k7+3yuZX0a18SAIgxpu rq56XHb+Qsi+lH6ccwCsBf/R8KNc5MaGqFN6ijYBEaHCqbr6QKbN46vxoDWCQ84HmM9U 21HVSHRwTV6ikqDFA0rBqxODnBumFn49r+hBJ+MqNGwsXb8sgsXYIKKjw1y6aUE9++dn ePGw== X-Gm-Message-State: APzg51A0sybJVNfivWUw/FxaNDGApvDUfQNDVGsVbxUM0URBrbf4Z//X yQPq1OuNQj6AMRVKytrCm8sIQfrDA+s= X-Google-Smtp-Source: ANB0Vdbn7rPB3Ko9YjAJr6jW8SWhdsn1eWXBFW62FEqb4pci9/k03yPpbQizzY8v4qfOTiNjA+kY3A== X-Received: by 2002:a62:8c8c:: with SMTP id m134-v6mr47234725pfd.130.1537548221508; Fri, 21 Sep 2018 09:43:41 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 9-v6sm74757224pfc.20.2018.09.21.09.43.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 21 Sep 2018 09:43:41 -0700 (PDT) Date: Fri, 21 Sep 2018 09:43:33 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Gaetan Rivet , Message-ID: <20180921094333.0c1e0fa3@xeon-e3> In-Reply-To: References: <1535730814-24624-1-git-send-email-arybchenko@solarflare.com> <1537544182-17823-1-git-send-email-arybchenko@solarflare.com> <20180921092108.50830844@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 16:43:42 -0000 On Fri, 21 Sep 2018 19:33:16 +0300 Andrew Rybchenko wrote: > On 9/21/18 7:21 PM, Stephen Hemminger wrote: > > On Fri, 21 Sep 2018 16:36:19 +0100 > > Andrew Rybchenko wrote: > > > >> v3: > >> - move apply on sync to fs_eth_dev_conf_apply() to apply to > >> a new subdevice only > >> - use ethdev API to apply to sub-device on sync > >> - remove unnecessary check the same pointer from the method > >> implementation in failsafe > >> > >> v2: > >> - fix setting of zero addresses since rte_realloc() returns NULL > >> > >> Evgeny Im (2): > >> net/failsafe: remove not supported multicast MAC filter > >> net/failsafe: support multicast address list set > >> > >> doc/guides/rel_notes/release_18_11.rst | 1 + > >> drivers/net/failsafe/failsafe.c | 1 + > >> drivers/net/failsafe/failsafe_ether.c | 17 +++++++++ > >> drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++ > >> drivers/net/failsafe/failsafe_private.h | 2 + > >> 5 files changed, 71 insertions(+) > >> > > Since TAP has no filtering this doesn't really do much for the slowpath. > > Yes, I know that TAP does not support it. Is failsafe so tighly bound to > TAP to block it? > failsafe was built to be used with tap and mlx on Azure. It could be used with virtio and other NIC on KVM, but this is mostly theoretical.