From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 2463C7CDA for ; Fri, 21 Sep 2018 18:18:18 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 09:18:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="92589220" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga001.jf.intel.com with SMTP; 21 Sep 2018 09:18:08 -0700 Received: by (sSMTP sendmail emulation); Fri, 21 Sep 2018 17:18:06 +0100 Date: Fri, 21 Sep 2018 17:18:06 +0100 From: Bruce Richardson To: Hari Kumar Vemula Cc: dev@dpdk.org, reshma.pattan@intel.com Message-ID: <20180921161806.GA21248@bricha3-MOBL.ger.corp.intel.com> References: <1537545528-27848-1-git-send-email-hari.kumarx.vemula@intel.com> <1537545528-27848-3-git-send-email-hari.kumarx.vemula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537545528-27848-3-git-send-email-hari.kumarx.vemula@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 2/5] test: add quick run tests under test-fast suite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 16:18:19 -0000 On Fri, Sep 21, 2018 at 04:58:45PM +0100, Hari Kumar Vemula wrote: > Added test cases that runs quickly under test fast category > > Signed-off-by: Hari Kumar Vemula > --- > test/test/meson.build | 89 +++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 83 insertions(+), 6 deletions(-) > > diff --git a/test/test/meson.build b/test/test/meson.build > index a364d1aac..087d635e1 100644 > --- a/test/test/meson.build > +++ b/test/test/meson.build > @@ -118,6 +118,70 @@ test_deps = ['acl', > 'timer' > ] > > +fast_test_names =[ > + ['acl_autotest', 'parallel', true], > + ['alarm_autotest', 'parallel', true], > + ['version_autotest', 'parallel', true], > +] > + > if dpdk_conf.has('RTE_LIBRTE_PDUMP') > test_deps += 'pdump' > endif > @@ -146,12 +210,15 @@ if cc.has_argument('-Wno-format-truncation') > endif > > test_dep_objs = [] > -compress_test_dep = dependency('zlib', required: false) > -if compress_test_dep.found() > - test_dep_objs += compress_test_dep > - test_sources += 'test_compressdev.c' > - test_deps += 'compressdev' > - test_names += 'compressdev_autotest' > +if dpdk_conf.has('RTE_LIBRTE_COMPRESSDEV') > + compress_test_dep = dependency('zlib', required: false) > + if compress_test_dep.found() > + test_dep_objs += compress_test_dep > + test_sources += 'test_compressdev.c' > + test_deps += 'compressdev' > + compressdev_test = [['compressdev_autotest', 'non-parallel', false]] > + fast_test_names += compressdev_test > + endif > endif > > foreach d:test_deps > @@ -176,5 +243,15 @@ if get_option('tests') > > # some perf tests (eg: memcpy perf autotest)take very long > # to complete, so timeout to 10 minutes > + timeout_seconds_fast = 10 > + > + foreach arg : fast_test_names > + bool_value = arg[2] > + test(arg[0], dpdk_test, > + env : ['DPDK_TEST=' + arg[0]], > + timeout : timeout_seconds_fast, > + is_parallel : bool_value, > + suite : 'test-fast') > + endforeach arg[1] is unused here, and seems to be just for reference. It's also strange assigning arg[2] to a variable, while arg[0] is not. How about creating 2 lists, fast_tests_parallel and fast_test_nonparallel? /Bruce