From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: "Elo, Matias (Nokia - FI/Espoo)" <matias.elo@nokia.com>
Cc: Harry van Haaren <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink usecases
Date: Sun, 23 Sep 2018 16:57:28 +0530 [thread overview]
Message-ID: <20180923112727.GE20954@jerin> (raw)
In-Reply-To: <F3CD651E-19C9-4ED2-8561-6FE73E9A64F2@nokia.com>
-----Original Message-----
> Date: Fri, 21 Sep 2018 12:17:38 +0000
> From: "Elo, Matias (Nokia - FI/Espoo)" <matias.elo@nokia.com>
> To: Harry van Haaren <harry.van.haaren@intel.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink
> usecases
> x-mailer: Apple Mail (2.3445.9.1)
>
>
> > On 21 Sep 2018, at 13:25, Harry van Haaren <harry.van.haaren@intel.com> wrote:
> >
> > This commit fixes the cq index checks when unlinking
> > ports/queues while the scheduler core is running.
> > Previously, the == comparison could be "skipped" if
> > in particular corner cases. With the check being changed
> > to >= this is resolved as the cq idx gets reset to zero.
> >
> > Bugzilla ID: 60
> > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic")
> >
> > Suggested-by: Matias Elo <matias.elo@nokia.com>
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > Cc: stable@dpdk.org
> >
> > @Matias,
> >
> > When testing this patch with your provided test case as per attachment
> > to bug #60 in Bugzilla, I don't see any events arriving to port 0.
> > Hence, I believe this to be the correct behaviour, if you can confirm
> > that'd be awesome!
> >
>
> I can confirm that this patch fixes the problem also on my system. Thanks!
>
> I can’t remember if I ever saw this problem with ordered queues. At least now they seem to be also working correctly.
>
> Regards,
> Matias
Cc: stable@dpdk.org
Applied to dpdk-next-eventdev/master. Thanks.
>
prev parent reply other threads:[~2018-09-23 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:25 Harry van Haaren
2018-09-21 12:17 ` Elo, Matias (Nokia - FI/Espoo)
2018-09-23 11:27 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923112727.GE20954@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=matias.elo@nokia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).