From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0053.outbound.protection.outlook.com [104.47.41.53]) by dpdk.org (Postfix) with ESMTP id 1AE9A201; Sun, 23 Sep 2018 13:27:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YxWc942lg2MxM+llfKWF8+7URJjUoIycNgd13aIN020=; b=SvX6rAS4WP91G82GGJszl/CZnuDYV3uofd7TqrDsOD/kjSPl8g1u0y71Ultv3NAl0qHwCzAbhNxxQ/xKVtx4rISELpI6nHYZQk5xTgCOXNBpmEMJZzW5eehRB3Z02NdsCN+UQzdhcCU/S0zpqYIcga/urlSmD5eeQgDd4Mw2ybQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.17; Sun, 23 Sep 2018 11:27:46 +0000 Date: Sun, 23 Sep 2018 16:57:28 +0530 From: Jerin Jacob To: "Elo, Matias (Nokia - FI/Espoo)" Cc: Harry van Haaren , "dev@dpdk.org" , "stable@dpdk.org" Message-ID: <20180923112727.GE20954@jerin> References: <20180921102510.24179-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BMXPR01CA0024.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::34) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd53396e-9b21-4fa4-5cf1-08d62147987e X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4997; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 3:CxKZ1v6FBbK9X0Xp/YdggV1bAG8HMpeaNVgCTLaePzhc42RqDL4dEje7ZKus1/0DfTqKvxOzdVfae9O9vWbkFLDaWV415pD6JWq4wQYgNwNtTOprpMoVLEb23YRSBHVzSZmaDvSn6h2CGBARY5W06wGUoml9P2nXYZuL4JQQ7LXvGnlliJJOdNqBTypY2zdzRakpxtaXyv26/YPo+J+ex/9B/gvU3GLI0joqAJ5aUUCaffzoUWd7jzgO0R4SNzX+; 25:HzMuETaw4iN1SHjMJJrvmRIdL1TeZdsgR2UV6Mf/MiRX4L2B62K1EjE4A8+VqdIPAw8PSPzNf0ERKN5Lp8SIkFWDI8/dk5IgjmcdlDSDLo+uMQZEgDSMfg3HbyitaZUraEkpwp32+Nn+4o13zkgw79royw4AJkTGVwO99ednPa4mWbK6pryDvgYx1SFTIoKthwfmZxFKtcOTKf+DCvFZ99o+xP8seIiBnr36zt56w7ZO+Qfbeu30xC+fHF4bTN+Yd+81aTdG2VEut0/CgPSZNOclJHcfk+QQVH3qTe3mIaIOW2lyxYOQG76HmfUuViOXWfnGSrmk/paHxQfjOiOUQQ==; 31:7a+mfDOoIH9rcckhBGsFlrF1yLQ7hBtncrWTyC0OIxXOokWE2uu8tZ+K0adkeZH0mCpSB91m46n94wkS/U2x0YrOWL1q1PQXMcU8SPixY9E7SgUTV7/Y6gyQL1Pqaf3439i1NVAstZlmINLx1Qo2hUo3BnL4pFUfs7/WO4jFcRpQUbV6Dufq7Tg0TaS8QpVuEp+OA8ComM91YGOCD3MZtkVTxMrmmz74YYvHeZ1esL4= X-MS-TrafficTypeDiagnostic: BYAPR07MB4997: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 20:W2ThDOIqGkcFj5WTHtnle00Vu5DMmsK1v2kp/63V0QfqTIcXktuFM+UNCKsEqs1g34CzIH/rfoBDKVUzgW3/5d+bBd5KhDntIYoZN76RHovAWR77iC4W3Qpmz1Zj6N0UToCUD8rycMnFmhS3ue3X6aTyUM2Z3yccy3ucwEVoWnOXwGpqiwWwflON29R5HlIcJQamEoxu33SCPtPL5N+LAnmxC5I1Gx0CZCFN5rTpqJjRoHjJMqZDGtGZcDFTT6YFpmzD+Rf4pLJEE6t9YKK9gc4OKDI3BoVPeIvo3oM66LL9bHFVAxRdKsqYS39Wx3hwuswftR/cXCuwlr+QmF6s/VxlaqHw7qOVjrYZsicjOAn0ypv8cc0MPNSdvVduEs9KLttTNuZoWEezUJxJEwGigPr4aFt2vBrX6Yg0tDLHVz5u2tNSTY3w+JRF/51L7wiurraQk2vL+1juyzNROp7sgHzdAeyhYVrP1N3ezWUfrRBBbsYCt2juq3EZubE4fc4w6V6Pvek5ek4A9FvIcJBfSgdsOjELc0d59eRiaEIDtuwmVaDK8t8w6LMslhFUHKZ9OspFKf6MLaCJCnvwkU3ABwcl0BzbtKQFKNbsDEm6JZ8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(82608151540597)(109105607167333)(195916259791689)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231355)(944501410)(52105095)(3002001)(93006095)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201703031522075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BYAPR07MB4997; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4997; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 4:4E+oV6cLKvhQXxDms6fNKsWYYyoEeansw3GKRDAuXwC0fJfn4ed1em+RyZxjXX0x7nuMr9y8JjDCAur/kpj2dfnsDZfwVoTtmhvpey1Tmghjs0z5EFmM1XXEYEXMkTIJt8gw9orWDm8oTay+pY+QFZ2nqOM4nG4pymzRLOHNJaRyhSE6PhU7auanErjMziAyU9CR1+JN2nWzMjzeK+llmQoIHxRTzr7Sy9jpJyGng/QL/qToTLre0MNQ86I31MZ3NZAwk5QEw1qnPrQhM9uHRF0hhdyckO3NkrWFXb96EqoRie0lFGrB1BpY7C5iWGgu+qTGSNLc77Y1DvlHlzUaKQv80gXJMkM9GWf2vP3sWQXDvAX/q6zW0z+WWgnkqXWc2lCUVHSqxtsbchxsUmQMtdPkrjeEaRbc6a0MlFhtxtY= X-Forefront-PRVS: 08041D247D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(39860400002)(346002)(396003)(136003)(13464003)(189003)(199004)(7736002)(53546011)(2870700001)(72206003)(14444005)(5024004)(33716001)(305945005)(6916009)(26005)(76176011)(6496006)(3846002)(6116002)(58126008)(106356001)(81156014)(50466002)(81166006)(25786009)(8676002)(5660300001)(6246003)(4326008)(97736004)(54906003)(296002)(478600001)(1076002)(316002)(8936002)(68736007)(33656002)(55016002)(66066001)(9686003)(476003)(44832011)(956004)(486006)(386003)(33896004)(42882007)(6666003)(186003)(16526019)(229853002)(52116002)(105586002)(11346002)(23676004)(53936002)(47776003)(446003)(2486003)(52146003)(2906002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4997; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWUFQUjA3TUI0OTk3OzIzOllmb1ViTzM2Z2FwTkU5OHF5b00yU2wrYU1L?= =?utf-8?B?V3NkQktwNE5nb2c5QjBzeWdvd0FqazlYeU1FeEYySXhTYVBwSUE5WTMvSHdK?= =?utf-8?B?c25pdFJzSWRFVGlmVTU2ZkNMUC92bDVZSWFoTWtOcVVHbTNMRWxjbEdUZlpv?= =?utf-8?B?VkZYbUE5akFEb3ZIVGI2VzRwdVdCdHcrK2FXMTBTRE53MFd0S1NxcFA1emJR?= =?utf-8?B?VVd6WHArckJDcktwQnVvVG0xR3VOSUlqa1d0YnpEWVEzUXd4WHh4a3FyWjJZ?= =?utf-8?B?WE1SRzFhbEFYeVhDU0NNMDRWanphc2lvdUpwWDVIdWZsNTQwNmpyeHB3M3Qw?= =?utf-8?B?UU5OTzBSaVFGeFFweWdIN2VrSHR2a0NMdEtTYUtXdzIrU2pteUVtbXBEL3hU?= =?utf-8?B?TzhUNUpuT213dlZKd0M1ckdmUS9ZYmN0d0xFeVBxWlBlUHZSTDBHenpFUGY5?= =?utf-8?B?K1NHb0c0aFBuMmlJb1VDNzFsM1R0VU1IeXdpclFPcmc2Y2xySmVUb21iUjND?= =?utf-8?B?K3hUUmVlOUkreEI4dzRZVlIraFRYUFdtQld6SGxpMWR3NTJFUFVIejE1dG1X?= =?utf-8?B?WmRDWmJHQ0NxM1QzUmJYWTZqcW1jRDBUcyt0eks5RCt1QWE1dHRlRFdFY3du?= =?utf-8?B?QVNLVUF6ajJnKzFkTkdTM2gvMjhDUFdKR1dvak1rTUlSZWJabHhZcWkvZ3Rn?= =?utf-8?B?cXlrWWhyVDNPQ0U2TmdGeTgwYkRNalVDdm9vUUNjQm1kblMxWFRxa0d1U2hT?= =?utf-8?B?K1h2cnFpWGY3bG5ic3R6Z3IzWXRXdm1vcGU0T0R2M1g3Tkd4cnppanY1b0h3?= =?utf-8?B?MzMwbjdreGxSMFUzWUlXT3NGTEY5VmlFaG1lZEs4b09UTkVjbTdIMjhPUi9G?= =?utf-8?B?M3Y3UFh3ZXNwUVRUU2tiaUE3SGxTR1V3YmJ0VmRHWUxIVjFRRlpYbXJ1SmVW?= =?utf-8?B?eGdPN04wQm1xMkpGZkNaZE40SE1PbnJ6OVRkYll0YW4wRXFOSi9KVjRaMzh5?= =?utf-8?B?LzhSblpzNkcveGtmVDVaRVljSXVob3FDOXlCNUcybDJ3dEdhREIxVEJ5YzFm?= =?utf-8?B?Sm5EOFVBd3B3WDlGN2ZwTGlXT1FpRzlZK3ZEWTc4K09uVlQrM3NkQTV6L1Zl?= =?utf-8?B?ZEp0TmxjTmlUV1kyYUw4UE9sY0lYZDZMMk15ekUyRnFKRDRiK3h4MHZ1ZXJB?= =?utf-8?B?NGVsM1Z6azVQT2FrYThKRjFmd21wcXNkVEoxTUlCRWFGdXdEa3g4a1ZRWTBK?= =?utf-8?B?YnBtazZDbk00NThHVnRjcmVzRCtJNGw4cXVGMnZIZVprYkpsUVZnSUNrc1I2?= =?utf-8?B?Zk1jMUM5Kzg2KzNwdTQ0ODI0UmZLcmVrSEIrODBzcWEybmVkZWdWOHdUZVZW?= =?utf-8?B?UHpGbE1tS1VWT2l3ZjZmVC9MSFZOakJDaGVXdURGTmNNK0N5MWRqMU5VNU0x?= =?utf-8?B?RzE1UEZZc1NWWnJJTmxrVUF5OEVUVWVrY3BtYkpvZkwzMEpadEdZc29pRjF2?= =?utf-8?B?ZThkcnZXYmxjeGpiei9UaXlPNUFKUUFPT2NmdGRYQmFibDFOa2xOcnE0L3Rj?= =?utf-8?B?YVlVK3BFLzBuN2hyRTkvOGRrSytDSC9yWktxc0hyV3VHd1RJWDVOOXRMU0Yv?= =?utf-8?B?ZnBTZWxlSVVxRnJ3WjY0dTFEUXBzaWRJV2NUWStpWVlTYkF6Wlp5RWdLQnV2?= =?utf-8?B?OTZkNTl3cEV0WDJQdzcrU0ZadER5clpnT05uTGZMVHZaS1Y1UWRZV255VGlY?= =?utf-8?B?dDNHVXJ2WFc1OXo5NEhhMEdEUG1FZFVpTitzSzF1dWhGWWhrMHJKaUxiZEx2?= =?utf-8?B?QjNna0dtRWp0dVE4a3Rkd0NIWWtxb1ZMbVIwV1FteE5jcDBwT2M4TW9jRVFw?= =?utf-8?B?bi9vSjJaM0I0V3pkL2FRZXlNK0p0QUNwTk9TL1JIK2xQaThOZDY0ZWNvTnNF?= =?utf-8?B?cmx1eFJmZHFQQkUvY1BYbC9NM29LZFA0eVdpYWxkMXJpOWF6QnJZc1UrT3FQ?= =?utf-8?Q?nFLkMb?= X-Microsoft-Antispam-Message-Info: jMXUpttdXUHIj3LxyjEL3y6kryRsP0f7mRpZPXKefcltAEaZHW3JvDi0xzrp8bwykIbn1b2dXkzoHWill5LWpGBrC+bYQtatXux5cgQUNCGDBlV65+/I5oR7KnX5/heqKj+xhHXDq6urQnAe7J+NL3gq1/UA/9zu41pX7KoZoY0flmCfS5IfzH+VI2Xuc3hZt6tyIQJHXryiMt8lXlSvf+xiza8x43w5wDVsyqj0g0r4EHialxIOlEZ4/3UOxgujJMT7JeoEdmvoFiVqjBVKtz6ONpRBTu2go5VFoN8Id9cBTIxV02LU6LHc7MRHqQfAvTsGxbwuv2AkvdojZ9F7B/xCPyx4lnrGd2g1XsfwKkc= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 6:zIbRnNBg42yNlMoabEtbDHMfCYgEF1JCtm1dgtnEb19xjLczZngmeEesftp+JeFRZ82NozNJBi4Jr7/sT6wZkUopkG6TZeFf0Qn13j0mrFG9Qw3t7AXpA17Hyp+9PkGKhMHUwkk3OnPKPY5yw6LSefhfelIfly/HwUwEtYOpyi5YpCugOgb4orN7Vtozy8izfTGxG7Xddc7x9/tBFQEq5g9Y95Dy8cp6weaAF+K2H0oIzYWWUCa/LrUSHcid7yml92s1+BO1qlSK0+7qMeN18RDu8lKEB/C6db3K3HG4KZX7sy6HuBau0T01nQXcArdVxHOnRpBMG+OnIsbLkw2NtPCZmRXDaxrbi9rAXytScmk6L7M9pwl7oXzm/7q3peYOdyMSe/elEZLnHbhkOVgIf6Of4bRtPfnqOrOAdFDiKxAQ0faPZuT4z91xT3fpaFZUn+CXZ1uzXnJa0esgyR1mgw==; 5:OsT41DP4nwa1dkUpNQCpIeBFfHGAgeyE6/098OfkpsFxVSRZCex9Lj/KYPgwdi3E8OZXV/vfr2Y8hgdRmw4/dWLu5mTW8FvztvdQXuB12hqzpOfew3ac3uEOP8mNw3K1lYjvL7MdGfv21D5ILtpeYGVGVS/Bc83LJMvJlbOds/k=; 7:E5KKQARVI0eDITP9jzEsLZs6us9rwROx2s72a01rNlD0mpjstvE0Ilct9U3Xh6BziynczI5It0c/K02lu9vFmH5iSTVlyqW2qSfDktLYMR0RJHokrfli4WZ3hnLzyWJpGmXU6LdeQuXz8LQ6mv6ISVCjP6ZWktiosVSInpstVNS3CRBytYj7s1RiboJd1UqHfgz6nnaXYBuyGu7WGpKyHgf9+SEbDLJyue9akgde0YCKbM57l7I+gDVXN/SKVZrT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2018 11:27:46.4738 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd53396e-9b21-4fa4-5cf1-08d62147987e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4997 Subject: Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink usecases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2018 11:27:53 -0000 -----Original Message----- > Date: Fri, 21 Sep 2018 12:17:38 +0000 > From: "Elo, Matias (Nokia - FI/Espoo)" > To: Harry van Haaren > CC: "dev@dpdk.org" , "stable@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink > usecases > x-mailer: Apple Mail (2.3445.9.1) > > > > On 21 Sep 2018, at 13:25, Harry van Haaren wrote: > > > > This commit fixes the cq index checks when unlinking > > ports/queues while the scheduler core is running. > > Previously, the == comparison could be "skipped" if > > in particular corner cases. With the check being changed > > to >= this is resolved as the cq idx gets reset to zero. > > > > Bugzilla ID: 60 > > Fixes: 617995dfc5b2 ("event/sw: add scheduling logic") > > > > Suggested-by: Matias Elo > > Signed-off-by: Harry van Haaren > > > > --- > > > > Cc: stable@dpdk.org > > > > @Matias, > > > > When testing this patch with your provided test case as per attachment > > to bug #60 in Bugzilla, I don't see any events arriving to port 0. > > Hence, I believe this to be the correct behaviour, if you can confirm > > that'd be awesome! > > > > I can confirm that this patch fixes the problem also on my system. Thanks! > > I can’t remember if I ever saw this problem with ordered queues. At least now they seem to be also working correctly. > > Regards, > Matias Cc: stable@dpdk.org Applied to dpdk-next-eventdev/master. Thanks. >