From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0070.outbound.protection.outlook.com [104.47.32.70]) by dpdk.org (Postfix) with ESMTP id E8AE62B8C for ; Sun, 23 Sep 2018 13:35:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eWxxzZ5G3bVZl7fcpR2IkK3+xXV4eZ7YukVmQv6In9I=; b=lNG8twjeO+GLyOUriTxR3vGdqB/ZEeY+9aTsucfjbOsHKh6ALK+7hXC4f6nxF6TcnAWGdPO3r43LdAG+jOx+rtkeKHcumADEc7Ziae6YDKad6ii9cGn/J2X1kReJPkejB9Px5qBvwb6z3SulIC7Hva2ye8/Xqu7fPxn0OdUP1w0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Sun, 23 Sep 2018 11:35:25 +0000 Date: Sun, 23 Sep 2018 17:05:09 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: nikhil.rao@intel.com, anoob.joseph@caviumnetworks.com, dev@dpdk.org Message-ID: <20180923113508.GA13456@jerin> References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-3-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180919222235.6239-3-pbhagavatula@caviumnetworks.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0053.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::15) To SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c625547-339d-40f8-b4a9-08d62148a917 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5006; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 3:ze416Kfttwp2Kvb+iqI2cmvlnTbmk5b8QrZY7eLicEvkmzXf8I4TuvYnKq2fFFdvN00dXiSJw8THaeSNSQV8wrhCYJ8gwEsLTxnHp96+E/2D4+PbwldcN3FXyCrOrAJVAyKSnljWn+OtB5l0RDr7NokooxHKLJj79XUo98aDeLp8sK3nlwcIqDsMmjRIkBb38ygaFnG4IMHMZRtrLLmIMiSUdxFViJ3UAgUWH0pafGsyrjFcIh3DVsmBVmDMguC6; 25:8rdL6I2PQ28AEoT2J1neYMXxi+2VY0HiRYJUiols8rSrzY5zJ4xQq0Ej5krgZFxoYiSS77T001cGA8mYoN0yzMwrd/7nKJO4qaYx8lFSBv8gXBtNMdhqrd3EIKquXCBUi10DGspQjD6FmQ4v90ExF0KNftG32skhJ3WyNillTeMEbprr2y2HwOtvqaEU9TzgehPOVDpxy12VpGNIYir1qVuHgKPIOa7Tu5kkCBZEX/aj50KpWNvNSsl7Y3cqPxk2Esxnq5aKhbq0y5p+XTbA/PycLupmFYtCh51LRy2CnsK4TpTswnTDo2fX68jg5DgDS5qOcHoAGtUTEe6RBw/P3g==; 31:1XbMtLED4DkxZO8t5W3w9/xyZolQhvQiCrIUb//FIR8i7MEcQLchSJuOGgKe9T4ieo+2s0EjJ0bWs3qLBqze4t8wm8YpuFuMHUO6JTMrqzQNydLG57aYZbjvNp3+mshldW+Nk31452N7I2xyz2+oesaPTa8TD9aKDpB7TPQfj1xNLJ2sO+t4cH6FqrQzh5oBNsUj3vqqheBDO0wHkeORAmI5dCPSYelWqFiuWJ9FB9k= X-MS-TrafficTypeDiagnostic: SN6PR07MB5006: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 20:zX1mvFyAryFBVGjtdfam3BXBKuQ0tsfsywJdJAoR2vX4U2lxdb0wKcmkc868OQbdz0v+oLovXYkH5H4/kgDDS4ya+31dT8ULorUWcIAmV3XH4ZN2LUj2I49fN+f/oSQgKLwfSB3fY9NNqQTuHDmNCRK5XhEm4SRj8Fe+9/3C3F2cq3XvnceW9U2/IDtqjRGqIX4YbNap8WRvTziB1/qyTGgTFEn7BGaDiLadFAWXjC0Nk+dnH39nNPb+gm0qT7+uFNYNJ6aLSXEyppsid6WPf3pB0jyKopHY6Lpa6e/x6qcMLCi6S+1bOGqnguXcudZUZg5/wI9/4BHUfbbYThvih5NFWe9BhycHe55EO/ebmWhwrLqwf1fp+KHuoZs/a1CrvNa6hL29aII6EdBzsKsr7IKOPDy4Hl2rhIw0oQQALHOnPFjM/1FoAi0DVAFeL0tuUcp0io5BjVs8bi9ACPq0DVmw+JgQsNre2ywmroczGSkpi7bb2aLApvL1qorPeGC3SB1pGaI6SeHy4gmzd0sMNr63zTUlV4avE/PSGznvTrkbAGMG9vlel/oF+j1jRQybQ+VHS3snKqrSB6+vbggPt3aOxC899cApnqFYzHfhdhg=; 4:NqbJLcT6oikkcQDSpFlSwOPaHo0gW03u4F/VbFUJ+TNT88hCRDpoqoSxs92YI6r68Y2ZzeY6V7SoaEF7qjSvvanVw5a0lhBAD2W6C94S6I7G5riA3YS1k1HxP4kURxS5SClIX1V+vx+H//yYNPYgzX4SkLjplSwu2hagJmA6PezPlqQDc9kIaO6/DmZVcve410hbTuQZnLxeCC0/irp2q+bTiRyKKtEpmXPdHfH7zekxYZjPKw64a+07p2h3jbkLooSFipsPAMTVRW9Qh/07PpPpTfB5yflvLcwSKUUDBTNx5pEy4TFR60Bkzx1uoi+M X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051); SRVR:SN6PR07MB5006; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5006; X-Forefront-PRVS: 08041D247D X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(136003)(39860400002)(13464003)(199004)(189003)(6666003)(476003)(23726003)(6636002)(106356001)(97736004)(386003)(81156014)(81166006)(6116002)(3846002)(33656002)(105586002)(8936002)(33716001)(55016002)(2906002)(52116002)(76176011)(229853002)(478600001)(9686003)(72206003)(1076002)(68736007)(6246003)(33896004)(50466002)(25786009)(5660300001)(53936002)(6862004)(6496006)(16526019)(11346002)(42882007)(4326008)(8676002)(44832011)(316002)(26005)(446003)(7736002)(58126008)(956004)(575784001)(305945005)(66066001)(486006)(16586007)(47776003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5006; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5006; 23:pwXjcHV41q9HzDj1tmd8EMo2cOTBemBRSnWYalSpz?= =?us-ascii?Q?0wZt65ufq9/+0BdPrHR4pjbH1YgIp9kIGKRXQNsWDmnQouqTMIN/jKhCkZFb?= =?us-ascii?Q?HbMq00wS7dDGshc7NwVyPpvcu+4+aV+0vd0xeLMg/uQUMIBvmfJvF4LeIijQ?= =?us-ascii?Q?tVn7dzWa9gofEiSCxwuOWfcDg+g9OYyNVUepG7slo5lS8BXwYQaXZwxBcu6R?= =?us-ascii?Q?u9WmJdKH95JJa0CxTR8GVVhNLsa2tvmFOpB7cBmKcWQIKEJkktiAoB/7sM9W?= =?us-ascii?Q?IOQkDRwLw4YHvFqW3GNo8F3THpPisLAun2F7MtSvpV6WGSzATmkpQcIQc4vC?= =?us-ascii?Q?RVyMx/2K3jvMuoA06P11A9IPTG/FUoioALNlIIITLnYAW0UuvbrGHto2xFxJ?= =?us-ascii?Q?66qLG56b0ok2cL4iyLd3KIRVjvOGZrcVm39K8Q9++wTkbC4c7BQNfARs+2xS?= =?us-ascii?Q?wjGaM1sMDl0f8GmhPvmcP1y4bv5Iha2DZ+WJXZ4ZEd8bZVNhlh4a3euanr9k?= =?us-ascii?Q?rgkRoBSy3DU7DqEz4WgDoeSqu+Ef040PxT101SyWCucBpOjVV7UeF4HB5pFt?= =?us-ascii?Q?QnrxerTLn2mGf5QB2CJBqct2gRSLUflYti+1vBI6rPeM/lYzkabFk8JlilYp?= =?us-ascii?Q?0Lx+pEKEdLKJtK4arZBr7YIB5zD8WPWtQ14OEz22uxMXzOdd0O9YbgsXYl6y?= =?us-ascii?Q?K3Ei52G496Eb7OMoGY//K7MmhrMcRGrUya8dgU8RGFBmB/xj+NdE48lez0oq?= =?us-ascii?Q?WzZ0WnfiBTL/BWCbUdZjp1aj9YZw3K6iRPg3yolYsbunVigiappq5kHltbHZ?= =?us-ascii?Q?L7hyKWtcTnhCUTv8/+wgBlFgg63gROvYxQgVcx6/6S/nZiDnMShnHQiydxwL?= =?us-ascii?Q?hj8EQjrh9BnYiCHOIT9HYX73pDNF7XGutNRTxsEHwNM+/dJES6E2VdEI1aXR?= =?us-ascii?Q?K2fNbBntXWnHgw4TdmRxJofRTZR+rUWrINfmrIZhagipYJh8s6TY0E1x308S?= =?us-ascii?Q?yU4rRD0yCMh173LLNHL66O4SCq0RMSG00dukbjH3hGaaGP0OM6Jklg0qnFYn?= =?us-ascii?Q?wtfUDi6aQM68O2skKXWY/zYBeISg8/UVH/HQOcJ017kjhBmE9yohwYw0sA9Q?= =?us-ascii?Q?M5G3Ct7IfWD2582oDqXqkSBPEMDL9Zeurl0Q+afOyoBDpNcUPuNJYswStxLF?= =?us-ascii?Q?9mj5GLKkDO8e7aVgMDSgMWvCz794cVi2EY+OvzleYjrI458JHi9/qID37Wqs?= =?us-ascii?Q?q057ri79rEukUtEByblFeFNMvfrkRZtKpP2O/S+eYzgnqXM45sLtImAOBnS+?= =?us-ascii?Q?lyLxxJ3qiuFDMM99hHiEemDKvLME9ko7ZtxcyJPzaLIs2Rx+VReSXjSDL018?= =?us-ascii?Q?jLEAg=3D=3D?= X-Microsoft-Antispam-Message-Info: scbLJIm+X199BXj4jDZ1agEPO4znqtJf46Q0fQgVhXfa2nBLY4duIowiF5bLR6q5ynIBQ6nrKS3t0PjbtKYT8SyScL38pOvxAyAY+Fja7UfVo/Bdk9BbUziMK9ilTA2UU4fdveqT61ViZiIN91XSnUomafrxa1TAx09Bd8Y1LP5PYQgnb0l2O57yRRljfllrrRXRuEghR3Pvj2Eym5Gt/5LrWnewbYh21pDA/bNoYvMFZNpmjSUnXPK9nIWs2gwPiTgSNcDwEoxRsZHDuAO4hCFmM52m2qvGGp4LkkhyUNgV2uFAR19NwmvVShlxKzBZ67SMx0+hEJXzzF3MdTBj85xgTfvgDuoZbS7YJDlLyzo= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 6:A098pIBVrC11DfufhGlA9+rPr7K8+CYyUByHrzTEfSTn7DxTUS/cNmmWbPuhmu6foah4LV2Zwm0HFJmanMQeuECJwgkD+2whr+alWvdCQ79U3TuPSGHN6AZx5EiMoLgjU+RzZdW/FDZofWBuNLY59jw3zUPMeWXdEP1tbpDYuFKgysCG5s/iRQAgeqBfAZShzhNv8WLcZ+5fvs6StFOTkSkF/qES5IhMIH8HP0FuO7O5NHHWLX3I8WGgNNeiRpQ3XllC0olCXte5bQvXatHE0TJyz0EisIzH5OKPylPPgkohgaBsyEUqTEoHTaiCzoHfs9TEbu++xdj6bDEUzxdxJ1fxEbE4Y9VzqC/NPHv6lVyNrBhRrLXvWE8Aj+Otrg0asuSkCPo+em6F1+PltCfAuhZX4TQf8Czm3aUqi0BZaWbhcnF2wUtNdkliOgBMT+uVVC/w6EKpxGdSNElLnwHkZg==; 5:g+LfTnewvSPWyb3vwQ9dZqXGEUDFLZKcEK4bTEHvb6XDsNeULXoWNnH+uWz252sFUvQcwd5rMYTrgD8pmkMvlcypRBc0zfPXt6N5p+PzJ7CfEPCZdBttyOmRRYGLir01mWy5zs6ilEiLYr6Pni+IhlCgHkACvFYY4n57lPKddg8=; 7:vcsfALNvjqk2PAEobIDPTmPSFaz2NdQWDxnNimdWFXo8SSzsivV/zzOLr32eBqCB8Bb3YbA4pG9B4YKOT8FNKipg9W7KPwiDNAP22FWccGHFKGtW07zOTgROjFDYzm9ntBQCvL0ykRnvbD4p9XGM48aFVv2nNXbzd/zznYax3R0qZA1VCCfFceDx1PmZBeGSgw+Rcn9tdSCOVTWNOQ36coDSph4m64ngGjkV5ImdRH9Kd8YzhPOROjV2pPMfFcig SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2018 11:35:25.9686 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c625547-339d-40f8-b4a9-08d62148a917 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5006 Subject: Re: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Sep 2018 11:35:30 -0000 -----Original Message----- > Date: Thu, 20 Sep 2018 03:52:34 +0530 > From: Pavan Nikhilesh > To: jerin.jacob@caviumnetworks.com, nikhil.rao@intel.com, > anoob.joseph@caviumnetworks.com > Cc: dev@dpdk.org, Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support > X-Mailer: git-send-email 2.18.0 > > Convert existing Tx service based pipeline to Tx adapter based APIs and > simplify worker functions. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-eventdev/test_pipeline_atq.c | 269 ++++++++++++----------- > app/test-eventdev/test_pipeline_common.c | 202 +++++------------ > app/test-eventdev/test_pipeline_common.h | 62 +++--- > app/test-eventdev/test_pipeline_queue.c | 241 ++++++++++---------- > 4 files changed, 363 insertions(+), 411 deletions(-) > > diff --git a/app/test-eventdev/test_pipeline_atq.c b/app/test-eventdev/test_pipeline_atq.c > index f0b2f9015..01af298f3 100644 > --- a/app/test-eventdev/test_pipeline_atq.c > +++ b/app/test-eventdev/test_pipeline_atq.c > @@ -15,7 +15,7 @@ pipeline_atq_nb_event_queues(struct evt_options *opt) > return rte_eth_dev_count_avail(); > } > @@ -317,34 +291,36 @@ pipeline_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt) > int nb_ports; > int nb_queues; > uint8_t queue; > - struct rte_event_dev_info info; > - struct test_pipeline *t = evt_test_priv(test); > - uint8_t tx_evqueue_id = 0; > + uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0}; Some old compiler throws error with this scheme. Please change to memset. > > int > -pipeline_event_tx_service_setup(struct evt_test *test, struct evt_options *opt, > - uint8_t tx_queue_id, uint8_t tx_port_id, > - const struct rte_event_port_conf p_conf) > +pipeline_event_tx_adapter_setup(struct evt_options *opt, > + struct rte_event_port_conf port_conf) > { > - int ret; > - struct rte_service_spec serv; > - struct test_pipeline *t = evt_test_priv(test); > - struct tx_service_data *tx = &t->tx_service; > + int ret = 0; > + uint16_t consm = 0; Please check the above needs to be initialized to zero? > > > @@ -326,25 +316,21 @@ pipeline_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt) > int nb_queues; > int nb_stages = opt->nb_stages; > uint8_t queue; > - struct rte_event_dev_info info; > - struct test_pipeline *t = evt_test_priv(test); > - uint8_t tx_evqueue_id = 0; > + uint8_t tx_evport_id = 0; > + uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0}; Same as above. With above changes: Acked-by: Jerin Jacob