From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700056.outbound.protection.outlook.com [40.107.70.56]) by dpdk.org (Postfix) with ESMTP id 1BE46201 for ; Mon, 24 Sep 2018 11:51:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5gXmfs6BddFxId0JFVIFnPnYvUkN5EQWglAe9/2rth0=; b=bx11hSPMu61fysW9eobIPz7HCjAms1rnPTVsfJGFHTSY7s9Ah7LTLbQaUPPauULeo1bdoAkzs+IeG2YMg0u57EC55hKaWDz+eRzpAitJTZV2AMAXdwYMN3ji2zTn4OZeiW88ONQo1kMWFD2ZnGOkj7IVYt/QVOmy0VAGWgsogEI= Received: from ltp-pvn (115.113.156.3) by BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 24 Sep 2018 09:51:37 +0000 Date: Mon, 24 Sep 2018 15:21:18 +0530 From: Pavan Nikhilesh To: "Rao, Nikhil" , jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, anoob.joseph@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180924095105.GA2806@ltp-pvn> References: <20180905134554.25243-1-pbhagavatula@caviumnetworks.com> <5261bae8-0842-849e-b95a-67ee851ee7f8@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5261bae8-0842-849e-b95a-67ee851ee7f8@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BMXPR01CA0019.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::29) To BYAPR07MB4965.namprd07.prod.outlook.com (2603:10b6:a03:5b::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 56b497f8-f889-4bdb-0b0d-08d62203533b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4965; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 3:8yZPLvo+m4/WMpCnvgVKY/zp3B/yxnrNTZomoa9JeJKTlgvteCrXTpuzkTosfmQkybTxrQdQGyKAWWBWknYGs6TQTmk/Ak4PPFBaUGcIn6VpC5YBO5C8bonasS43FBKPwW/EYUtZCOHp8ZNvk61JVAc/N+7j8y3vYwYU//BjnejQJZ6KsRfnfNvW35y19veuKoKHcqM2+Uu0hMBLLNWlyknyMz9zpAA8tcfeikJJE9w9aYx36xdWN9IOY+22pYwM; 25:/2LiUhUA6+UQCeq5yWqklS8wYZ+0VwAuVd/2jC3D0Ar2vVnVmHIMtZx5xhYgseysQUYAjoC3TW3kciahQb+k2w1yOiXQeB5Og1JRqXC/SEo92WxnzZOUF6WnjKYd0E4qaffeahBfGmTpqUZEJ0Ot0Ll0PmCgKjLVW9aoDN0TSP3w49/YGfr2sDsYCikZa24NGBFAAOuY2U50MWrSdivzyCBMOs2R9LkOLEZEroirQzgXUAxuR4n5bWiSh5ljgXQv+hjEB5ZHCPu8RhowGaPN4guQ89wCqOgl4n3NUEpYRDhXb4KJyzcWfOGuFmhpixY7ZxLBMYoy0TYAFR3j5hvvzQ==; 31:+Cf5uHF8wwD8j4HX7XP0s0wFaAqRMMIOJW18vDoKgx9VIUuHXqmBn7kq3D6qcPo1BaysU6r7Si1/fpCFjbu6zBLxhaHt5MflPI5K88Ue9hPCM13+DZzqh++w+e70C7+DQ2DIDhJvlo5tG4s2olPuAr/V4dOogYEDmFjxyXFYHhm8Q56QjVH70auHnn9z5bVD8zqiRoFRNKAHp/tFpFnkPpTPpPyc0TE+ppRV+OpTeAk= X-MS-TrafficTypeDiagnostic: BYAPR07MB4965: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 20:0k3aSBd4tnnhgPtgts4lNWT3ZmoAWO4v6QZK7IclKZQ/vUXA33LLBuXgalCx4wRBJfyX8S5u7ZgrhKTZnAVxX4j2t65Sz9lyA9bDQfdigPIu91aQNtc+z1mS8y+lm9F0mdlFzCU6EefiNtXYw98RY613x8uuHl2fp+1zOiM0iEetJKamw1bKXSFihfP4/COMod9v0mP8TiJeBliFtvlPbn9JSe5YGG+vwyEJck7+v6B6Lct22zRfZEWaciAThyaQmVLdTdna30In9movQIyVmZkd6/2lMDfDZmo4cA3n5mjYnR2R0yD+PjNXHBIHLstlyKF2NB6E90jJLwdqzc4vWcWSQTEWhD2fK+zo/2aw+LhGVv2dmUMnpZh9EWQAc6MMwia6P75Ab6cBmwuFvNWmJcpOJaO9KBYNppMoXNG0s8FyRbPDWSDrFNW7TedtcRvyQd8CIMSh/s65gjMI84LWhxjrGLHMr6efhnPaEBflHkf/CNkGn3nVrkA+0wU8chq728/XBKcGcwGPDESHPdudyzAPTzD3Y4dYvinyXE2uP39hA00Nhknaku/t0ChW0Rw/LmW1OXF77+yTTvNfhoN6YrkKITdk8UQjvsoW44wwcIw=; 4:6R2daRdN2twNJZ5PuSsIEPtX85AqXLXJwA/6KduPjkb3XZ37wSZiWN0vmaZYTAIX29lqDJ907+Ja+Kl5bAbZ7R7TZscZdNRtJeKeC6q36l4Z+VGuQ9WqVPfkbXHVMSh964VLASLh7U4w/h/mhrLnmsx0W7vGneQFeSwYgVbkAkoEPZB52K3lxGyenS8kSjQQn7JjnjzxtCLODWX97dlZ4Bo9TqDtVOGgE4kfUtHZf4Sy7nxaiGo0rq27VFQQ6uMus6GNVva7S+PO+/90LCQ4uc3249/5vtZCGLYLvvCQSTLf+9Xk+Xy3omd5ww9cl41P X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231355)(944501410)(52105095)(149066)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991041); SRVR:BYAPR07MB4965; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4965; X-Forefront-PRVS: 0805EC9467 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(136003)(396003)(189003)(199004)(47776003)(33716001)(5660300001)(97736004)(68736007)(229853002)(386003)(53546011)(3846002)(23726003)(1076002)(33656002)(6116002)(58126008)(16586007)(52116002)(6496006)(76176011)(33896004)(105586002)(106356001)(72206003)(25786009)(966005)(478600001)(4326008)(2906002)(6246003)(50466002)(66066001)(55016002)(42882007)(6306002)(305945005)(81166006)(81156014)(186003)(16526019)(6346003)(14444005)(8936002)(26005)(446003)(9686003)(486006)(476003)(11346002)(6636002)(956004)(6666003)(316002)(7736002)(8676002)(53936002)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4965; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4965; 23:ZMYZ26/2A97a/ZMFCpLOSqrBxlN5Iw+ym23jwe9g3?= =?us-ascii?Q?Qg6T99a3/WN+jZk3YYEHjcufqFgcWhqxOi1QNoO/QJ8dMYFyi+cJq4vNqPR6?= =?us-ascii?Q?k6XXcwiIKgte1Ah0ejTGYbzoY6Hwq4fijZgC2E32OnkcsHLPHl1DRSUqgwzV?= =?us-ascii?Q?jB2lzZqd/W7uhv3uHU7b6vj6q14N19M34KkYbjiXJOPmPoUlEtITyR4tQaZJ?= =?us-ascii?Q?rXuQxMJPGBe1KnSeJOAg4GX8nkMe8ARg6mTun2o4Lr+o3eV7+daFCs/re/ck?= =?us-ascii?Q?aS+LBaMhukKn9M+93p9HiSF8aKEeEXVtCE7GhI10FnCB5WfH6S3BEqNMRu5U?= =?us-ascii?Q?xXentDwSdjBS2MYY8YinnfC00HF9qZIRa3pKPbVbNx3i7fikvgE2irn0bl3o?= =?us-ascii?Q?7bXH0tOpmBWcAHVWpInMIAAUXiAIvugGLA2Rf7f8A761r6l1Irb4V7grn7g2?= =?us-ascii?Q?r7feflQIdgAc7iahYN90q1Zn2aQCz8Yn8qkBaesv3Ox5E8BS4uJHRdJUK4yO?= =?us-ascii?Q?MI4OC7LPC1qg/m0oKayr9cbElCfV6hbFpnkZxCfZIFDih6P9kKSU8OQoCW00?= =?us-ascii?Q?9+1LlbAxKy/5HV6uVWf6IZsmI+Q3Ek6rlC3PYc73OUYcHmi6DG6AbJaCswLm?= =?us-ascii?Q?YuX1hkZfcT7JUnSxWo8LOAgB3J2YyUGcY5MlL6e/z0/sFHsnYLU+n0+Gx8nq?= =?us-ascii?Q?8FFcUmeYQ1Nm8in7KUE2epIA7uFr610BGHEmKw7L7wuXn0xSL3lP67ny6BHx?= =?us-ascii?Q?quf3NfqL85g+Ch/+hnzs60ZKQKXNFnWnb4bCjMrMcReOD8EeBienmVWLlqRp?= =?us-ascii?Q?l5iDLKNbc13+KOk1DFVWZGwopd3BaxqvuQQyPPRANOI078q5vXKQIecmSolO?= =?us-ascii?Q?pFcY4X+lmGqGTEY9b+85AuuzOZkwuiACgLITtTuN10aSfAaf6eA8UEh9rbXd?= =?us-ascii?Q?TeVG3S3mtjutyJISY0ekthCDGaBCP6jh/JUHRbFojYIxq1MEQbKR8xIsO2OT?= =?us-ascii?Q?43hAxhhytfKJVkLMqIugSJLWYg9b9Ci2lDkYZ8qi0944mItocv2zrgsmYRGv?= =?us-ascii?Q?O9dXG9401jQIDnoJ6Wl//Twj6Dwdcsz7B5VcQ512X4L1qCvIf+7oVrTbUNZ8?= =?us-ascii?Q?h+hLjv/8ovIJpQACk+GWDu4pxsBL0ai1KTv6tu56S4CtuEw7nuwKYYgrDs5F?= =?us-ascii?Q?y+vMMvl9JApKXXpUqiha0UwGg6tSsogS4Au0BmCiR/xG6Ibw0gdCUf09zWwa?= =?us-ascii?Q?+niDZERibJQ8aH5dNGrF1z4G2KbS84Tnwb9zA74PiE+gLz+UZEzSjUoXjUXw?= =?us-ascii?Q?V8hOOtWAOnBmy2CWdZ1aolaIxrEz5AHEbdm5Klap1ZVWzBZszgeUdTrbb+0J?= =?us-ascii?Q?R6/lLJYPdUKtN3rv/ew0Q3g10PKx/n7Otjigjh7juyZRXOCPzEDBVw1OYtQT?= =?us-ascii?Q?CyLiAXnkA=3D=3D?= X-Microsoft-Antispam-Message-Info: ab30YlLtqooeGGN1n2P3WQJSq2ZvjYDo/LabEIs0zDMlqCoKJvAEbAPeQt1nw//rsKqkOPxB6/ae9cu0YDUIN4Oxej0+rNeOOciO4dm0BQOmmcXyIvsGgl6yxwp+K0a3Hn3GUuarAXIgzp+3biFg+m9LJJ0mMJ9A5pKwAkRBAACB71icysaN/8j2DWrDzeDOemelC+et2ZOYOY4UpPhf78f9AhV9mtPL6gBR8XJat209hzNbQyHNEy1PId6vcLjiMQbKOYiyVIGBb3sRbLB5hS9HD/HFzJpLG5sOLNsJIFtSf8kO0GqtUYyMEEafQKaP1BzcwIcoHouAuwjU/ir3NfZPZMbei65rcT3KR43mJg0= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4965; 6:SC9JrCrHvnv3J0LUJDExqDh6MJ9mTGC8JHWdDurlG+nKuxzsN3oFAU8TTNgLqQHqkomg2plozVtrFG7rUUGGwP1v1td4564zRrbB3Z2ed353KBPY5qHwYK1y6IFGDd6nCXlc6CyAGqiBYMCWWo8Qd0ZllgmaCRyWmISaA9954pbQcgJ7kvH71q24+ifd2dlRJ28n56mamd4SMRPDw/4XKMrGkHTeX7OKd/mXg01p6SfFPP1kpXSw2G7fAAZ0HfNeckzrEOw61aJO3b5KJ7EspXp+tSlSb0cSmQAHRqgkK5tlMKxtrIvE9JQOarkdwe9MBE9nQuiODlwwIqY+RWklq3axjZ8dGw1CUPBuPaZQ87WOvUEQK2fh+GyJXReAZScVc5E2iH4RBZcYgvpJlBBXPDHmmujBf7eItl9TUsw9vfTr9VLIZ+Vx9tBA4wuWMuZo//KpEQWQesA5v+jGZjqddA==; 5:1XP0o69D7Wi1er9T0XHBJHKPhKZErOaSLDQadtcDx2u5mxje3wj7QVnKAcEdyK1B+LnisUb1bIeUdFHp+wfT1//Lxg4PRjSOEkTHclL/aRzSZB3lnHLKTPsgz+kiCo2eZfdJHuBzfVswwnZpXKhoU40glKltJ58kb/45xacX4LM=; 7:inTjytqHNVKnM2Tirl2yfesdXwdSGl2Iiz+9usduQErVRrbAwz+M9FxEIyR3+xLaIO/cL5Q7cZU009Ge3Xdvitwg1tiOZYxSld+Xog7NSi7kP01ncmXxTFxNGjQWd07ROUGjzXRPbN43X9+yflyzssH/JwRwyUu2Mju6RiVpG+GPKrTFm7k9qytrl8L0fG3yB4R0mFpzJXp131xsl/pIMBTYb2x8ts8bgyuG4gyHVBGlzjDJcXv7I2Oia8foTrHB SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2018 09:51:37.3939 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56b497f8-f889-4bdb-0b0d-08d62203533b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4965 Subject: Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 09:51:42 -0000 On Fri, Sep 21, 2018 at 01:14:53PM +0530, Rao, Nikhil wrote: > On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: > > Signed-off-by: Pavan Nikhilesh > > --- > > This patch depends on the following series: > > http://patches.dpdk.org/project/dpdk/list/?series=1121 > > > > examples/eventdev_pipeline/main.c | 62 ++-- > > examples/eventdev_pipeline/pipeline_common.h | 31 +- > > .../pipeline_worker_generic.c | 273 +++++------------- > > .../eventdev_pipeline/pipeline_worker_tx.c | 130 +++++---- > > 4 files changed, 186 insertions(+), 310 deletions(-) > > > > --- a/examples/eventdev_pipeline/pipeline_worker_generic.c > > +++ b/examples/eventdev_pipeline/pipeline_worker_generic.c > > @@ -119,153 +119,13 @@ worker_generic_burst(void *arg) > > return 0; > > } > > > > > static void > > -init_rx_adapter(uint16_t nb_ports) > > +init_adapters(uint16_t nb_ports) > > { > > int i; > > int ret; > > + uint8_t tx_port_id = 0; > > uint8_t evdev_id = 0; > > struct rte_event_dev_info dev_info; > > > > ret = rte_event_dev_info_get(evdev_id, &dev_info); > > > > - struct rte_event_port_conf rx_p_conf = { > > + struct rte_event_port_conf adptr_p_conf = { > > .dequeue_depth = 8, > > .enqueue_depth = 8, > > .new_event_threshold = 1200, > > }; > > > > We should restore the dequeue_depth to 128 for the port config passed to > the Tx adapter. Doing so takes the performance from 5.8 mpps to 11.7 > mpps for on my test setup (test setup uses the SW PMD). Restoring > enqueue_depth and new_event_threshold (64 and 4096 respectively) had > no noticeable effect. We replace the above values with the defaults passed by the driver if (adptr_p_conf.dequeue_depth > dev_info.max_event_port_dequeue_depth) adptr_p_conf.dequeue_depth = dev_info.max_event_port_dequeue_depth; if (adptr_p_conf.enqueue_depth > dev_info.max_event_port_enqueue_depth) adptr_p_conf.enqueue_depth = dev_info.max_event_port_enqueue_depth; Still I missed setting it to configurable defaults used for worker ports as below struct rte_event_port_conf adptr_p_conf = { .dequeue_depth = cdata.worker_cq_depth, .enqueue_depth = 64, .new_event_threshold = 1200, }; I will send the v2 soon > > Thanks, > Nikhil Thanks, Pavan.