From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690041.outbound.protection.outlook.com [40.107.69.41]) by dpdk.org (Postfix) with ESMTP id 162BB4F9C for ; Mon, 24 Sep 2018 16:45:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43y6APGjfSmnPBkFnoXK9evMLhUMzT//Ml3r0p0gYi0=; b=aZSw6NOwiCoeo0SQlGTmfwV1aOJoB1Js/dQYXe5DtZ1T2YNEmIau1Pzy0BMa4mIaLHCs+IUqZytMIy48YPtF0ECm7oSfj8twVWtUXDEt04K4H+N0ilywYGW/jYW/x/V0KLWthNeF3+9nq3mXoNIj1v2VsbCrbiffuIhtiHKusgc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 24 Sep 2018 14:45:17 +0000 Date: Mon, 24 Sep 2018 20:15:01 +0530 From: Jerin Jacob To: Andrzej Ostruszka Cc: dev@dpdk.org Message-ID: <20180924144500.GA26713@jerin> References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-1-pbhagavatula@caviumnetworks.com> <20180919222235.6239-3-pbhagavatula@caviumnetworks.com> <20180923113508.GA13456@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BMXPR01CA0014.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:d::24) To SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ae85be6-9c5d-41ab-afd4-08d6222c592f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5006; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 3:DnSButhLHi/sTs1165j8Ru3Z7uAZXt3W/bqh4AfyEniVQY7YKGv9fThE9JmnRBIysGlQwt4oNna5/823QhCPK5E+hCwCyjb9Z6ccBt6K4GFuSOHYGtEq5BTgttQ+R1mdzRCFVIHs/T2UJwjj0brhln4kmt3OFmESha8uIt8YE0+60HmXASKLg3lmkB9jhnnW2H+mMO0UQkRHLpp7OF9Y+dHWEuR47G8dhnnVlomqS4qouTUPSblgGA3ikIGC0uMr; 25:b58f5qiOewWzXtnhOOyBYEf0XEjHbOtxd1EfsjEmHf6/cP/427i+DA9lST2NcQPZq46FxZ3XS2WuDGqM+fLJxao3uQxQIAX4iJzJSEdSwH/7Ba8slSFp6bOuABpkc6h4t5S+lZWf42EWZbOB5LtHph1EdkVsLTfh5iiMzypQlsxcchg5DZHwH5VVk4tRUoQ8GSNznThomGL3aWVRhSVZQPUkOgBwlNclcx4k4lMTroPwtsxdG+t03Quz+EmHNCprbjSIT3wVJSaNyQ2h7yaiOU4Mt4qF66x0dePXDdX5ry7xkBw8GHDeyJbJIcttfjgEAYNaoVP8eabh7ixdaDVfFA==; 31:/mMZxcIICrkmSTeIGLwAjaS7HeGWgkaW8uZ85rNhuJzxMAwKOaR6ghfAbY1L5TMvA2CwsmCk4uqklcyyfOZwODB2jQAHstytleM4fIg1WUMO6lAAJTFfZwbsLIl/9IET0CXUrL1QE01VnQP42IYtawIhW3ha/eNahebOSNvhqvrGUZnJpoN9yl0zv/nQqUP7DZc1wicLbsc/N+2Ts4SAXLN5+3r6KxVCRpBFmWzqJyQ= X-MS-TrafficTypeDiagnostic: SN6PR07MB5006: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 20:ZQIHMyRrE+urGCAZvTthgDzkWg03ti+ZPy8eC4k1Oa4TknWhdHecgi9s4H2++VjNoXAxoZtRubB4fwMfBuTFl480ZB0ICM1pXxo40ESc6LuNAyf2My9mbUCts9J8PVgQ2bhG5nAwXjA185YbdPcMxLA3POVNWdllSInwCYPlSAzZOhN6njx2qXpM1k9WwFgC2NIaXp58BH+95FZ11S+8pB06rIf9utLjzrAhNPFSXYeUFcjQr6fbGVUepEphxfw2smaCUEjmOA/TLMXSfqPrExebqQTsTXDWr4BzL7N0OySjBkuUMmqBZrYWYytZvYSbBNbukmCcxvOGu712tlD+HB5bXEJAqS9ll+XlRJdMu7xuPGa9zMkTCxc721OTuFLkiRzkBTiZUnhsxIoDZFOmVsiHf594SBEs1vTl1b5bF1XNxcejp9GBZRT2gxnYwBhxnQYmpIh/xeatH+dPNsmTwx9Dz5wFExBaZsoLrzJZNHj/PjmDdKlMjLHJiyM83jN33bOtjKvxUQSUvj1cm3zTaq/OEad1GHx7p9KwOnxpSv8zb9uYpvcYXz4BT7FAzP7c3yiSxWy+VnsVv9ZW2z1gK9hsAsNrUZo0QDDrfjyDlkE=; 4:nWGxcoliSckC8tIphOFe4kRu80RCYOO6B/+3gHj9Kg7G6bii7l76Rua8LzjqN1ByIYQbPJ7km5DwnMTjaxIrHdYLrfBHTDRrnqAcIYhrBlPx3c6zr1vGudXC8UC4hrrizKHvbZYGMjK7iZBG08wTYuQP17DQHwZSt2FGe5rl9sXRCPJ00GeQ4sI9+7bZrlktxGg4GikQ0DJhdHnfNaUHW06Mcw3hkUuwEHHMhV39IPOq2j6qxovJ3ve2OZYptk/fKafdL8ITVXhDRrssRG0lkA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:SN6PR07MB5006; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5006; X-Forefront-PRVS: 0805EC9467 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(366004)(376002)(396003)(346002)(136003)(39860400002)(13464003)(199004)(189003)(6666003)(23726003)(6916009)(106356001)(97736004)(476003)(53546011)(386003)(81156014)(81166006)(14444005)(105586002)(6116002)(3846002)(33656002)(8936002)(76176011)(72206003)(55016002)(52116002)(2906002)(33716001)(229853002)(966005)(5009440100003)(1076002)(33896004)(6246003)(478600001)(9686003)(6306002)(25786009)(5660300001)(50466002)(53936002)(6496006)(4326008)(68736007)(16526019)(11346002)(186003)(42882007)(8676002)(44832011)(316002)(26005)(446003)(7736002)(93886005)(956004)(486006)(66066001)(16586007)(58126008)(47776003)(305945005)(18370500001)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5006; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5006; 23:vp6Am9zp6Fp6g0T0yqzeLBwuqv1NdrNCLZRKmfPSe?= =?us-ascii?Q?JTG5dw2AipYFF9qoi22FA8ENrspFWVnt+J0DlW9qW2lyc96XLEwWUCXhcAAk?= =?us-ascii?Q?hms6zji6+rdxK/X7DVG4wOpjz39oLmNa+3qVV0XoAqdHa/gUuF7uZKtV3MrH?= =?us-ascii?Q?sjTCwRqZV0Gny3IKFaNlLVp+CJDo0hDLASnfLrjp+K8T+Lwya0DhHjh3sOM8?= =?us-ascii?Q?sKKs/zL83NAE28bMmH9m3DmVmqST0AqLZevlgfa7E4EFPptyTu6t7e6veCK9?= =?us-ascii?Q?31qS1QuKnIKzq51QJXTWbDqIIMHNeB3dq+V/7gdMSYong8ZDK+YDJohxExYK?= =?us-ascii?Q?iYbuOSyfogD9FinCBOff0SSk4+MlY3p8ZWpGhW3QIyucuxoR8dRN7rYdVkgc?= =?us-ascii?Q?VKSl4tsb5CF5Ft2rPjM/rNjBfqfG6aefSFGJTRXdLRhd2MC+2bwxiQzwq4s5?= =?us-ascii?Q?zCMXU+KtBPZ7e4Vo9d1ihgE812ZFvUQhJP98yg9JTYUDgXR4/CtMoGQUyLZE?= =?us-ascii?Q?9h6e7smOhxy1R4senjiC1n60Z7Qj/M8aV3soiR+EI2ZqqVkbABTNpMnvVgva?= =?us-ascii?Q?DW1jIE9N9AexWzycGl2s9FvavtKb5UjmyFymBRZe4aQq3Lwk/94AwE6j5vpF?= =?us-ascii?Q?CsvN1cavpd9XK5aO1YTBvtOd8nso5A75fV5PAavF0aOJnMZQdq96vosb+vdl?= =?us-ascii?Q?S0uEdtxBe4FX0qNpIyb046qfDMhfh8+AmI7r/XXZMtuy/z31Bjb2gX/Dxp38?= =?us-ascii?Q?ufL5FNTFl1DBJDRJru5asd9pjp5qGU7GYjlE1U7lcJ8lQvDIqvfDMoXuB7+4?= =?us-ascii?Q?u8SvlEaTikKCy0n0InBypsMhZrxtorFo05pHwbP3jYte4MGm++D1Lg+U0oIV?= =?us-ascii?Q?x/4KMYqHMTpMMncnqUXyuRxtZuKTgUUsyvBAn3iQ+cgu46qR5O3zwtMpBnue?= =?us-ascii?Q?PyjcreUimcOhd73t0Q+bfX5xpal7cdyrNWYeY+D5JkGnYq/ipp+pYg0V+YEV?= =?us-ascii?Q?T/J0Zo8ejv/zjexQ1rF0OkTIczxOY1iPvyIgIzg9glsBcpMz/38Jjv1AQYHR?= =?us-ascii?Q?dOrYGSvkfuT0isdkrSjPLH95w8jcCD4ygo4YX711TFWoEGamOlZVfQShjriO?= =?us-ascii?Q?zBLeVfyI3Y9fZdYtCD9/ek4lRNBaVut2IuO8jDD2OBGjSjQ/b2zwOtjbIF7I?= =?us-ascii?Q?I/6mY0XK9YKQyLrhJHhncSsXjnmWsPJ+R7Lcd9QPW9HChbWTLjMl5UYMXJSi?= =?us-ascii?Q?1NJ6ckjH+cpyY9vwC7dwF1nIHG3Ga2kmmk/fX4uE6r6cnVUkEFZgBiXyVTkZ?= =?us-ascii?Q?e7C6cho6VbXygBgI4FytF37eXIy+OuoqdBI0ocP/qAm+1UYqjWOQl3wqEkA0?= =?us-ascii?Q?KcQ8ZCbQVJdQlaE0mK+YgQxt90ZJYscKoabxf5egxaQfBvQRs8D3vVv/FheO?= =?us-ascii?Q?9r6n9hc/firEyaCuX31053a4pvhZdIeDMDW9djGI4a1Fh9Ukt9yFKFIL+odA?= =?us-ascii?Q?yZt5jkN6zmUMqt9KGHa2Qm486SjvBltjChChcvEm66QTd9JfDe1NfJyGMnuU?= =?us-ascii?Q?0C/6KdqEQ5mL2NZyQ=3D=3D?= X-Microsoft-Antispam-Message-Info: OTh4I53zm7/mmbeOZXhhw12FN35BrqNtbEQoDJLl4Fi7tcVUkxoA1NNfPtC0GCFpmTsDKhI84MfWDu801+JaupdXXpy11H3U9ymYZif/VZAKkD5zZP5KbRakmP548T0kiv5xyGY92njTVZ0VWej44cajqIv73rIgdKn4ptBCIe9LbthqzmupLTZlgBmeoVmpyviWDK4Qft39uPddChSZIq24q3BbYHfs8fUqNe2Lm/9SmquMxOyFuHBq0fUIjpiWA9Svn51XnUZg2kF2ewXB24eieb/ljbpE0os1NEqfJeYTMhSy4iC3MQW3+1hzpuBov4RwfJ2jHGM2mBCoJKuI1zISw2rbwOHiwJHChQR/Pis= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 6:3Oy7cLqi61Pv34MyYnGPk1jrL+sWRuSxMAP7XnJvnONOuAE0wtWTwOc3dN2cmby3im8e4Cy3JGpf2hETRMhq7ZxM9X6V0rkK8TydUC7gqnvk0UVlWwbmEevtC8oTKD5ItTi3xVwiErPml4eJ4TQvoJLEq2oxaWMS+erID+1Aj9T8mDdyCckVLYay2P4dHWBjqXQpXqABuu60/P1G+vItVxqJs+AEdOmcVB7yjKDOFYh4oF35xMfJzMmakHHdKdRFI2noTG3zp2eylA5h+E7zHD22WeGL2UZbOk/wsqqJ4o/fR3184J8Z7zuH2dSnI8SnG3EE1rwhiumTr8vVfi0a80ZTPF4kGQ3uap6XMxBVVOD3HUxF56kFfL3sbjT2QFoyFMBbFwBGeXv7G9maC7n3aF061MDJi+sXOheuOHwI6zCznHuQpI9LtLYZlzsHYwpYQPrdx7Y/NPTT5pi5F0IdKQ==; 5:5Gkbr9aJJ98KQ421iSQhtFvzX/YzKbyUNODgUd7GEgWjAUgL+1piTD83r74x2jOJysB3dGFgq9YvtwvJUjISwmrJmCJxWSzvJoDUfDHU+09//oZq/hiFdqMudWNL3lGpou8B+KtbfaUa+y4JTdJbE9Czv/P4gl3DIlIwU6Y2kYg=; 7:26RonAAh1rbbJHyeE8kwVhvnGxmQccYlevi/P3U6CR88BTYI03uslr5/T4OSlvOJoq3XCgH2FpP4HEm7s+xknRsgAFgLssPdrDPixGfpFpWzdDeWzFUVJ+jPcLcUY1iYXzhuuftxuw+Nf1+3Bk7/b6hTUM0DYcnf+677TXBfrbSBcNM9BSXVkJmXjVCH6GzWbkKNt8FDQdUFaHWphfNaeYSEJ5JlP6mxlCxX0obgoxsFDnrh1C7ugqyZLuE15djj SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2018 14:45:17.9409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ae85be6-9c5d-41ab-afd4-08d6222c592f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5006 Subject: Re: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 14:45:21 -0000 -----Original Message----- > Date: Mon, 24 Sep 2018 10:30:30 +0200 > From: Andrzej Ostruszka > To: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter > support > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 23.09.2018 13:35, Jerin Jacob wrote: > > -----Original Message----- > >> Date: Thu, 20 Sep 2018 03:52:34 +0530 > >> From: Pavan Nikhilesh > [...] > >> - struct rte_event_dev_info info; > >> - struct test_pipeline *t = evt_test_priv(test); > >> - uint8_t tx_evqueue_id = 0; > >> + uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0}; > > > > Some old compiler throws error with this scheme. Please change to memset. > > Really? Could you give an example? > > That is perfectly legal C (since "forever"?) and I find it more readable > than memset. Don't treat it as a request to keep the original version - > if I were Pavan I would object this particular request since I prefer > direct initialization, however here I'm more interested in learning more > about your statement about compilers not supporting zero initialization > of array members after the last initializer. And maybe also about to > what extent we should be supporting old/non compliant compilers (the doc > suggest to use gcc 4.9+). Clang don't like this kind of zero-initialization depending on which type of parameter comes first in the structure. An array of uint8_t should be OK. I thought of keeping safe here as it was going for next revision. Unofficially, people used to test with old compiler such as gcc 4.7 etc. http://patches.dpdk.org/patch/40750/ // Search clang here. http://patches.dpdk.org/patch/38189/ > > Best regards > Andrzej