From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0073.outbound.protection.outlook.com [104.47.36.73]) by dpdk.org (Postfix) with ESMTP id 12FB7201 for ; Tue, 25 Sep 2018 06:42:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ESXKYpc0oPVehPnac4IhNam17b0j3rIg/OLf1cBzYc=; b=nALBU2e61Ik9tA4TNmOk6001Onq3WylZ5eZ8dEBgiECnVu/Sf6+jaXH8jrKqJixQflRED/JhDBIKKtI7fnfDXnFIyQyA/jwnaC1RiNarGDrXT+QTLPbwRiu6FXQjB/nyY7lOo1OuX86eMP5WM8y8aCHFN11lrhJ+xF+uH2tkCpU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN6PR07MB5007.namprd07.prod.outlook.com (2603:10b6:805:ac::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Tue, 25 Sep 2018 04:42:45 +0000 Date: Tue, 25 Sep 2018 10:12:29 +0530 From: Jerin Jacob To: Kevin Laatz Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, jianbo.liu@arm.com, gavin.hu@arm.com Message-ID: <20180925044228.GA21250@jerin> References: <20180907100626.8165-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180907100626.8165-1-kevin.laatz@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0049.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::11) To SN6PR07MB5007.namprd07.prod.outlook.com (2603:10b6:805:ac::33) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 996e2bbe-2adf-4827-7b34-08d622a157d8 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5007; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 3:Kxit2HS2g/JrIoasB2qXpYw0b+k3SbTt10wSOLIuSOz2G2Obtx5q8EO8jpQQHTgMBF/A+hUdAecV9jCyBEuc1ooVTuArhXEJ9TwPXWVDbdfyUX3x3oTUxHujqGXWR3MnGmFCKIu46B6IafyowBj5TxAAhLu1bisvCWJtDsLCDMT22C528/GtqVi+o9ftfOkWGCLWl9P9/Np4c6ZzakyTwir+VLu1e8Je/5VLx2qXr7A1BOD4FAOslQ5+HVC/4lxU; 25:MmTc5ldw8S1u3vL9pthtv2PYIdbqO5Ye14HXKSk8XSe7Xogyb6l8gEYfBI7nEE9sN42qzMkz6GwmMv144qXrwBGgmGGLgO1A9INkF4obWXPMif9suK8tybEGuxXwSplfG2Lk0grYpB2iyu/aKUKrUlRmqzNSB0d58RdzFjnUqDhN4JkDi0a/hoUBwNirxWSZEAaUNT59hos5JhMWGqRa2rA3nIyiFRTvrFF7y0LiaZh7HoAF18VHpeT0aaK7+B6zsoW6PTi0lBhmbObBehLyitm3UhMaLv7GTRB7ZD9A9UL+Nj5fjOknZ1BgHDglspTzrvloPhOBCdNpSLaA36ZgUQ==; 31:ypxZUhjJuG0l02y2uWYuPfFxHRNREWU5SokWBk0T48+CQRIGFZywV+RMC+/BrOQAVTYyuZvJzeoimZqLBqXBdwfNiErJuE2DJnraGdj17B1MCuSDUorJTwKMzQGI1Vcd/7njGGJnf8Q9JiZYNdyFx4h+TdzHs14SDJ6vi9zTpoWwbkVH6JngT45JhFHiT4q9mSrTv+bEYhs+p4l+xerll160MvlMFjESjVjp2NPHQcM= X-MS-TrafficTypeDiagnostic: SN6PR07MB5007: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 20:xB7M4ZTHOE5qlN4aiCpTgE7/av2Rli+21nta0gDLN0yR1B4LbiIBid2ymph8DrmpCnZ1IM9DqfNhj7uAZ4Hsl0hOtlq5FHCs9vvEtOMqL+1oPfwf6ifkhv02M6rQ/omA+9i12oTCXpnXinIDhmvzVvQrskRCl0yJoFOymT2O9t/enyB4Ete+1S9k29sIii79hJK7PSphgog11dh5Nq16BUnQXFRexX8mSh4ZmU6M7yVMqxULCCO3C7ju0dcCjnRnTRllxIb7oirNn/eCYI5SjiH5XxBhM9Fpn6IZpa9IXX56ZtucixxhfobenLAzvcP4pcYKGtoGvzh3WgIYlZNnN4eII2+pyz0pjtJhpMZOMslCJMPhrra1tQ38t92QSgePgYJ7I2Kq422lAKr9YuGP02/HweLrkOc3VcvP7KQpF1c4LK/SMNx7cGgeRiSsIQuIVRAzROC2Z3lt6mxOM4bQt+Lw65zSwe8+w12+5VJhvjZ45B0KKvZegdMK2OjTmF0G8qLTTI74mK/u4bMce101LJf83d6sUOpwXmGrg0QCZ+3gsSSjnu+l8T3smCcgt/Jso5jG1r/3hlcE4rg1E24MAtA07/DtjLJez5ObbOtdWaM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231355)(944501410)(52105095)(93006095)(3002001)(10201501046)(149066)(150027)(6041310)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051); SRVR:SN6PR07MB5007; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5007; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 4:viLlqfJLgY1ZAIEdNxHvOFLYqr293/k/2jBRWLtnXPxM6c82LJUDTk8Qrc+mvwMpHD9xQVg1GxrieB6t/Lx88SXikXQbIHz6kpPFrW3E0ONr5wgfVERbLHhmBu4iRyOQf3V3UOSyXaLLsQzI4nIULE/c0kg44ysPcMZVJ4fz8nmAkwFKdWjY+jF5Mb90zpeEZjV/RJQ9avQrSR62oLHFDcraAQpda1A916+GOAyRt7nZSeLKTUWuum4PDMBNfd3x5HgE3Tj31tcK9+KTBJ+H9XA6WPYBGOwPgMT7nlkLEJhko72yYwSpSxQFiAJ0m0UP3+qcZnXcpkvlJ4XOeBk1NXJGKPkGfjS/khMOG1Vf4+w= X-Forefront-PRVS: 08062C429B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39860400002)(136003)(396003)(346002)(199004)(13464003)(189003)(47776003)(14444005)(6916009)(2870700001)(72206003)(6666003)(316002)(58126008)(5660300001)(44832011)(23676004)(42882007)(3846002)(486006)(8676002)(229853002)(6496006)(9686003)(53936002)(11346002)(2486003)(305945005)(55016002)(446003)(476003)(956004)(52146003)(6116002)(7736002)(1076002)(33896004)(76176011)(16526019)(52116002)(68736007)(386003)(97736004)(26005)(186003)(478600001)(33656002)(106356001)(66066001)(4326008)(6246003)(33716001)(50466002)(8936002)(25786009)(81156014)(2906002)(81166006)(105586002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5007; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjZQUjA3TUI1MDA3OzIzOjl5Tm8xeUc2QjZsbTRBNWpkK2dIRGJYVGw2?= =?utf-8?B?VnlTS2VPaDQvZVBIS2FDRnhwZGVsTTR5dWoxdGUzOXRTTmcrQ0JBdDM5TVJJ?= =?utf-8?B?RzJGN203TnM2ZzByRjEvb29PZEgzSVpXTE5Yb1NxSjk1TzFwSi9kYjMwQ2dp?= =?utf-8?B?MkY0ZXE0OUl4TGkvU0pLU1FTZCtqWkJRR1VNNmtDaGJoeWpKNGhzMlg1TWxX?= =?utf-8?B?Y25iOG8yNDZQVFhTa1hOZWVKRnJzR2hVZ2ttaEtzSzdaSnh4Y3pkeEVibHI4?= =?utf-8?B?cFgzVUtPaGdhbUlqRE5idnh1OUlpMUdHcVFldzBtUDc2Z1g0SHRrWGN1cDAy?= =?utf-8?B?MGJmYWcvclh6RjlXT0piSVRHaHlUNk9IdGt3WTlUT0liV1NWSUQxNlRkZUpB?= =?utf-8?B?OURQSEFJNzUxMlBmYUVWMHoxL0h1amkxSU0yWHpjMG5wSXUwL21XczBGZnlR?= =?utf-8?B?b1BWZUh4MmZ3L3orQktOWE0vZzFOU0tRbDVIQnNSemRrYW00dXFSL2kwaXZa?= =?utf-8?B?U01RaWNIbkl3SVdDdUR3M0s4M0NsNkhBZUVCaXduL2VzODZxWFFyRC9WNngy?= =?utf-8?B?bzl1Zk9hWEg1eFIydTJOQ3ZVdDV4L3lLRWYrK3FLOTZXYjlVMmNITTduYjZ0?= =?utf-8?B?N0VkclpWaVl3Q1hSZ1pGSm5FQ3VDUEJVR0lIckw2OVBULzBwdEcwQjB3RC9y?= =?utf-8?B?R3JaUjhwOGNvbFVDZ2EwQWFWMmxOaXk0NWI5bDI3SkZNVXVCUnpkUHg0S1FR?= =?utf-8?B?aFlrSk1HMUg1ZmFFMDRaemNWQVNKQWZwK3dRcWtqaEo3bVRXRDltTkYvTFp0?= =?utf-8?B?c3hpQVVHZHZrSzZrK2VxaFEvbmVtVnJ2N2FnN0xVaVg5c2VlYWRac0hQV2Np?= =?utf-8?B?a3E1a0cwY3NwSFpmemdrUkFjbDFIcU9VK3Bpdy9ReDZQZjM2S3pCK2tseTN5?= =?utf-8?B?ZmxuYyswYVdqUThzU3d1WWlKb3psVVRTYWZVVTd0M1dvclhnQzBoSFpuSU9T?= =?utf-8?B?RWRGM3Z5ZC9Qc1pCWnJkeTJ1TnBBVGdtTFlZV2R0V2FHd1RXTnU1eWxLWXRx?= =?utf-8?B?eVhXNlcxV2JJQ20xRXVxZEpLcjNTQjlHWUNKYWxXN2NtM0MxTWk4WXpvSWZE?= =?utf-8?B?N1lWR0Y5eHB0QzI3cmNLcUlUQUdFdC9pQmF5b2tpdk44MG12Y3VYU0RnVmZ1?= =?utf-8?B?TExQVFRoSDVwdnpRTDEwWmxpaEQ0bmo2NVVkZkJZMFdKRndqMzh4bkpaU0xB?= =?utf-8?B?NE1aUjNpeGc5cHkyUlB2MVJlQjFsRS9zYUVFRW5XSTVmNytBUnRFN0NGaW9S?= =?utf-8?B?OUxxQ29aOHFzRnFGa2Y4dTFxMDVGN1FhZGl0ZDN2dWRKRkUza2pQZzAwQzZJ?= =?utf-8?B?NzAvblB5REY1Zjh5Sk1ieENDd05RaUxUVmpaRTdGaHNDbm5BYUE2eVN6TEF0?= =?utf-8?B?bWdKckwvbGJJOUlQejU2VVlpTmRUeHBCdlJldi8zS294L3kxTnpVb0RWZEI1?= =?utf-8?B?a0M1TUQydUU1cXZSOW9jWDBmUE5BMDNYUmRlcWR6bUY5UzYyTTJoNFBmalBR?= =?utf-8?B?THM2cEZ3UGdUQS96bFozV2pzWFBIampTdWhnY1RhVFVjSGRZZC9tbCsya3RN?= =?utf-8?B?b1BtTzhpQXkvZnkrQXZxSkQ1dTRWS2RwUUlPd29CZHo1azVWRjBWbC9aZkxE?= =?utf-8?B?TXo1R0l0TFhra0RWMUl3b3d0QXV6dWN3R2MybTl6UkJuVjM2QWxlRVRWUXNQ?= =?utf-8?B?ci9QZmVFZklpOVpxT1BXSXNVaUFoMWtEV05KTGQ0T01CdGFFNkR0UzNJOGpo?= =?utf-8?B?YktHbUhJNEE1UnhVRzJwZlh3Nzg2YldmaXJOZmJiaDU4MGY0azJkNi9GOWM0?= =?utf-8?Q?yI3o/PaPmRM=3D?= X-Microsoft-Antispam-Message-Info: TtCbqkgeY3McockTVtS/W+ZI4HPHgT2+blSsroJwHvNZwMXEsqOzbNLWscVy6/ruTukrF82BVyE0S5FG049Fduwqr5FzDfMtf8YMGkj6EYG+dSE1DBwX4/MQ24k8F+5ZU9ufMynpe5bt6AeXiLybOEskxDLPYtAxZRyBGvBORnFPpL4P9ip0VgDSBiMjj3fPWfQZBOkupcFdEGEb9p55mvP0E1rWyZL8OaMHYq5RZ5XMNNqlYjeB2+7z6rbifJd3yLnXEEO0jTfn3J8G5gcXp0fr/upkzznmH2JuKq1+7B7NzC8YRncrfwHCBysdC9iN8UM77GPkY0jS0IRPtsEbOvlSoZ5DHaZ9AgGi2AXAfHA= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5007; 6:8TACBDwUwJKfRKgyRg1hr6UJncS5Ot0zwtNbuXVNCF50crxzFZdD7ErijvlHArbFzHMLPNvJmybKhtFcRdryWWCAxUsBvi05e/uRCa3b30C6ThqqKsKTVgsnL9gzTTp0bqIQhh3qA4FzgDN64gpNtaQ5ybhnQp38HvrIV45QCWUO6bo3wMWWiLjt8xSMQKyAhXmUVQ9CdLxgNLGgTKuoTiVq4SFuDT/hPK/4jOs21Ch6QVEMPpn+F5s8FFgqV3HtE8/fLicXrMwnJpUT4nlpAfjrvzu/DjaHcSDAVQngl9BgjGhVCyTdBK52/ZnAJCYQAiF+s4QuH0D9+fHuwodAX76LqXlCVd1xjLWtiUrtGYjus5eEDWhI8skFGN9x6HRWvhZhXqnB11ilqmPVcmTgvvwjmFQpXQ8pJ0rgFgwcveuFXDNPXS+5ZolT5arPajAKPfQ3zEanwE/hzccC1BIuWg==; 5:Cz62EtRZ2XKtdCDxT/KGadMTE/0r8Cu8dZSyuPFsqtngXeM/cQlCbxp+FnXKONMM3P+b+q2mEDkHITYhetaBGv5pgDr+jqTT6oV9HrV6MkABspjdwVGfoFjBVgQC+j3EQkNZFUvnmHjzXzTYqfb4nOeoN7qIeBsNZDmLUvrN134=; 7:qEUqSzL4RRYrHbZvNKO4Yhx8V6ND7HQzeq9fnJ94HhZkoH4/z2YRzUT3KrnZmVxJOhMZg4Kaa5gnlIAcv0xYd2W3hKreasM/ztehXINUsAA5HWRd19HWyrmFEKkWEWtnXhTqZaPPNPaikWgdorEUsqhHGmvx6DdhLNh8qaJhdukyWTCbPbjx0cxkzK73tQUodfTP1/lablgUa+BCk3C5PeolNHm6gCGLBn0Fx8lPfkvlZpznqUBc15U6FER5r9BA SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2018 04:42:45.3370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 996e2bbe-2adf-4827-7b34-08d622a157d8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5007 Subject: Re: [dpdk-dev] [PATCH v3 1/3] lib/librte_table: add hash_func header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 04:42:50 -0000 -----Original Message----- > Date: Fri, 7 Sep 2018 11:06:24 +0100 > From: Kevin Laatz > To: dev@dpdk.org > CC: cristian.dumitrescu@intel.com, jianbo.liu@arm.com, gavin.hu@arm.com, > jerin.jacob@caviumnetworks.com, Kevin Laatz > Subject: [PATCH v3 1/3] lib/librte_table: add hash_func header files > X-Mailer: git-send-email 2.9.5 > > This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to > librte_table. This reduces code duplication by removing duplicate header files > within two folders and consolidating them into a single one. This also adds a > scalar implementation of the x86_64 intrinsic for crc32 as a generic fallback. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Kevin Laatz > Acked-by: Gavin Hu > --- > v2: > - Fixed typo in commit message > - Fixed typo in arm header that caused some compilations to fail for the > entire patchset > v3: > - Improved commit message ARM specific change and this patchset looks good. But, It has following checkpatches.sh and check-git-log.sh errors. ➜ [master][dpdk.org] $ ./devtools/checkpatches.sh ### lib/librte_table: add hash_func header files WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #7: librte_table. This reduces code duplication by removing duplicate header files total: 0 errors, 1 warnings, 298 lines checked ERROR: symbol rte_crc32_u64_generic is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key16 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key24 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key32 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key40 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key48 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key56 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key64 is added in a section other than the EXPERIMENTAL section of the version map ERROR: symbol rte_table_hash_crc_key8 is added in a section other than the EXPERIMENTAL section of the version map 2/3 valid patches ➜ [master][dpdk.org] $ ./devtools/check-git-log.sh Wrong headline format: lib/librte_table: add hash_func header files examples/ip_pipeline: modify application to use librte_table headers net/softnic: modify softnic to use librte_table headers Headline too long: examples/ip_pipeline: modify application to use librte_table headers Line too long: librte_table. This reduces code duplication by removing duplicate header files within two folders and consolidating them into a single one. This also adds a scalar implementation of the x86_64 intrinsic for crc32 as a generic fallback.