From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com
 [209.85.208.68]) by dpdk.org (Postfix) with ESMTP id 068634C93
 for <dev@dpdk.org>; Tue, 25 Sep 2018 10:49:20 +0200 (CEST)
Received: by mail-ed1-f68.google.com with SMTP id y21-v6so6370872edr.2
 for <dev@dpdk.org>; Tue, 25 Sep 2018 01:49:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Qc69uWbwVh9QClFmb2Jy9y5++jMDjHf+rZ9meGLITMA=;
 b=msvbi1hGml4Mf8+yfL9W5V1TlEusfD9NMegDID4NUono/n3U/PQgVhvQlK7a5M7CST
 b1NoGMeVfqgIwhx0AuEReQugwe3xPjNfhaN39/D+2is4t6JBmR217DuHLfoaquoBYaXs
 BCKsR6QzoWto6z2zjseHANYbQqDxBhQrHf2eHuFMzQYfLEvbiGKQETxQOvJVZzR/GkCK
 Zp0Bw4AoabxTiOHeLwkIucPPL39U3xa8ZEs2XtV6X9uPNUjU7D5ggVcVpYzNIi603qgT
 cgUytMBLXRdUxWY4dH1GKX84mnwE2hI2ndE/1OfiDKOIObkEDPf6b6Xek3PYEQxA9+xH
 UqFQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Qc69uWbwVh9QClFmb2Jy9y5++jMDjHf+rZ9meGLITMA=;
 b=uimYp1KNqEWahslq3w82W+RHmjuaqt/qry1lQfazqygXXOml8O5jk9Wau1mfV20L2j
 MRW1gyDCXap/ug3k0Gptji+w8srt7AyfONNCt6BHVMHA+1Y5irLvklILeSpHXCUv7Jwh
 zpN0N7KtyXMT3Bs7Nb6EBmPvPRnhvOlnOe9/LWUnO8xBHUuu04vNv+5K+I5J+vyEx9mh
 jwD/q2NTmDmaCDdky9eY8kzxPe+ObpzrlOXdQiz32V9C4+CEtFG4bvdUKkaD9ilHhsa5
 xTvDMBIaq3AkGXo0NJQctlcZyKO6SCfL6JfbsyTrxB7Jxp3HV8KHFB2wCBHwFPCp7905
 Z2DQ==
X-Gm-Message-State: ABuFfojbJlTmY9xoJg3AVwFbJbVAOZm2s+pRMk7iF6uX0ESdUvB6MCW+
 /4WnAeasnphCCFbfIWzSgaArw99ASMd5Dw==
X-Google-Smtp-Source: ACcGV63Z7U31wmJP2PwrSfvMvjw6cwAY9OAUBk8c+EXLyyuuwv2/sP23pJj6MFvAk3iMf7shmFuFMQ==
X-Received: by 2002:a50:ba43:: with SMTP id 3-v6mr548066eds.227.1537865360363; 
 Tue, 25 Sep 2018 01:49:20 -0700 (PDT)
Received: from shemminger-XPS-13-9360 ([213.244.170.154])
 by smtp.gmail.com with ESMTPSA id l4-v6sm8007033edb.41.2018.09.25.01.49.19
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 25 Sep 2018 01:49:20 -0700 (PDT)
Date: Tue, 25 Sep 2018 10:49:17 +0200
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Stephen Hemminger <sthemmin@microsoft.com>
Message-ID: <20180925104917.589fcd61@shemminger-XPS-13-9360>
In-Reply-To: <c43b1194-9c54-19a0-92b2-090664286f01@intel.com>
References: <20180921165425.18168-1-stephen@networkplumber.org>
 <c43b1194-9c54-19a0-92b2-090664286f01@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] netvsc: support multicast/promiscuous
 settings on VF
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 08:49:21 -0000

On Mon, 24 Sep 2018 16:49:24 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 9/21/2018 5:54 PM, Stephen Hemminger wrote:
> > Provide API's to enable allmulticast and promiscuous in Netvsc PMD
> > with VF. This keeps the VF and PV path in sync.  
> 
> VF and PF?
> 
> > 
> > Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> > ---
> > Patch against dpdk-net-next
> > 
> >  drivers/net/netvsc/hn_ethdev.c | 14 +++++++++++++
> >  drivers/net/netvsc/hn_var.h    |  9 +++++++++
> >  drivers/net/netvsc/hn_vf.c     | 37 ++++++++++++++++++++++++++++++++++
> >  3 files changed, 60 insertions(+)
> > 
> > diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> > index b67cce1ba8f5..3092066ada36 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -255,6 +255,7 @@ hn_dev_promiscuous_enable(struct rte_eth_dev *dev)
> >  	struct hn_data *hv = dev->data->dev_private;
> >  
> >  	hn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_PROMISCUOUS);
> > +	hn_vf_promiscuous_enable(dev);  
> 
> This VF approach is confusing to me, is this calling a underlay device a VF device?

Yes. This driver supports the Hyper-V/Azure accelerated networking model where the
synthetic para-virtual device has a associated SR-IOV VF device. It is a less general
version of what failsafe supports. The choice of hn_vf_XXX naming is to identify those
functions which do operations on the underlying device.

> 
> > +static int
> > +hn_dev_mc_addr_list(struct rte_eth_dev *dev,
> > +		     struct ether_addr *mc_addr_set,
> > +		     uint32_t nb_mc_addr)  
> 
> Just to double check, this dev_ops to add MAC multicast filters, to add MAC
> filters it is mac_addr_set, mac_addr_add, mac_addr_remove. Many HW seems can set
> the multicast MAC filters via "mac_addr_add" too.
> 
> If this is the intention please enable "Multicast MAC filter" in netvsc.ini

Maybe, the para-virtual device doesn't do MC filtering, only the VF device does.
The RNDIS API to host does not support filtering, only the VF path does.

I am unsure. Perhaps best not to advertise MC address filtering. It doesn't matter
for Azure (it does not support real Multicast); only for local Hyper-V.