* [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure
@ 2018-09-25 14:31 Ferruh Yigit
2018-09-25 13:44 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-09-25 14:31 UTC (permalink / raw)
To: Thomas Monjalon, Andrew Rybchenko
Cc: dev, Ferruh Yigit, Paul M Stillwell Jr, ivan.boule, stable
From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
The doxygen comment describing the rte_eth_dev_info structure
was separated from the structure itself so move the comment
back to be with the structure.
Fixes: 7238e63bce52 ("ethdev: add support for device offload capabilities")
Cc: ivan.boule@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
---
lib/librte_ethdev/rte_ethdev.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 44b4fb33f..012577b0a 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -869,12 +869,6 @@ struct rte_eth_conf {
struct rte_intr_conf intr_conf; /**< Interrupt mode configuration. */
};
-/**
- * A structure used to retrieve the contextual information of
- * an Ethernet device, such as the controlling driver of the device,
- * its PCI context, etc...
- */
-
/**
* RX offload capabilities of a device.
*/
@@ -1005,6 +999,12 @@ struct rte_eth_switch_info {
/**
* Ethernet device information
*/
+
+/**
+ * A structure used to retrieve the contextual information of
+ * an Ethernet device, such as the controlling driver of the
+ * device, etc...
+ */
struct rte_eth_dev_info {
struct rte_device *device; /** Generic device information */
const char *driver_name; /**< Device Driver name. */
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure
2018-09-25 14:31 [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure Ferruh Yigit
@ 2018-09-25 13:44 ` Thomas Monjalon
2018-09-25 15:43 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-09-25 13:44 UTC (permalink / raw)
To: Ferruh Yigit, Paul M Stillwell Jr
Cc: Andrew Rybchenko, dev, ivan.boule, stable
25/09/2018 16:31, Ferruh Yigit:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> The doxygen comment describing the rte_eth_dev_info structure
> was separated from the structure itself so move the comment
> back to be with the structure.
>
> Fixes: 7238e63bce52 ("ethdev: add support for device offload capabilities")
> Cc: ivan.boule@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Good catch!
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure
2018-09-25 13:44 ` Thomas Monjalon
@ 2018-09-25 15:43 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-09-25 15:43 UTC (permalink / raw)
To: Thomas Monjalon, Paul M Stillwell Jr
Cc: Andrew Rybchenko, dev, ivan.boule, stable
On 9/25/2018 2:44 PM, Thomas Monjalon wrote:
> 25/09/2018 16:31, Ferruh Yigit:
>> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>>
>> The doxygen comment describing the rte_eth_dev_info structure
>> was separated from the structure itself so move the comment
>> back to be with the structure.
>>
>> Fixes: 7238e63bce52 ("ethdev: add support for device offload capabilities")
>> Cc: ivan.boule@6wind.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> Good catch!
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-25 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-25 14:31 [dpdk-dev] [PATCH] ethdev: fix doxygen comment to be with structure Ferruh Yigit
2018-09-25 13:44 ` Thomas Monjalon
2018-09-25 15:43 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).