From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id BEE5F1B439 for ; Wed, 26 Sep 2018 14:57:10 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 05:57:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208";a="266848605" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga006.fm.intel.com with SMTP; 26 Sep 2018 05:57:07 -0700 Received: by (sSMTP sendmail emulation); Wed, 26 Sep 2018 13:57:06 +0100 Date: Wed, 26 Sep 2018 13:57:06 +0100 From: Bruce Richardson To: Yipeng Wang Cc: dev@dpdk.org, michel@digirati.com.br, honnappa.nagarahalli@arm.com Message-ID: <20180926125706.GB14380@bricha3-MOBL.ger.corp.intel.com> References: <1536253745-133104-1-git-send-email-yipeng1.wang@intel.com> <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1537550255-252066-1-git-send-email-yipeng1.wang@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 12:57:11 -0000 On Fri, Sep 21, 2018 at 10:17:28AM -0700, Yipeng Wang wrote: > The first four commits of the patch set try to fix small issues of > previous code. > > The other commits make two major optimizations over the current rte_hash > library. > I'd suggest splitting this set into two. The first 4 patches are easy to review and should be quickly merged (I hope :-)), allowing us to focus more on the bigger patches adding the key new feature support. /Bruce