From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id ABF771B452
 for <dev@dpdk.org>; Thu, 27 Sep 2018 14:30:57 +0200 (CEST)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 27 Sep 2018 05:30:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,310,1534834800"; d="scan'208";a="267226726"
Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107])
 by fmsmga006.fm.intel.com with SMTP; 27 Sep 2018 05:30:54 -0700
Received: by  (sSMTP sendmail emulation); Thu, 27 Sep 2018 13:30:53 +0100
Date: Thu, 27 Sep 2018 13:30:53 +0100
From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Raslan Darawsheh <rasland@mellanox.com>, dev@dpdk.org,
 shahafs@mellanox.com, orika@mellanox.com
Message-ID: <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com>
References: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
 <9568922.17cOiG4SW6@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9568922.17cOiG4SW6@xps>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint
 handler to server
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 12:30:58 -0000

On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote:
> 27/09/2018 13:26, Raslan Darawsheh:
> > v2:
> > 	- fix includes order
> 
> I'm afraid you will need a v3 to fix spacing :)
> 
> > --- a/examples/multi_process/client_server_mp/mp_server/main.c
> > +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> > @@ -37,6 +37,7 @@
> >  #include "common.h"
> >  #include "args.h"
> >  #include "init.h"
> > +#include<signal.h>
> 
> A space is missing here.
> 

Also, the norm in DPDK is to list all standard headers first, then the DPDK
headers and finally the local headers. "signal.h" therefore should be
further up in the file, with the first group.

> > +static void signal_handler(int signal)
> > +{
> > +	uint16_t port_id;
> > +
> > +	if (signal == SIGINT)
> > +		RTE_ETH_FOREACH_DEV(port_id) {
> > +			rte_eth_dev_stop(port_id);
> > +			rte_eth_dev_close(port_id);
> > +		}
> > +	exit(0);
> > +}
> >  int
> >  main(int argc, char *argv[])
> 
> A blank line is missing between the functions.
> 
>