From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 10D6B1B48D for <dev@dpdk.org>; Thu, 27 Sep 2018 16:40:36 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Sep 2018 07:40:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,311,1534834800"; d="scan'208";a="89950492" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 27 Sep 2018 07:37:04 -0700 Received: by (sSMTP sendmail emulation); Thu, 27 Sep 2018 15:37:03 +0100 Date: Thu, 27 Sep 2018 15:37:02 +0100 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Raslan Darawsheh <rasland@mellanox.com>, dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com Message-ID: <20180927143702.GA2380@bricha3-MOBL.ger.corp.intel.com> References: <1538047613-27309-1-git-send-email-rasland@mellanox.com> <9568922.17cOiG4SW6@xps> <20180927123053.GB776@bricha3-MOBL.ger.corp.intel.com> <5489324.HoVYYzflKP@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5489324.HoVYYzflKP@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint handler to server X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 27 Sep 2018 14:40:37 -0000 On Thu, Sep 27, 2018 at 02:48:38PM +0200, Thomas Monjalon wrote: > 27/09/2018 14:30, Bruce Richardson: > > On Thu, Sep 27, 2018 at 01:36:06PM +0200, Thomas Monjalon wrote: > > > 27/09/2018 13:26, Raslan Darawsheh: > > > > v2: > > > > - fix includes order > > > > > > I'm afraid you will need a v3 to fix spacing :) > > > > > > > --- a/examples/multi_process/client_server_mp/mp_server/main.c > > > > +++ b/examples/multi_process/client_server_mp/mp_server/main.c > > > > @@ -37,6 +37,7 @@ > > > > #include "common.h" > > > > #include "args.h" > > > > #include "init.h" > > > > +#include<signal.h> > > > > > > A space is missing here. > > > > > > > Also, the norm in DPDK is to list all standard headers first, then the DPDK > > headers and finally the local headers. "signal.h" therefore should be > > further up in the file, with the first group. > > I think he did that already in v3 :) > Yes, he did. I just need the ability to read all mails in parallel, while also typing up new ones. :-)