DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/3] net/enic: fix flow API memory leak
@ 2018-09-28  1:58 John Daley
  2018-09-28  1:58 ` [dpdk-dev] [PATCH 2/3] net/enic: support for flow counter action John Daley
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: John Daley @ 2018-09-28  1:58 UTC (permalink / raw)
  To: ferruh.yigit; +Cc: dev, John Daley, stable, Hyong Youb Kim

rte_flow structures were not being freed when destroyed or flushed.

Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
Cc: stable@dpdk.org

Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Reviewed-by: John Daley <johndale@cisco.com>
---
 drivers/net/enic/enic_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
index 0cf04aefd..9b612f1d5 100644
--- a/drivers/net/enic/enic_flow.c
+++ b/drivers/net/enic/enic_flow.c
@@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
 	enic_flow_del_filter(enic, flow->enic_filter_id, error);
 	LIST_REMOVE(flow, next);
 	rte_spinlock_unlock(&enic->flows_lock);
+	rte_free(flow);
 	return 0;
 }
 
@@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
 		flow = LIST_FIRST(&enic->flows);
 		enic_flow_del_filter(enic, flow->enic_filter_id, error);
 		LIST_REMOVE(flow, next);
+		rte_free(flow);
 	}
 	rte_spinlock_unlock(&enic->flows_lock);
 	return 0;
-- 
2.16.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-10-02 14:49 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28  1:58 [dpdk-dev] [PATCH 1/3] net/enic: fix flow API memory leak John Daley
2018-09-28  1:58 ` [dpdk-dev] [PATCH 2/3] net/enic: support for flow counter action John Daley
2018-09-28  1:58 ` [dpdk-dev] [PATCH 3/3] doc: update enic guide for flow API " John Daley
2018-09-28  3:08 ` [dpdk-dev] [PATCH v2 1/3] net/enic: fix flow API memory leak John Daley
2018-09-28  3:08   ` [dpdk-dev] [PATCH v2 2/3] net/enic: support for flow counter action John Daley
2018-09-28  3:08   ` [dpdk-dev] [PATCH v2 3/3] doc: update enic guide for flow API " John Daley
2018-10-02 14:49   ` [dpdk-dev] [PATCH v2 1/3] net/enic: fix flow API memory leak Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).