From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiaolong.ye@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id B00131B143
 for <dev@dpdk.org>; Fri, 28 Sep 2018 02:44:26 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 27 Sep 2018 17:44:25 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,312,1534834800"; d="scan'208";a="76984772"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207])
 by orsmga008.jf.intel.com with ESMTP; 27 Sep 2018 17:44:24 -0700
Date: Fri, 28 Sep 2018 15:32:21 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, xiao.w.wang@intel.com,
 Rami Rosen <roszenrami@gmail.com>, Wang Haiyue <haiyue.wang@intel.com>
Message-ID: <20180928073221.GA37170@intel.com>
References: <20180925120716.102144-1-xiaolong.ye@intel.com>
 <20180926090638.4705-1-xiaolong.ye@intel.com>
 <20180926090638.4705-3-xiaolong.ye@intel.com>
 <2404f5d8-beed-08fe-06bf-451868e3e9d3@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2404f5d8-beed-08fe-06bf-451868e3e9d3@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v6 2/2] examples/vdpa: introduce a new sample
	for vDPA
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 00:44:27 -0000

On 09/27, Maxime Coquelin wrote:
[snip]
>> +	devcnt = 0;
>This isn't needed as it is static.
>
>> +	interactive = 0;
>Ditto
>
>> +	memset(iface, 0, sizeof(iface));
>Ditto
>
>> +	memset(vports, 0, sizeof(vports));
>And this one too when it will be made static.
>
>
>Appart these small comments, it looks good to me.
>When fixed, please apply my:
>
>Reviewed-by: Maxime coquelin <maxime.coquelin@redhat.com>
>

Thanks for your comments, I'll adpot all the static related suggetions.

Thanks,
Xiaolong
>Thanks,
>Maxime