From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xiaolong.ye@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 1B4631B12E
 for <dev@dpdk.org>; Fri, 28 Sep 2018 09:45:59 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 28 Sep 2018 00:45:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,314,1534834800"; d="scan'208";a="267682544"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.207])
 by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2018 00:45:57 -0700
Date: Fri, 28 Sep 2018 22:33:53 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, Tiwei Bie <tiwei.bie@intel.com>,
 Zhihong Wang <zhihong.wang@intel.com>, xiao.w.wang@intel.com,
 Rami Rosen <roszenrami@gmail.com>, Wang Haiyue <haiyue.wang@intel.com>
Message-ID: <20180928143353.GA44187@intel.com>
References: <20180926090638.4705-1-xiaolong.ye@intel.com>
 <20180928112344.42791-1-xiaolong.ye@intel.com>
 <20180928112344.42791-3-xiaolong.ye@intel.com>
 <e1452c00-6fd8-89a1-0722-f77cf4893650@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e1452c00-6fd8-89a1-0722-f77cf4893650@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v7 2/2] examples/vdpa: introduce a new sample
	for vDPA
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Sep 2018 07:46:00 -0000

On 09/28, Maxime Coquelin wrote:
>> +	ret = rte_eal_init(argc, argv);
>> +	if (ret < 0)
>> +		rte_exit(EXIT_FAILURE, "eal init failed\n");
>> +	argc -= ret;
>> +	argv += ret;
>> +
>> +	data_init();
>
>You need to check return from data_init().
>If this is fine for you, I can change to below code when applying:
>
>ret = data_init();
>if (ret < 0)
>    rte_exit(EXIT_FAILURE, "data init failed\n");
>
> 

I'm fine with this change.

Thanks,
Xiaolong