From: Stephen Hemminger <stephen@networkplumber.org>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: implement header_ops parse method
Date: Sat, 29 Sep 2018 09:21:59 +0200 [thread overview]
Message-ID: <20180929092159.6b50e439@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20180927000224.4011-1-iryzhov@nfware.com>
On Thu, 27 Sep 2018 03:02:24 +0300
Igor Ryzhov <iryzhov@nfware.com> wrote:
> +/*
> + * Extract hardware address from packet
> + */
> +static int
> +kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
> +{
> + const struct ethhdr *eth = eth_hdr(skb);
> +
> + memcpy(haddr, eth->h_source, ETH_ALEN);
> +
> + return ETH_ALEN;
> +}
Kernel has function ether_addr_copy which is marginally faster and
commonly used.
next prev parent reply other threads:[~2018-09-29 7:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 0:02 Igor Ryzhov
2018-09-29 7:21 ` Stephen Hemminger [this message]
2018-09-29 19:19 ` Igor Ryzhov
2018-09-30 8:22 ` Igor Ryzhov
2018-10-02 16:58 ` Ferruh Yigit
2018-11-30 19:07 ` Igor Ryzhov
2019-01-24 9:18 ` Igor Ryzhov
2019-01-24 14:10 ` Ferruh Yigit
2019-01-24 16:35 ` Igor Ryzhov
2019-01-24 17:15 ` Ferruh Yigit
2019-01-24 18:05 ` Igor Ryzhov
2019-04-08 16:59 ` Igor Ryzhov
2019-04-08 16:59 ` Igor Ryzhov
2019-04-09 20:30 ` Ferruh Yigit
2019-04-09 20:30 ` Ferruh Yigit
2019-04-10 10:30 ` [dpdk-dev] [PATCH v2] " Igor Ryzhov
2019-04-10 10:30 ` Igor Ryzhov
2019-04-12 14:52 ` Ferruh Yigit
2019-04-12 14:52 ` Ferruh Yigit
2019-04-12 14:53 ` Ferruh Yigit
2019-04-12 14:53 ` Ferruh Yigit
2019-04-12 17:12 ` Igor Ryzhov
2019-04-12 17:12 ` Igor Ryzhov
2019-04-12 17:15 ` Ferruh Yigit
2019-04-12 17:15 ` Ferruh Yigit
2019-04-15 8:37 ` Igor Ryzhov
2019-04-15 8:37 ` Igor Ryzhov
2019-04-15 15:49 ` Ferruh Yigit
2019-04-15 15:49 ` Ferruh Yigit
2019-04-19 10:36 ` Thomas Monjalon
2019-04-19 10:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929092159.6b50e439@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).