From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by dpdk.org (Postfix) with ESMTP id AF0CC2C8 for ; Sat, 29 Sep 2018 11:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9nT0MMmKIuuPwbzClbTbR/1EFESDghd00RIqmVLXeCE=; b=uOEGEH+W9GIeRIFqhIpGvSXWGnHzJ4iwWXDG21WKOWcksmcfrUR8yziyemNgTBu7a8ZtLJd8tUL9nW7NMF0Cpl3+5Y3I/AaTJRf+vL7foBHUezeCfdDalM/LCTmsMUOG7ZfmKfnXC2AWn0ritoxYDycQHttlirGu3FoGbANpr+0= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4058.eurprd05.prod.outlook.com (52.134.68.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.19; Sat, 29 Sep 2018 09:24:24 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1164.024; Sat, 29 Sep 2018 09:24:24 +0000 From: Yongseok Koh To: Dekel Peled CC: "dev@dpdk.org" , Shahaf Shuler , Ori Kam Thread-Topic: [PATCH] net/mlx5: allow flow rule with attribute egress Thread-Index: AQHUVm4267zlLzBSLUiKLz3GcDnD5KUG/4UA Date: Sat, 29 Sep 2018 09:24:24 +0000 Message-ID: <20180929092415.GB95127@minint-98vp2qg> References: <1538058330-34990-1-git-send-email-dekelp@mellanox.com> In-Reply-To: <1538058330-34990-1-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN6PR0102CA0036.prod.exchangelabs.com (2603:10b6:805:1::49) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB4058; 6:ExNreu4VO3P9jIcs2gegadZxlZ+rDSHYp8tTxy1GHgQGosD0skfYgFSHsFi2CTTyC16VUKk0upGdjo49kGtNo5aki0RTXyPaQ6d2S0i03OzdlwcZxTUTjTHw017cc8TD5bn1xlmsZj0TajG+0UGiAg0lUkdMda/WVLLULxgBlW6E0F2vLhCX1Z/hlTIgzx9F8U5nMJZPuFaZ+ZGDL8/hdhIt5mLAWTaYTX34eWXHf761tm+xJFphixeMCUf+hmLJGLCcuqpVvRciTcEnd7MAorMQ1jKK/0URdCYj1nei356y00xq6UhaMJLiZl7+1htrKcny+X3PGTIzp87rHOucO7uPXdKrUNRIrXVYkM9rnjwapr7HccVT3PsjtIXZgWvpkM+0PRCtOxqtVJNcB1sS5myopoLCSFgm5UbhxU0ozHvG/lN9gOihN+13y42gpvNwmlbjL4QYJjU4EjZD8oSUMA==; 5:Yz6GbLa3VWzCPxHG31cwsLu6qKxwPDcnLgaLh2fcVKwEUg5MZ+LnTEcPNP61ng3pwGYDwx8Iny23AGC8xR0t/dbFkEe33vIugrNpdvkESEQEBWYXDS0rpWefMSEUCyoDdV087Xe+fVF+NVkd7rGZ4rULHTpHwNUjoATzjXRKag8=; 7:SXdOoqFC6D6n9cpDQUqt7PLRTCm/USimb2ak161wzg4+wa8azSzZSgxDrmv7ih7YZydGVbAuRcXbDUgol6/mwmvTF+6JlF+1cbUH7yivg7nd30+wryR2VkJg+CaMDjYPQDIWYdBQvcj+UqsJDWKhN600V06lI3JdZ8at7GKXqEB1E6zDthaP/Rjatd6KIagRPXgDec8iBv5gkGRbAnBD/dRTEyoZtFtjpSKDwOmb0p2C3NOehe+FA+FS82HZvC6B x-ms-office365-filtering-correlation-id: 193b0298-c85a-4900-18fb-08d625ed5812 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB4058; x-ms-traffictypediagnostic: DB3PR0502MB4058: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231355)(944501410)(4982022)(52105095)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051); SRVR:DB3PR0502MB4058; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB4058; x-forefront-prvs: 0810818DA0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(376002)(346002)(366004)(396003)(39860400002)(136003)(199004)(189003)(51234002)(1076002)(6306002)(305945005)(71200400001)(966005)(71190400001)(5250100002)(6506007)(25786009)(386003)(97736004)(8676002)(14454004)(229853002)(316002)(99286004)(2900100001)(6246003)(6486002)(34290500001)(76176011)(478600001)(8936002)(52116002)(68736007)(54906003)(33896004)(9686003)(107886003)(86362001)(33716001)(106356001)(4326008)(6512007)(53936002)(11346002)(6636002)(105586002)(66066001)(2906002)(81156014)(81166006)(5660300001)(102836004)(3846002)(6436002)(486006)(256004)(7736002)(6862004)(14444005)(476003)(33656002)(446003)(6116002)(26005)(4006002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4058; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: jkC6ztEQPpYZ78kBrDCby9t47eaAitPgyUjBbRY1HMfKSihog2o5iqMiheJyZzfaaI2TMQeYG7QtI0NW3eXVgVLivyytu+XEIyXUchMr/dElELvWjxvaoWJDhj5hT+du5EPsu6GUEo2+xgqCTEuuHs5QXXWF1jNDv8VFm6KJCKhSqwxJe8fS9Z0YsoYOmxBO5j+MpBetxf7u0QpYssN22hcg9eY64P10rvj1eX3W38O59QXKKWqfdjeHi5LQFyj4PO6+fB1CwXUpiCPfu+jB+CPr7q6RjKBMhrgkIaRiZXLAtdoLCqybj8wKm3EzudG1yAhJ/oq9/ouD1tDAlUx6k+lCNX8cV05baA0MU+bXj7g= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <25DBFBC4002C524E9AAE9548DB8C48AC@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 193b0298-c85a-4900-18fb-08d625ed5812 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2018 09:24:24.6436 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4058 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: allow flow rule with attribute egress X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Sep 2018 09:24:27 -0000 On Thu, Sep 27, 2018 at 05:25:30PM +0300, Dekel Peled wrote: > This patch complements [1], adding to MLX5 PMD the option to set > flow rule for egress traffic. >=20 > [1] "net/mlx5: support metadata as flow rule criteria" > http://mails.dpdk.org/archives/dev/2018-September/113275.html > =09 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow.c | 54 ++++++++++++++++++++++++++++++++= ++++++ > drivers/net/mlx5/mlx5_flow.h | 6 +++++ > drivers/net/mlx5/mlx5_flow_dv.c | 24 ++++++++++------- > drivers/net/mlx5/mlx5_flow_verbs.c | 7 ++++- > 4 files changed, 80 insertions(+), 11 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 9581691..79a06df 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -644,6 +644,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * > * @param[in] action_flags > * Bit-fields that holds the actions detected until now. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -652,6 +654,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > */ > int > mlx5_flow_validate_action_flag(uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > =20 > @@ -668,6 +671,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "can't have 2 flag" > " actions in same flow"); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, These two lines could be one line. > + "flag action not supported for " > + "egress"); > return 0; > } > =20 > @@ -678,6 +687,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * Pointer to the queue action. > * @param[in] action_flags > * Bit-fields that holds the actions detected until now. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -687,6 +698,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > int > mlx5_flow_validate_action_mark(const struct rte_flow_action *action, > uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > const struct rte_flow_action_mark *mark =3D action->conf; > @@ -715,6 +727,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "can't have 2 flag actions in same" > " flow"); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, Ditto. There are a few more occurrences below. > + "mark action not supported for " > + "egress"); > return 0; > } > =20 > @@ -723,6 +741,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * > * @param[in] action_flags > * Bit-fields that holds the actions detected until now. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -731,6 +751,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > */ > int > mlx5_flow_validate_action_drop(uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > if (action_flags & MLX5_ACTION_FLAG) > @@ -747,6 +768,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "can't have 2 fate actions in" > " same flow"); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, > + "drop action not supported for " > + "egress"); > return 0; > } > =20 > @@ -759,6 +786,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * Bit-fields that holds the actions detected until now. > * @param[in] dev > * Pointer to the Ethernet device structure. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -769,6 +798,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > mlx5_flow_validate_action_queue(const struct rte_flow_action *action, > uint64_t action_flags, > struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > struct priv *priv =3D dev->data->dev_private; > @@ -790,6 +820,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > RTE_FLOW_ERROR_TYPE_ACTION_CONF, > &queue->index, > "queue is not configured"); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, > + "queue action not supported for " > + "egress"); > return 0; > } > =20 > @@ -802,6 +838,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * Bit-fields that holds the actions detected until now. > * @param[in] dev > * Pointer to the Ethernet device structure. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -812,6 +850,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > mlx5_flow_validate_action_rss(const struct rte_flow_action *action, > uint64_t action_flags, > struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > struct priv *priv =3D dev->data->dev_private; > @@ -866,6 +905,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > (error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION_CONF, > &rss->queue[i], "queue is not configured"); > } > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, > + "rss action not supported for " > + "egress"); > return 0; > } > =20 > @@ -874,6 +919,8 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > * > * @param[in] dev > * Pointer to the Ethernet device structure. > + * @param[in] attr > + * Attributes of flow that includes this action. > * @param[out] error > * Pointer to error structure. > * > @@ -882,6 +929,7 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev= *dev, int32_t priority, > */ > int > mlx5_flow_validate_action_count(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error) > { > struct priv *priv =3D dev->data->dev_private; > @@ -890,6 +938,12 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_de= v *dev, int32_t priority, > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION, NULL, > "flow counters are not supported."); > + if (attr->egress) > + return rte_flow_error_set(error, ENOTSUP, > + RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > + NULL, > + "count action not supported for " > + "egress"); > return 0; > } > =20 > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index d91ae17..a353d07 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -283,21 +283,27 @@ uint64_t mlx5_flow_hashfields_adjust(struct mlx5_fl= ow *dev_flow, int tunnel, > uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t prio= rity, > uint32_t subpriority); > int mlx5_flow_validate_action_count(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_action_drop(uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_action_flag(uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_action_mark(const struct rte_flow_action *action, > uint64_t action_flags, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_action_queue(const struct rte_flow_action *action= , > uint64_t action_flags, > struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_action_rss(const struct rte_flow_action *action, > uint64_t action_flags, > struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > struct rte_flow_error *error); > int mlx5_flow_validate_attributes(struct rte_eth_dev *dev, > const struct rte_flow_attr *attributes, > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow= _dv.c > index 2439f5e..1f3fcb8 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -117,21 +117,17 @@ > RTE_FLOW_ERROR_TYPE_ATTR_PRIORITY, > NULL, > "priority out of range"); > - if (attributes->egress) > - return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, > - NULL, > - "egress is not supported"); > if (attributes->transfer) > return rte_flow_error_set(error, ENOTSUP, > RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER, > NULL, > "transfer is not supported"); > - if (!attributes->ingress) > + if (!(attributes->egress ^ attributes->ingress)) > return rte_flow_error_set(error, ENOTSUP, > - RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, > + RTE_FLOW_ERROR_TYPE_ATTR, > NULL, > - "ingress attribute is mandatory"); > + "must specify exactly one of " > + "ingress or egress"); > return 0; > } > =20 > @@ -288,6 +284,7 @@ > break; > case RTE_FLOW_ACTION_TYPE_FLAG: > ret =3D mlx5_flow_validate_action_flag(action_flags, > + attr, > error); Merge into one line as much as you can. Same comment for the rest. > if (ret < 0) > return ret; > @@ -297,6 +294,7 @@ > case RTE_FLOW_ACTION_TYPE_MARK: > ret =3D mlx5_flow_validate_action_mark(actions, > action_flags, > + attr, > error); > if (ret < 0) > return ret; > @@ -305,6 +303,7 @@ > break; > case RTE_FLOW_ACTION_TYPE_DROP: > ret =3D mlx5_flow_validate_action_drop(action_flags, > + attr, > error); > if (ret < 0) > return ret; > @@ -314,6 +313,7 @@ > case RTE_FLOW_ACTION_TYPE_QUEUE: > ret =3D mlx5_flow_validate_action_queue(actions, > action_flags, dev, > + attr, > error); > if (ret < 0) > return ret; > @@ -323,6 +323,7 @@ > case RTE_FLOW_ACTION_TYPE_RSS: > ret =3D mlx5_flow_validate_action_rss(actions, > action_flags, dev, > + attr, > error); > if (ret < 0) > return ret; > @@ -330,7 +331,7 @@ > ++actions_n; > break; > case RTE_FLOW_ACTION_TYPE_COUNT: > - ret =3D mlx5_flow_validate_action_count(dev, error); > + ret =3D mlx5_flow_validate_action_count(dev, attr, error); > if (ret < 0) > return ret; > action_flags |=3D MLX5_ACTION_COUNT; > @@ -1080,6 +1081,7 @@ > queue =3D action->conf; > flow->rss.queue_num =3D 1; > (*flow->queue)[0] =3D queue->index; > + flow->actions |=3D MLX5_ACTION_QUEUE; > break; > case RTE_FLOW_ACTION_TYPE_RSS: > rss =3D action->conf; > @@ -1091,6 +1093,7 @@ > flow->rss.types =3D rss->types; > flow->rss.level =3D rss->level; > /* Added to array only in apply since we need the QP */ > + flow->actions |=3D MLX5_ACTION_RSS; Let's do the same for the rest of actions. > break; > default: > break; > @@ -1301,7 +1304,8 @@ > dv->actions[n].type =3D MLX5DV_FLOW_ACTION_DEST_IBV_QP; > dv->actions[n].qp =3D dv->hrxq->qp; > n++; > - } else { > + } else if (flow->actions & > + (MLX5_ACTION_QUEUE | MLX5_ACTION_RSS)) { The previous code is not wrong but definitely error-prone. Can you please m= ake the same change for the verbs code? You can create a separate patch for thi= s fix. > struct mlx5_hrxq *hrxq; > hrxq =3D mlx5_hrxq_get(dev, flow->key, > MLX5_RSS_HASH_KEY_LEN, > diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_f= low_verbs.c > index 05ab5fd..b1aa704 100644 > --- a/drivers/net/mlx5/mlx5_flow_verbs.c > +++ b/drivers/net/mlx5/mlx5_flow_verbs.c > @@ -1112,6 +1112,7 @@ > break; > case RTE_FLOW_ACTION_TYPE_FLAG: > ret =3D mlx5_flow_validate_action_flag(action_flags, > + attr, > error); > if (ret < 0) > return ret; > @@ -1120,6 +1121,7 @@ > case RTE_FLOW_ACTION_TYPE_MARK: > ret =3D mlx5_flow_validate_action_mark(actions, > action_flags, > + attr, > error); > if (ret < 0) > return ret; > @@ -1127,6 +1129,7 @@ > break; > case RTE_FLOW_ACTION_TYPE_DROP: > ret =3D mlx5_flow_validate_action_drop(action_flags, > + attr, > error); > if (ret < 0) > return ret; > @@ -1135,6 +1138,7 @@ > case RTE_FLOW_ACTION_TYPE_QUEUE: > ret =3D mlx5_flow_validate_action_queue(actions, > action_flags, dev, > + attr, > error); > if (ret < 0) > return ret; > @@ -1143,13 +1147,14 @@ > case RTE_FLOW_ACTION_TYPE_RSS: > ret =3D mlx5_flow_validate_action_rss(actions, > action_flags, dev, > + attr, > error); > if (ret < 0) > return ret; > action_flags |=3D MLX5_ACTION_RSS; > break; > case RTE_FLOW_ACTION_TYPE_COUNT: > - ret =3D mlx5_flow_validate_action_count(dev, error); > + ret =3D mlx5_flow_validate_action_count(dev, attr, error); > if (ret < 0) > return ret; > action_flags |=3D MLX5_ACTION_COUNT; > --=20 > 1.8.3.1 >=20