From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0FDAE239 for ; Mon, 1 Oct 2018 11:36:25 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 02:36:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="93546634" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga004.fm.intel.com with SMTP; 01 Oct 2018 02:36:22 -0700 Received: by (sSMTP sendmail emulation); Mon, 01 Oct 2018 10:36:19 +0100 Date: Mon, 1 Oct 2018 10:36:19 +0100 From: Bruce Richardson To: Luca Boccassi Cc: Hari Kumar Vemula , dev@dpdk.org, reshma.pattan@intel.com, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com Message-ID: <20181001093618.GD25944@bricha3-MOBL.ger.corp.intel.com> References: <1538222461-25597-1-git-send-email-hari.kumarx.vemula@intel.com> <1538301698.6143.1.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1538301698.6143.1.camel@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH 0/4] enable meson support for aesni_gcm, aesni_mb, kasumi and zuc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 09:36:26 -0000 On Sun, Sep 30, 2018 at 11:01:38AM +0100, Luca Boccassi wrote: > On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote: > > 1/4: enablement of aesni_gcm pmd in meson 2/4: enablement of aesni_mb > > pmd in meson 3/4: enablement of kasumi pmd enable in meson 4/4: > > enablement of zuc pmd enable in meson > > > > Hari Kumar Vemula (4):   driver/crypto: enable meson support for the > > aesni gcm   drivers/crypto: enable meson support for the aesni mb   > > drivers/crypto: enable meson support for the kasumi   drivers/crypto: > > enable meson support for the zuc > > > >  drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++ > >  drivers/crypto/aesni_mb/meson.build  | 16 ++++++++++++++++ > >  drivers/crypto/kasumi/meson.build    | 18 ++++++++++++++++++ > >  drivers/crypto/meson.build           |  4 ++-- > >  drivers/crypto/zuc/meson.build       | 18 ++++++++++++++++++ > >  meson_options.txt                    |  6 ++++++  6 files changed, 77 > > insertions(+), 2 deletions(-)  create mode 100644 > > drivers/crypto/aesni_gcm/meson.build  create mode 100644 > > drivers/crypto/aesni_mb/meson.build  create mode 100644 > > drivers/crypto/kasumi/meson.build  create mode 100644 > > drivers/crypto/zuc/meson.build > > Hi, > > With Meson we want to reduce the large number of build-time options. For > dependencies, I don't think it's necessary to have a separate option to > pass the library path. > > The preferred option would be for the dependency to have a pkg-config > file which sets the necessary flags. If that's not installed in the > standard path, the PKG_CONFIG_PATH environment variable can be set to add > custom paths. > > If a dependency does not have a pkg-config file (if you control it would > be a good time to add it :-) ), then you can set the path to the shared > object with something like: LD_FLAGS=-L/path/to/lib/ and Meson will use > that automatically (and CFLAGS=-I/path/to/headers/ if necessary as well). > For completeness: third option is to have the libraries on which you depend install themselves in /usr/local as normal for additional software, which means that they should still be found in most cases without either pkg-config files or extra LD/CFLAGS. /Bruce