From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 269AC5323 for ; Mon, 1 Oct 2018 12:42:13 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7459F3001252; Mon, 1 Oct 2018 10:42:12 +0000 (UTC) Received: from localhost (dhcp189-71.ntdv.lab.eng.bos.redhat.com [10.19.189.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10AB21001F41; Mon, 1 Oct 2018 10:42:10 +0000 (UTC) Date: Mon, 1 Oct 2018 12:42:09 +0200 From: Timothy Redaelli To: Luca Boccassi Cc: Bruce Richardson , dev@dpdk.org, mvarlese@suse.de, christian.ehrhardt@canonical.com Message-ID: <20181001124209.7ea2f69b@redhat.com> In-Reply-To: <1538387162.8363.41.camel@debian.org> References: <20180928175803.12955-1-bluca@debian.org> <20181001091714.GA25944@bricha3-MOBL.ger.corp.intel.com> <20181001092530.GB25944@bricha3-MOBL.ger.corp.intel.com> <1538387162.8363.41.camel@debian.org> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 01 Oct 2018 10:42:12 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] build: add drivers_install_subdir meson option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 10:42:13 -0000 On Mon, 01 Oct 2018 10:46:02 +0100 Luca Boccassi wrote: > On Mon, 2018-10-01 at 10:25 +0100, Bruce Richardson wrote: > > On Mon, Oct 01, 2018 at 10:17:14AM +0100, Bruce Richardson wrote: > > > On Fri, Sep 28, 2018 at 06:58:03PM +0100, Luca Boccassi wrote: > > > > Allow users and packagers to override the default dpdk/drivers > > > > subdirectory where the PMDs get installed under $lib. > > > > > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > > > I'm ok with this change, but what is the current location used by > > > distro's > > > right now? I mistakenly never checked what was done before I used > > > dpdk/drivers as a default value, and I'd like the default to match > > > the > > > common option if possible. > > > > > > /Bruce > > > > > > > Replying to my own question, I've just checked on CentOS and Debian, > > and it > > appears both are using directory "dpdk-pmds" as the subdir name. > > Therefore, > > let's just make that the default. [Does it need to be configurable in > > that > > case?] > > > > /Bruce > > If the default is the one I expect then I'm fine without having an > option (actually happier - less things to configure). > > But in Debian/Ubuntu it's dpdk-MAJORVER-drivers since last January :-) > We changed because using a single directory creates problems when > multiple different ABI versions are installed, due to the EAL autoload > from that directory. So we need a different subdirectory per ABI > revision. > > We were actually talking with Timothy a while ago to make this > consistent across our distros, and perhaps Marco can chip in as well. > > Timothy, Marco, is using dpdk-MAJORVER-$something ok for you? I'm not > too fussy on $something, it can be drivers or pmds or something else. > LGTM. If needed, we can just do a compatibility symlink using the current dpdk-pmds path