From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0076.outbound.protection.outlook.com [104.47.34.76]) by dpdk.org (Postfix) with ESMTP id 82DB52BFA; Tue, 2 Oct 2018 12:52:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iwUalpRyEqy4g/LB0iUsNz1wfoKiUtvZoRfTS9mwOsE=; b=mumWOchLM/ogJKhEEJdIG3YnXVD7obGm0DPz1pGAY0fR6EvRkBGX0vvTuN6Bh/Em/Bf1TsD9C2cdLG4iU8lH0L0eL6kd+wqhJ/JYzgj0fkg0LCqmttc8XYDPOV3kwgNBdBS4fbkLcTPdTACtxY3052zK8DsnAFvLaPSubjsk9W4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from localhost.localdomain (115.113.156.3) by DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Tue, 2 Oct 2018 10:52:33 +0000 From: Jerin Jacob To: Olivier Matz Cc: dev@dpdk.org, Jerin Jacob , stable@dpdk.org, jiayu.hu@intel.com Date: Tue, 2 Oct 2018 16:21:42 +0530 Message-Id: <20181002105142.24333-2-jerin.jacob@caviumnetworks.com> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002105142.24333-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0030.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::16) To DM6PR07MB5002.namprd07.prod.outlook.com (2603:10b6:5:25::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cd32531b-c3f9-47ef-7fa8-08d6285529cd X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR07MB5002; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 3:zdMOcZTQl8Yt4xPLxITlG2e3JCi3UlVhGp6QaXwrix3h5V8J0S42kOhRKjPJq/Kr5n+HHWYwHStcbUHfwwrkubgTijT+HqECN8MQVDzMIynamwF2gA0ej2BV02Ql9T/tQqWLsbeRn0xzoNb2HE0TJd+UNS/UhVwBPIGhRtrlaP9zMkpRF0MEP8qDJ7de9/hf9OclNXwVv049q/jyQuOisCnm+P6UHXWs+LB2Cpn8BDGdlJWam3e7l/sfNW+dkUpN; 25:/jaxT0mfrtUQGl/Oe3UR8lbxhBg+MhrTKoPjYEL5KRyJor2airFtdgvTrbnAKikoii9s3rpwARUQ3QHrkf8V/WxOeD7fpk3iwLf6ePLOoA4FvSIug/F4smJVrU+Yr/35sMQMrZeZj3bcJrovCAEcsSgrZ4gq88gGJeR1AxyviZr9Zd9dihVPohURZHvaV/YwZk5XGIfwSbrWdH2Gh0ZrrNu4v2753MUJC5CEoEFMbqxbONaEbuOL797FbvMAjOQsrDpK+XaMAVYqzMZXBEOWF2L2UWKZIe8neNKXUKA66xJdshx+85IPEjq0v9TgQHwLjbHVlBHbhmRxtW83a7i1nQ==; 31:uW3VpKGk/Z1Fl318eLcHy/8JSnCE4nnr5mj7K4us65MVKTyGxuUZ36BwMWUQq5h2IDArQbP84TXB7CL893ANLTxjGQJBIh/iQCZm6ZLn+RZnBC/5ObyVbGFNPfq95zbCP52VPImbpuCh6qZFo5ILH50yxDX8G1cX35G+pUhy4Ws7+nuZntQP3cNg6wZjYKPoBatXRLS5kBLD4UMTIMC4muGU7lcmtUTvg5PB9Jj1swM= X-MS-TrafficTypeDiagnostic: DM6PR07MB5002: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 20:GPqNBiD8FbShpJu1mna/bdGwV20ewoWpghtGRnDzBGNV5HQonbaLACuAw9gNNDMd30vNHn7Qbxvizm77sG5/UfOUKGPS5SLZfeB4YN+ycntKqQrQOy8RwHZkn+kIX+9SYPCXvmXEXJ8CSIGmdi1oSUxbOfAjv+mNH1cqegXdcQ2w7xF6yAeDmJ5WfCdXMYhrJvpPI+sEt+t8HOrFk+RKfmPLgNJXdGuFTjIjFaCMlXuCDLIE6fSaktCXDY5tbOJc26znC5HX1IAU/kQJGMg3G8g+icAcYn5dzfVHw30nfK1uc4o/31rxFuahh9+4pzDki1tqxx8DOUa7oKMfdhp7CmPxxL7dQ+luVIyYoQ4osq/yk62Y8P99c/zzM5N3To79QczC2+oAn2vtMK9XAwXo9/8p1yedMr0OPyrHdmdfcRtelOB5eCv8eSPZD1K/LgeBLHLaNVEF0G1CJ2HkvD5oP43fIUWdIZySpf8Bx1KaG2pUhsQhKf039agL7tQFWMvO8RtGONUtHpLCd3hPUuYBxDmzDX4/SCC04c7p34XOhhL7DWcGaBdadMWDDsgpQgfbSUynDMmQ/ZvexhazPX2mzTb0tLrwUliJWsxvOO5ItZg=; 4:k7KbDyjTeM6trrV/ghePhdhpnIiCWIj1Vvvj6XST1rQ6FmSqXYF0amiZ80yxfbGu0MmkQ4uXulHzfnJet9oyNr8zr5I0AuATtVJKVoXQ58nDXOCX4VtCLZzZvRW6HLIZpxl105D/FXrvvIfTfQfuy4if+zA1TfuQG8/EUyEcO+efvqLd14o7uosbvsk9xHZtNqe1ZkPbisGHhFkUzZ3PJzoa8LKUGbpekVqMtNqrA0z7Qp8K75Dhe/M10NgzyJp8kXYEaBFK77+U597H/5bBzFRaTbi+fifR5qt4Gfuiz+okWzXAOR/cv++K0N0pmi1m X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(10201501046)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DM6PR07MB5002; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB5002; X-Forefront-PRVS: 0813C68E65 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(396003)(376002)(136003)(39860400002)(366004)(346002)(199004)(189003)(6486002)(5024004)(5660300001)(97736004)(26005)(106356001)(6916009)(7736002)(186003)(36756003)(305945005)(25786009)(1857600001)(6666003)(446003)(42882007)(956004)(47776003)(3846002)(6116002)(1076002)(16526019)(11346002)(2870700001)(476003)(2616005)(105586002)(66066001)(72206003)(4326008)(2906002)(53936002)(44832011)(478600001)(51416003)(50466002)(52116002)(81166006)(6512007)(55236004)(81156014)(486006)(8676002)(50226002)(76176011)(316002)(14444005)(69590400006)(6506007)(386003)(68736007)(8936002)(48376002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB5002; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM6PR07MB5002; 23:DKiI8CLVJ3e23nstEw5a9BMZ4lmsRM4f/i+c3+Z6U?= =?us-ascii?Q?q//NH9yhJpk5mwedqwM4fAaj4nitOWntkHt4VqpPdRo/Q0lsuxax96tOGmY0?= =?us-ascii?Q?M9mXyicJNQocpz9tRKPG9yasassxW2RM0GTP2rUIThkiDutqr5zdF1a3VwKt?= =?us-ascii?Q?qvuXsBBCo4kI1h0p3Ejqc30gB/KGY/zBO3kHcd/qhjLh130eKrPRMmuLHUeP?= =?us-ascii?Q?PZb0esJQmN3jNdHEv2ulE1SQ9OlwmjNkfRLgu7QDRxVHQaQ0dzYwfkV/A3LN?= =?us-ascii?Q?GR3OuWu6zeqiQV+hyZTaAkDSGr1cWIr+9Q6bvw7SSewJmmOLaqQi18DeSaeo?= =?us-ascii?Q?g6GWK4NBsflqEW10gp36dijlblSLs+kKRPK33pHOFJqB6ZMLERWNGC+MuTrb?= =?us-ascii?Q?uIqAPqA7/MwdNQCnreKtZJ6/4tmyIqQ2Uth28jNV1rbaaRb52i0M7NU94uSP?= =?us-ascii?Q?K0J3VJ7shaXTwH8bJamQIMOZtvQku6oqgdZOXpOj2nd9dhkD6WbLJy/5Nljy?= =?us-ascii?Q?6qged2lAJWIq6y4ZDKvEHsJzu+A/FjyK+00X376c8lGREeRIBSVIh6im25Q3?= =?us-ascii?Q?IpAQGrA2jx2wTYiXsk6rhodbldkSBPNahgaVodaPg6/GeIkhvj3JcePElhoL?= =?us-ascii?Q?boFox78LbFWFW6jesLQkCVl22gvc12+9BR8hzwp0wsoX6M5Mv1GxVmW0yh48?= =?us-ascii?Q?kWfB+dRWFDqOP8bkueqmV+sLHzVwuAblZcW/LvbQ1vPKXr4PMpk0kXv5uP/V?= =?us-ascii?Q?81tD3x5u3WrpBfKPRKK6KK2mZMFLKxemKjZGHvdYjYTXl8d6WA0VGpRBGZUe?= =?us-ascii?Q?gmMaq6WNbyTRMdDhCTY5fnzeKE5Q6seUMNlxLS98zLBnrRIHzh/WVX9exVxn?= =?us-ascii?Q?oOWErDQ50g/64MG8WMsnQD8r7yrOFMM5OszO6Yp2bzG7341Ee8dkrA9UPeUy?= =?us-ascii?Q?X2DKimD502azVRByBc8Op2Ei2ifP4AYGzXgi6uDPP24LVFZusQL1akroaw2M?= =?us-ascii?Q?oa6kC1CplHorTdbb/T0PstzoNu9Uzz16jmAVljgE58Tt2eQF9NKC4POCC4t0?= =?us-ascii?Q?ubbZvmgc8u2tPol+mc/ODjKt12APx0M1TeVOOzIobcr+5RJJLyAoM++rTRmm?= =?us-ascii?Q?gDrgz43hZmH3+1JniGAur0Gixz/Jms60P5F+Ni1uSH4JxVfGE8LT5xsIY/1H?= =?us-ascii?Q?B+xndjOb1cfEEF7Q2M/Y8CVxYtFgZ2iB48qnEH3qk/Vm/UT+hjBTXxI5Pra7?= =?us-ascii?Q?nbHlWn9bgZkTyQBOD7m/EqssVtiF1I3Oc37q7DtiuAZgbkLLqtZ2AY5kbimx?= =?us-ascii?Q?MpkSyE3duvKfZ/HMm12QgFewEL6rlxozazVKKosQwNk0VzdGnly5RHDotFyG?= =?us-ascii?Q?20tNt0/tCQ1icmuLQN1WCCOarw=3D?= X-Microsoft-Antispam-Message-Info: WtetyrhRzCbaOZddDZyW9fFZ1RAfNZHIg3kqpwxTusmkh8xdU3aOzuBf75Ln0rtnlOfdewnq8kYoeTUO1GWpYyR48T1iUZqIP+aC1MMkuuwntfvfNETbwkO1ZAp7tWSoRqxDfi+5jCrezvUKdwYH6i0C4c1E7+e89yP3Olr9g1s7m4FFkVc1cDv7FEkpwcg4CbioyRiL3m1uBnofUlECs61jXvxv3wi/nVLT6X0k/u/fe4Li+pepfKu2shxoiddhq8+yDx7/Xp9eHjnI4UvxY4EOFwz0epkQ9DUPyYXffU04oQMH507aTiD/8AEW+hpaW6saexI+SXiCVEVzuli9nL/5warxLISr8NGSA/gTXLo= X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB5002; 6:q62g+n8AC5MEjNVboQ2Xkp+Au5Cfly/Cf6J0gL9dG2THNPZ7kj+OWqogET2Lv38u16WcR9M49QNGwGLMm3M+iU8k+WZo8jB8yfeISVsia2ZraojzAkbwcWc4JQtCqJn60JTrlXbKpQcEo9j2v6el+0Q/+LxWlnHDxpS5P3Zgomjg4qV5k9KDqpTyrhpCnwN6By0Rs7rGvdN8AiUM3teXMdtAOuQNlWgy33brUbpbearJ4fXdRvlRkUdMnC+I0pRt70gghOzbne0dHxYNGj2KRlawwcP+13gNVBwxTZ86rWdlbLGjyOa8+ylO4sGzCJAtEtCoaBOFAR9mzOknKWAp2Xr8Vxq+irwR83uEZZyXXCuF0Zsw9vSuJdnssah0KDJfoD4ZM78OlIm360pbpYUaRH+1NMxs4bbfUOXN36r4JR420NoZHZP0CuYt/GVRDs6SNjsWIcrUxHre3xZLe7TxGw==; 5:sTiMeh6jHKLCJR58KDIFF4oSPhw3t3XEkjfIv2dgtIs/tTEJ1J9FZ1YO2otOU/Oe6ESh9L8kGbGy/Vwoc1eM0rHp4tVgmVgPPiJpwkvbWfqPzPeRX3GFfzM/cLzs/7WbNeS/N91nMH4Xu7RhVaCjNbAVA2AuJjmX68+Zpy/q0dI=; 7:x03NbyS6aOGSjpzzHw2YMRpift75T9iHyoha2PZxhV8forOrDa4lOP7MTsIXE3go4UqDStcXon52ZvoOdh7DwKRN0dIHpyKQTZ7I8MADqS999vBN5t9qhdLtRiwwTy5Poda/S+MZpNOwIEMnA05bBv3doAEVYgiVBHcCi4iKkYkMKnOB8X51boE6Z33A84F+PKlzscWKNBqSbbjMTxwBMg+1IqA19LdG7so6bRW2kiN9stfUlfv+C0SnEhL97ymc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2018 10:52:33.5355 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd32531b-c3f9-47ef-7fa8-08d6285529cd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB5002 Subject: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 10:52:38 -0000 Fixes missing PKT_TX_UDP_SEG, PKT_TX_OUTER_IPV6,PKT_TX_OUTER_IPV4, PKT_TX_IPV6 and PKT_TX_IPV4 values in PKT_TX_OFFLOAD_MASK. Also sort them in bit wise order to recognize missing items later. Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels") Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones") Cc: stable@dpdk.org Cc: jiayu.hu@intel.com Signed-off-by: Jerin Jacob --- v2: - Add all missing PKT_TX_ types - Sort them in bit mask order(Ferruh Yigit) --- lib/librte_mbuf/rte_mbuf.h | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index a50b05c64..c8ebc3230 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -334,16 +334,21 @@ extern "C" { * which can be set for packet. */ #define PKT_TX_OFFLOAD_MASK ( \ + PKT_TX_OUTER_IPV6 | \ + PKT_TX_OUTER_IPV4 | \ + PKT_TX_OUTER_IP_CKSUM | \ + PKT_TX_VLAN_PKT | \ + PKT_TX_IPV6 | \ + PKT_TX_IPV4 | \ PKT_TX_IP_CKSUM | \ PKT_TX_L4_MASK | \ - PKT_TX_OUTER_IP_CKSUM | \ - PKT_TX_TCP_SEG | \ PKT_TX_IEEE1588_TMST | \ + PKT_TX_TCP_SEG | \ PKT_TX_QINQ_PKT | \ - PKT_TX_VLAN_PKT | \ PKT_TX_TUNNEL_MASK | \ PKT_TX_MACSEC | \ - PKT_TX_SEC_OFFLOAD) + PKT_TX_SEC_OFFLOAD | \ + PKT_TX_UDP_SEG) /** * Mbuf having an external buffer attached. shinfo in mbuf must be filled. -- 2.19.0