From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0084.outbound.protection.outlook.com [104.47.41.84]) by dpdk.org (Postfix) with ESMTP id 9DC4C3195 for ; Wed, 3 Oct 2018 09:58:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7PEDFiZ9iD5f3C0OTvzp1YOUwbwqcftQZ8zEP1rXbHc=; b=RlVF4VeVfA+A3tymLR3C4H7wbxO2nZyRyC1pnwWiSAfqUAJh8pdNKyWyjbKEL1ceb1Y26xS+FR9Hkk6ajGpOUUzX/X0WEw6wyDqMmIj+LQO94EcaRvhM3avjLKW3oZ0DTjDXW/tlagpsW1ux2yIQ8F9pCguAqIpVnwcQRspOCmk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Wed, 3 Oct 2018 07:58:45 +0000 Date: Wed, 3 Oct 2018 13:28:24 +0530 From: Jerin Jacob To: Andrew Rybchenko Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit , Olivier Matz , dev@dpdk.org, shahafs@mellanox.com Message-ID: <20181003075823.GB2003@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-2-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR0101CA0010.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::20) To BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8533331a-cc99-47bc-4fb6-08d629060d7a X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4999; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 3:PqIP5jTbaJZI3xYlE6+FMeq6nIRqd+q/5sMUFmMkZHNrqAaJYcUaLDAv3CXCYKnLgH6uai3JyhIM8Uh2W9wAazDbyT+22kZbA1Abj/ReixaNvZzC/WNlgo0+rLK+wPS+z/RvaN3sRkMcW96pfgFfCq6p5xNRiNKFoLwpd37yKzSbZhKD78InLuGHDMAQ2gInFNTQA635kE4A5cphP+GzPsrBiTz274E9IkiYhPrYS6QMqF8Uea9NkV8oPqwvZsk8; 25:KpFUgaTQkB+IGXPMhOPM8Vm5cL4MqaPowPCOGXuoALX2ce+39ppZZfRZdFzRJN4ouw1DJUW90Uk1iD3CND97mUstSNQUwEI0Nu1t1rCaVtZCQH1jC107bWYgA879FNsYW3hyLoRk9B9NkZknN152lHYosyq80xVScRuNTh9Qs+eHGB+U7xDDukhuwY7OHvLN8tAeR1bKM09NHtY/TZUORr2h+FqDu9Y0LOcwyyMHtrybfInNr2eXeGspFnbVs2cC/Kx2E5rCSnqa7S4jS8W6kvYFJh1b3IGvjsDnHwxft3zLAyMoikrjfMnmkJBnEVPecFKM1CJRky0TTapSoIsrhQ==; 31:xgKBMTzKYiAAE4X0UKVCZfi+I9dpQLZ682NuCiBc3eOXw57m2fLOb8drM4jqxQp17aoIxXrcHnxI72VzpExxu4uS7WgISFjGrICkSyQ0GINoZxz/Au4g6Lb/KwhGMbHdaqo/1yXkkDtVkoAEQ6lsPULhDwmhGoYAxggJRPSvgPBOvF5fcuTydxpnPztN2mbakAbcN8Y3cBn9+lhHogXkT5F7Lfw5pALEh04B5EVOeKk= X-MS-TrafficTypeDiagnostic: BYAPR07MB4999: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 20:eAs0D4Mc+XbrMou8DoQddmGaFIL5AHbFF86tHP3m1qqH/fc6eNDoqQLc5J43k6k1NA7Rf8ubHPfzrOK/aZVFaincr4s2xJR1vxLUEufoZNK3+2n7INPJ/sCuA2+bcD+ib2Kn9fSryfjHMzJS6dLuO83fwM69HWC6D8Uu4QZ5EJZ2/WBWljovbhEY6OlBZCM3gi1wD7wc7Uq0qoDzCk6OS1OqyDFENMBFX2akOJXu35HgeEfkhOUOu4cwwhe8e9t+7xbCpIlzi12V7WX1tNNfGuFPfUSYxNvkpH+LXgFdRoqNcLtzvlc2E4GfH8wux8VK9ewC7MPmXWoLeLcmyH2BGKWFA+5ECGVO8q4U1t0EALQjCBWZHU5OW4AlHxJGEO7ovt0acBmMRq80T4XZxAIAhec4r8RrYHj81i29uDAX7KypV69otKk8zVQnoKKmmSnDWgom0tv/CQda31XndlrkH4/Ozd9edfrYGxZTeG/OC6Gt4paoVB0x8gMT8MxIjanX04InZ6ZRGmL3lL7yj0XJDielVfBdhYpLaxPz7iIB5X6B/ZOSdDojao25vK+7Y+htkqBHtH2SEi4P9XvZVfi3xBp+vI1zyUhbYr/t9fXm0/8=; 4:i+2pnDQZCYHgv42b5iTg4pPM8Kj8+RZqLVnFmeBMY+koBYP29RGcN8fP+YUGBHtwj0jJIwERM9tbYFrAzDr0H9krWuPNzx9Izdl6EedK4cVFLme/qew7SrQZUlwXPDSDztvMIXOlppL82MYspw7BnBTHAN4vqbruYOUBtD7ZAfbjt7XtBllN/dUxE39jIM4IxkbR9O2E0La+vIRBbCK/qBrYWu90iaA0tYemu9FPXwqvp6KbMS1Hc8j/YL6nJRE4+3WjI50Zp3HjVEep3OB7l4fjwb+NOR6uo/b9K4GXJwj7wcFOL+2YFnCs1mjbhQ/5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:BYAPR07MB4999; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4999; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(39860400002)(396003)(13464003)(189003)(199004)(33896004)(6246003)(4326008)(305945005)(93886005)(23726003)(1076002)(25786009)(33656002)(68736007)(3846002)(81156014)(8676002)(50466002)(316002)(5009440100003)(6116002)(8936002)(106356001)(66066001)(81166006)(6666003)(105586002)(47776003)(16586007)(486006)(26005)(72206003)(7736002)(446003)(478600001)(186003)(476003)(16526019)(6496006)(956004)(11346002)(386003)(53546011)(97736004)(76176011)(229853002)(2906002)(52116002)(9686003)(33716001)(44832011)(55016002)(42882007)(6916009)(58126008)(5660300001)(54906003)(53936002)(7416002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4999; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4999; 23:VM/n6xP4MaLd0FX2NtlqGQUeuP5Cg+HHv1a4xm/lf?= =?us-ascii?Q?Bl902sJADKI1NC5jz2RQBPhUSFBDf5aqUK5KLeYyMR9YiMTlJbk9J6Tf1Bfc?= =?us-ascii?Q?1G88HpneI0JMZZxcZjaF92U9cfsxfqJhSPYqGBsC5Hyv/NGi4DR7wxFJugsD?= =?us-ascii?Q?cYxDL2q+flqya9DYMhdsZXyhaKKMEMbb+HYoKLbNim+MMQnGkwBCRmuRHdvJ?= =?us-ascii?Q?4UsRzV7s93doR42j4JfxR8Oq6bl+NJAjuZV9mxXc0xVN7PxMyKxR/D2/i6T5?= =?us-ascii?Q?w2pI2N7qOT9JL0GEnWz/SQFm2k1I0Dxt4A0csS06iRmU7hqcX6QQ2RO3OhRB?= =?us-ascii?Q?b8QTEZNq7R7jnCoN5fr+bYknXmzgcrv4yb9gBGLWscZp0VslbpAho6VJKnjN?= =?us-ascii?Q?wMx16gJOgNxZMCMhcORZaWFEwm1G3q2Zu9zt48GfYcAaM4wEuM5r85C/Auin?= =?us-ascii?Q?gRgBO4yxV3s3HIO49mJ555X9YjpnGWO9rvM6NyFM73m6CC/FENMOcix8tTEU?= =?us-ascii?Q?/JyJN5RHulPcCXLSa7VvU74DXYuvKasvZG7sdQW1FiX/+tTDZ7uQYqC5LfK6?= =?us-ascii?Q?aY2t7DVZX1PWjGVQeYmTMwAAoKE2XpAhRgWt06qGds0EvnSPs0TvnsDrac+C?= =?us-ascii?Q?TLVxSW63/PIw6QKY+34IwK/9dEiUJQgMQ/CNYa4GDHcwFkelQXiuBjxm9akY?= =?us-ascii?Q?8Nup7o/JuewFFclMNPjiuTvwCC7jW64ZW9e8wPA4feYMGhvrEClcvN7Vjw10?= =?us-ascii?Q?XBxFRj5GZfutCcV7eTzvehFNl3oho6eTAKWM0gZv1LS0f3E0ow7u0Qj6i3sb?= =?us-ascii?Q?BW/O3MaRfnTN/JOa6MlygpiscHB2oXpgdw0nnPmFN8xFe2r4ovM3p6Am++yg?= =?us-ascii?Q?qydIIHSup6BLFJB1zQG6p2HG2ONS3WX10h9xYEvu8SGFmfg7WSthmLcIveTF?= =?us-ascii?Q?nU9+ERjgPoaXz2TrIk+UBq5LlJ0UxLjUdaMyBQm0/uVD0iudzMjwqa8m2FaH?= =?us-ascii?Q?KnBW8PMCTschpDlyM4sVk1QSXD3/zFzXzXpBb+SzkkNDPVoZ9ur3/pRSRLuz?= =?us-ascii?Q?gRlWNRpj7d7qZgpIKOKOdY3jmJ7FwNefDkQpz+jYHFUoZMqby2Wu4mRt1A3x?= =?us-ascii?Q?61PLYROyeZNaTnqVMGdc8h5R0724HqFLHq38JbltvL9uZL6gWSc+zMwufhJi?= =?us-ascii?Q?uwAaLe2/lq4TbU/TghWPQnYhHmdIwy8jZ9orQnfyZcD0n6fjTbhc3+BEYAp1?= =?us-ascii?Q?jQC0Nz4eWa3q48pqO3lt+MGFPfoqF19QIQ8rK/qD5ZkpdQ6F6Muyn9puL1Qd?= =?us-ascii?Q?CNtHHXwu6/R/HbzVVREdbDIq008yAiSmXeZoVChzzENGNS+PnS3Kw5W12j99?= =?us-ascii?Q?4v9lKsDTL7d+Dct5U1q9OBnzTn/x9+gnYE+0YVD8jMSEa1HbOh7eq8NnTC5X?= =?us-ascii?Q?e4EY+la56iOJ2fEjZmCAqzivBkCpxA=3D?= X-Microsoft-Antispam-Message-Info: MItCAT2zKbVCxsjmHZ+7G4/JBgkUQyOlfEgc7bQ61EbcHxLgyfhWfq5UZ+jmIf53SX/VxNus57Cvj5E87HtLfjwdDwNHdNrVpuLUtzBwq+AT71Q5IXWbT7AuDFZjCVe14Tcwx4Hn+xfJB5AWBQ1lHR8AhTFzCdLbSjTXcF2eRj/AYHqKaWxWKMoY5I92qZMEfk5l8UI5lXAiFY8sLEeWCrKiBHcbwWpbJ8G061J1P3zwu6OHK4Vk0bnk6rzrLsmcVgP8APXYuTCJpEFyUrYVQfbeQzPozlX8V0BRqBezaAx/kuk1hvV5YQwIA7ez87fAawUHrCVHI4IjVxF+X0sFs1tTZZR/kVaACG8JvyRQj1c= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 6:ZZrwI92Y0VOU+WKh1sMwgGr20u5P3APy7bXd808VRMBO6etlkeUvNQRzQb/2eDter/zqZZ24bvnBFpzWPSu8SCUWVbXvl65se46IQzVAlzZXXh3uMmTxUdwgJ3pY4duTMwrGQbPVq5+WhYAbczNjU1IMBB5svovGx1pfKw24ULEUAayYLmRk5QyNeFCxz7X7LYusZSt7LDVIwlhHB7rvu65pWikdNLnzJq0k8h4vO3IMjz2eRJHxvL2dcby/RjZCcyVlkyHymPYTgK6u7ReQgpZRwNkwT01C27EoqcPA9m8lO/sfFqZn4QU7QBv/9wuHl94D+EcI9T4WAeR0DlOXhIzOCdPo1DP80nddZHl0UaOYtVd1L3sfICaha1kfv0bgbB8JOSHVMg68+yeI/MPwwkuiqQhMvaPYjyQTQTgTCkruO+CkOmIA34hDVXHU4CASKEt7ZlqVNbpPhrRGzoUS9w==; 5:alkBqE0KNs3Tbbc+DNew92jIYUom9xBDD0JJcax/jWfzCodt41cWEGTxhTOaaAJoInC1jJPoQJj/QDKrPmUW6wnKubkogHHQ3Y9Y2rzewueqRGVe7iVxagwzHx/w87fuDD/C82LtIOJMAG4fYfO5RACenaqYub+wGxUAmSZNg3c=; 7:G3jdZwtFlRu19SdFPzRHogceW/eisW2NiQCOZdh18mpm99xf1+2o9aRnIl2FiSvykTIlMB5q31Wc5eK8hKLWblRqkcReeb2jR9dO8ea+Ke4WU3LuECzZrVtRU2WQYju2R5mX7Bq7lgQHk/kD7HDtZzfkY8wfL25yev05ldiLxxRkCyNjB8tPfK5x/miyS108clVTyWMxWCqI8/ELCf/kgFlWOeT5Dm3Z4umbIgGAwxhUHPRwAStsaMJ9UU7PaCxc SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2018 07:58:45.6540 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8533331a-cc99-47bc-4fb6-08d629060d7a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4999 Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 07:58:51 -0000 -----Original Message----- > Date: Wed, 3 Oct 2018 10:41:33 +0300 > From: Andrew Rybchenko > To: Jerin Jacob , Wenzhuo Lu > , Jingjing Wu , Bernard > Iremonger , John McNamara > , Marko Kovacevic , > Thomas Monjalon , Ferruh Yigit > , Olivier Matz > CC: dev@dpdk.org, shahafs@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > Thunderbird/60.0 > > External Email > > On 10/2/18 10:24 PM, Jerin Jacob wrote: > > Introduced DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags and > PKT_TX_OUTER_TCP_CKSUM mbuf ol_flags to enable Tx outer UDP > checksum offload. > > PKT_TX_OUTER_UDP_CKSUM, not TCP OK > > > > > To use hardware Tx outer UDP checksum offload, the user needs to, > > - enable following in mbuff: > > > mbuf OK > > > a) fill outer_l2_len and outer_l3_len in mbuf > b) set the PKT_TX_OUTER_UDP_CKSUM flag > c) set the flag PKT_TX_OUTER_IPV4 or PKT_TX_OUTER_IPV6 > > - configure DEV_TX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slow path > > Signed-off-by: Jerin Jacob > > The question about mbuf and ethdev changes separation is applicable here as > well. I have no strong opinion, but I think it would be good to follow. I don't have strong opinion on this. If there are no other objection, I will split the patch further as mbuf and ethdev as you pointed out.