From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id DED9D4CA5
for <dev@dpdk.org>; Wed, 3 Oct 2018 17:08:49 +0200 (CEST)
Received: by mail-pf1-f194.google.com with SMTP id c25-v6so1517311pfe.6
for <dev@dpdk.org>; Wed, 03 Oct 2018 08:08:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=WY47jI5c7Jg6b+8xuATmsXZzyaPWyApQATnh2frxShY=;
b=o7dSMxj+9RI8USWos2P1c2RQYJt4f5wB1p1S67DueHWO2GxogHGX0QpiWCpTUi0y8Q
+OUsB4NL1FCHi/zqpgNm1OWLsIp3xKlCPS3Lczwfu8HxvWtYAZAOhTMnfG7Yyow8Zwsl
brsXwn1TQw55e0d2qbA3BqlF4p8mIZpqktfwUrgT0jRCLUC3amQI8IuoTCuJp8rfWaxH
pxhXHKIpl13uVMEAM+0+U4/FXU01xmKcYp+3SBleIUNZ7aTQ34EcDavXk+TIgCQloeCO
2L0sKBtOS4YcqM8oNULouA96YPVTkOmPJ77yHPfyc1iHOFjnAuWRdVySAcvcEcQEwY88
5pZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=WY47jI5c7Jg6b+8xuATmsXZzyaPWyApQATnh2frxShY=;
b=LZFhYlDZFtPoqkl7B+tdcNpstEcTLhh0ThqTAfa/wiwnbJjB/+WmlmZ6mvnItIeV2I
MhRuIg9b1gn+IHBzVEaDdm2FL7Y4HXB2rzTU6A6ZIXR6+5LEqSnLkHfkHDI9wcg+7W30
g0EfTirgc52rVJTwcuVn6Jhz1Ge0jHsEYn5LYd30QSGYmtqJeBvq046UjwVm7n3ASg+k
lL4fWIo76PiKOnGuxHytWDyng8wI/6qe+Fn/gSKEPsrAHIHCQorJrZBbGytcpCzm6ebq
TUda8v1oIUMNjp0DINrHRaFJVDqN8Y+esKIdxsbU4F0OFkO8WevFaYbjYB3rG8IAtwWv
hTyA==
X-Gm-Message-State: ABuFfogquS+9kLb3f3TvGBh2ybxRNOwM/3IHQ8FfBY6PLRAGS2VTS94m
022Lnrrf3TI/7JeYAtJW0uGVWNv0mfg=
X-Google-Smtp-Source: ACcGV60D2Oqzabg88eS/cbJ3KRifVdn+oe8rcE/AxBq1Edq2020+zYQssS/rJbmoHUU9pTnvuOw52A==
X-Received: by 2002:a63:545c:: with SMTP id
e28-v6mr1771549pgm.316.1538579329056;
Wed, 03 Oct 2018 08:08:49 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id e7-v6sm3715995pfk.3.2018.10.03.08.08.48
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Wed, 03 Oct 2018 08:08:48 -0700 (PDT)
Date: Wed, 3 Oct 2018 08:08:46 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Wang, Yipeng1" <yipeng1.wang@intel.com>
Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "Ananyev, Konstantin"
<konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Gobriel,
Sameh" <sameh.gobriel@intel.com>, nd <nd@arm.com>
Message-ID: <20181003080846.453881fa@xeon-e3>
In-Reply-To: <D2C4A16CA39F7F4E8E384D204491D7A6614EB03C@FMSMSX151.amr.corp.intel.com>
References: <1537993618-92630-1-git-send-email-yipeng1.wang@intel.com>
<1538155426-145177-1-git-send-email-yipeng1.wang@intel.com>
<1538155426-145177-3-git-send-email-yipeng1.wang@intel.com>
<AM6PR08MB3672608643961F72B966355098E80@AM6PR08MB3672.eurprd08.prod.outlook.com>
<D2C4A16CA39F7F4E8E384D204491D7A6614EB03C@FMSMSX151.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 2/4] hash: add extendable bucket feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 15:08:50 -0000
On Tue, 2 Oct 2018 23:39:51 +0000
"Wang, Yipeng1" <yipeng1.wang@intel.com> wrote:
> >> + if (last_bkt->key_idx[i] != EMPTY_SLOT) {
> >> + cur_bkt->key_idx[pos] = last_bkt->key_idx[i];
> >> + cur_bkt->sig_current[pos] = last_bkt->sig_current[i];
> >> + cur_bkt->sig_alt[pos] = last_bkt->sig_alt[i];
> >> + last_bkt->sig_current[i] = NULL_SIGNATURE;
> >> + last_bkt->sig_alt[i] = NULL_SIGNATURE;
> >> + last_bkt->key_idx[i] = EMPTY_SLOT;
> >> + return;
> >In lock-free algorithm, this will require the global counter increment.
> >
> [Wang, Yipeng] I agree. Similar to your protect for cuckoo displacement, protecting the copy part