From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680085.outbound.protection.outlook.com [40.107.68.85]) by dpdk.org (Postfix) with ESMTP id B24ED5A44 for <dev@dpdk.org>; Wed, 3 Oct 2018 10:59:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9UQXUL4qQsmqMQ6HPsLzzjsxlBJv4hHwpAs2fJsN2A=; b=HfhxB7dO+bjoetyb+xAfxGoFVVSnIMPTnEUWiMXCZidz+4u+SlW+alIrEoZTAhhPxoTSe/4yp8JEFRSaZUaXZ21e1gwIkrdxxnaUFmvtUcYASAaWRPQQUboeEPJAzDrHXYUTLbJxVU+4ESWFpdNFdhbRVw8kQ+FnVntxGZCnVek= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.22; Wed, 3 Oct 2018 08:59:27 +0000 Date: Wed, 3 Oct 2018 14:29:10 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com" <shahafs@mellanox.com> Message-ID: <20181003085909.GA9894@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0097.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::13) To SN6PR07MB5008.namprd07.prod.outlook.com (2603:10b6:805:ad::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7b01a44-8030-49ec-bdc6-08d6290e882c X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5008; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 3:8Liyapg+Inh/OB5IM+fIfAFNJlOdVRceTxrl9Z3dHC62sHPjCZrmhRT8ZiZ0G2sKEx6ZbtBVAKN99qDHYV2wUtJowSfO3L4xou77SV8LbN9WKLpcoVFi+CQahltPa/rNMqrfzED5kwIr4eI50AvkG3ZPJoRJwwEP3a5JpDmr5jniW7EizPyyqS9667K/y2hjgB87CmXMV1vsox3UiV5Kyp2pgse3pu8PfZiSiSaMZjsEqhfY5wJjx6Ua9G8dmQ1N; 25:tW4uqQdKv5OSTNZ4XGWgZqKvrefvXjT7VYvCXNW75/0uh0hIr2jsQXCS/aUGSyDKg/TZCsc03UzmVc+tqevEe+jih884KFTgZ9vRkvTxQ7dSKLGWwkaSje8n3fNcO8kfMliO2FDF2gKfOjdtTfmoe8m4SVjtVMb0ma7uUgm+xMwUshAJ/rfOCrJtuj31Ipn0M/FZwToezb4dJpV4OjKRPXR3iW2nm4/Y2MHPg6Gi/pZXVhMnxSxvPTMOduYRsuWRbjd4H0lXb4p55ZXmqkhEF0STagrDgxbE3qyaIFGNG0r35mg7TkfFNK0uR19u19XdOH578bGkHT9zK8Cyx+t8IQ==; 31:9DBTOoa7XIqMSTiwXTDFS28F5RkzmuzFodKkSetVvNrS+nfKBq8M0yIOXtiSDq6B3r93Urk4hjsnSWN+sPYKiozMIdu9EfRy4vNRVqzzPjD4l+Fj76H2k8uALTgwL6ob769zTjOArr0Zwk/QwGo8/UNf0tseNASXjKhSSKnQT7VhjzgOOOC7zGOUMu4MPdzSOGr//R8Xyr8QdgtzDpfmhRB+bo0P4x3CtDQjAE3+kNg= X-MS-TrafficTypeDiagnostic: SN6PR07MB5008: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 20:1SuOoIAf5y3BX/SXSghjLlJYQRZ4SZxiVi35LMG0oHY4AJD4u9djNSNs54jHI/OccrBbHyc9EVuBFhxZLIo99DQGN+i04eRliBExYTOqeeW+P3il/We5QqTAr3i6mkoiwhsVxrIXQO7B1rZKRvt+94A7g4nUy6vUEiaIx7dXIAGQUid5jNEQeYVkCEIizYqVSoxZechyXhcez7lKWK5XSmvjMFqzyzPhgj2IAd2Y8OKBgXJ8Wx3iGtaPbY/MUxpVe0E3v94y+qMzf17bWwpHKIJMlyxYOpOGFmeBVuGTQk3gnxu3AzioRSSAzP8oTzA286O2jyu68YmQHxl3Dgrr0HBDWLORQ0JYQUVKzurN1RYhvPy+ORhpQQBQlwS0QsO10F8BxS+IgymDouRBbMJwRPaRaj+MbSav9W0JHCAQb5Tvlpke6UF9RpJLdxtkukC4gmede/ABXMgzqzUK/f6OOT2sNkx46rSZiEtwD1RLkDTkvtSeMpdUxgblDq99a6cQ0XwxU4TxuSX0J/8CLwL9iwNmLeEJ9VaWux9SGLgFQEvwGtlkPXDTlGUlbdquYY4BWoZQBBRa6siCk1XKEOHCUK/tRLms7mK148DorZ3ur1Y=; 4:JXQkV3YMqHds8FX+seRvtqJMeswuH8HzKlnIOejs/QFLQjEXgeRrLLvoo84spFDSdRkxYSrFHRIehnXNVQRZ4Jc7NJkyLyqW/n5Hh6V22LiU1Aq76qosZOXKKZxQf3amFRbOzoIvHZzXUWDAllPa28CpHQESYUWqNLKytcRMQgKhUNYgjVpU52tx2+fDvAsoz574rw8Q9g7ZCAi7OBtKlG4Q1onmhDggb/sJcINVqvU4V68NhOi2tLkpuhjdlyvd3ODgAuNUWQZ9sLLrOPHx8canTztfgeVv74oSmhjs1b8aUmdoB40Em5sdOOBQHCHm X-Microsoft-Antispam-PRVS: <SN6PR07MB50081DB3180429AC93CA044AE3E90@SN6PR07MB5008.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:SN6PR07MB5008; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5008; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(346002)(376002)(39860400002)(366004)(13464003)(199004)(189003)(11346002)(58126008)(33656002)(305945005)(6666003)(9686003)(53936002)(486006)(7736002)(6916009)(26005)(446003)(14444005)(55016002)(54906003)(386003)(1076002)(97736004)(476003)(66066001)(5660300001)(47776003)(229853002)(7416002)(956004)(42882007)(4326008)(186003)(16526019)(68736007)(50466002)(6496006)(16586007)(316002)(44832011)(8936002)(478600001)(81166006)(5009440100003)(81156014)(76176011)(25786009)(2906002)(52116002)(72206003)(23726003)(105586002)(6246003)(33716001)(6116002)(106356001)(33896004)(3846002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5008; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5008; 23:cmVA2P5LAwRBG8qNvX6sK5aT6MCOWRZXd3wiGhHFE?= =?us-ascii?Q?Orjdi0XCslDdZubtcPTUfalLd31wY99S6m1CX8JTmemmkSoCqsJO0OF7Rjld?= =?us-ascii?Q?1Rj2WIaNk4XcK9vl674X0B0kFTX8YYDJ9e3GZMthFu+tY/0keO7qvUN1QWjH?= =?us-ascii?Q?+bmUd0V/A8yRmutAoQv3mmYVIbq9cZtZgnSlH6Yv5OLvVfBvXrE/iL8EQXwM?= =?us-ascii?Q?JQQ2X9yznrTW0/59G0Q57I7xdBd/Lwo2Ed9wOhWqyanxNy5lMNI5YEy5Cgcb?= =?us-ascii?Q?7FP0NSys0c6nHhcWvSGYXadi3HaKGY9aejG8dU6XHZ0W3GOnyTXKi4OD9geP?= =?us-ascii?Q?ZV32i+k6DdtzfYPyabObG4RMpeHLG6X9ppHYpnaLEpV9cSOn3GFIozDQf8Ls?= =?us-ascii?Q?9C+lLelg/DKbOA/BjtWSDnAvs1bFq/3hQDrTpLGh/KGnaQUZKxRUT52xRIUx?= =?us-ascii?Q?tQfhL3G5nO+kq/hIMlOcmSIxH9fOVWR5/EEHOn6yZ38P1XR9mA842s0hLCGm?= =?us-ascii?Q?G7JRMhG3oGwVsi0hxJcuKY9nLQhw6BZdVb1p4JG0284wMvZ6juYT8gWKWoyj?= =?us-ascii?Q?tAss0x4kKbQRYKldMH0JyZ4iqgMXCZvkhh2H0D0Ul2yXvi6ONzuDIKZnZJOD?= =?us-ascii?Q?PaLCicdYekzM7eD7zrffUMmo14RiEHSZL71kGjbVexwltlaTC+mEWAvC70UB?= =?us-ascii?Q?cRTljBZKCwddfFe7m8dmcxIx6ptRT45pEE16oemO6d725VjAsQLxNILuKrgJ?= =?us-ascii?Q?Cj0di6z7koYCNbw6aghvoeT/ObaKeUVGn7opiBwx+SYYttyD0T+jUKY4FRR8?= =?us-ascii?Q?aHFTBG1jNJGmZyrPTZUFDcVWPJxLsM3vmlEW/d1izI9M/VrIhMhpwoEagkxQ?= =?us-ascii?Q?+YBbVZWegxzStsA9ST1s9rt7GZA6NXxoM6AFQnEBlCzgLsk7yTrIw5THCcSU?= =?us-ascii?Q?YtlueYsvhzgc89ZVZouNFjtUuq5uxbaU0qVUggVriAeME0mHp6L/0WgJYKB6?= =?us-ascii?Q?euAOheu1m3lledec8sEHqKefLkc0SQtbvwmxpwMoeqciPDL/9af3xA+saC1O?= =?us-ascii?Q?pJvkZYFNvzza/KPCJ1YvOiBcBp7LLnRROUUT20mcLOLNn+SbDUUMHdCuMwdS?= =?us-ascii?Q?/ddlVNtlY8Pb7rSQUVZLUSVo4nmdXMNuh7z7yDr+jV9QK3cGhXeX2FTDIDWL?= =?us-ascii?Q?/bSpHAD8/QlFC100CNkw5zQQ1wMB4qF9J3VB3PtegEnfY+nQUdhr8xOS3lP/?= =?us-ascii?Q?s31ayu7BOymwoIKvTKIQiYS/dmjkdDnjSVVwGl3f2jTSf+ykLqg1oMx+n5uS?= =?us-ascii?Q?XirOxv/GDxitx4C2cy/ivtMsuIatn5M14HaLpX8A+cYeDUIX1cbCobXZZmbo?= =?us-ascii?Q?7vkA2r+nei1IsKXIle3lvu6OmDWFQJd9AldbnWK2RXaI9i0?= X-Microsoft-Antispam-Message-Info: Z1Ty15lZw92jmmEY1OsaVeyam+Q+DFCD2wV3279Nmlgpes2M0sZiatJIyFjgFhmVJvxBBTlh+Q8NLGebs0QHjq7ihtQhuulDxdjfZesSITAKTnMbLZRpcQ9EXYrIINbXYM8ZsjgnfdNJ7iHCh4jliV29UxEHzdUVNxC+fidW3cku+omwmK+LIhzGo7vTWfW4qZmy4bMC03VMqfHqjJppvneFI/xWNPIVR2t7Sf+di7xwS5eTBQrpXeu6xydvofjfV230ntNYIJNafp4zjyr6rwVIxXcAKWyL1jRmgwnzVfCE5dLN+EW1Mu2ZDM8oK/wsx3wAp+SAyYktS+bKf6EYmNt+/KJy8iPosqfNWQQ+slw= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5008; 6:lWfzRY611DFCaB99SIgl90bjgq8rCeIwTva/WxU+DagQ9iPcqi8phOsJ/7TT0gXue21BLLMKiHmcIDfBlFfJecJ1OaunOODorqACbIRRk0Nzyy0UfCY8ydshZQMcC3rz76q6mtUXHQBI1Pnfw8S0uJbIxea57THTltBHFA8lTBjoQUXSbVhegcrSn7PIMpux0QWOM4EStEZUXPoXY2841zd+rbwZqigjLOIAJFTrW/nbPMrpKO5p8OaLGDK6vU34XpsLbMfj0hcRb6hI0/yWpJieENuwT58v8yvjYOiEz3HbjzjjFCetez+oPIfWqnUIFlVn8excackFUBeQM4Pl3YrjLE4x2B70cDUje+2vsa6FUD1o/h+JhKUvWQMIp05XRWOQo3BYi1xOcRk4BemHwXm9u3jxKzFvmQ9EIKCakdGnzfYmMv7piSEmbkxx97TNShtwwf7AwBwrbPDjoyzn1w==; 5:NfWR4fs4WafJ+FTAEgsSxrS6BHuPyEm+CM9M+JXOO2ln2zT8VcIruILLuGEsupa+UFjwYFOfo6Biobu2ohmyPVZkIFpUJ15U8T43o09I6ebwO+TG7l+PPi4iVzLWCumyzw5HDKkwDAkvzLtxPymrAp6DPLLgjvceiCVdwmxcIfw=; 7:Cppkr2ZtcmnwnCbbo+Q7G9sxxJyyI5p+mbK81xOJNHSXhqEPtPzWFjeziR1eU8P2qA8ey144THMFwZ25A+FZUAHLgUvoK+F7PaCEtRT9UrexnFPnxqvLn6roSOeSTdQSmkREoiNkiSu3Es/zC83QCimSdDCxBE8ORTTef9506WaFaT11czgkqqxjPXASzk+YYsjLbWcze2R/QgHJ8myPLG26bf0Ct6kP0vb+Zpnf2EvkpQXP3D0a9NWqfF8hCd9D SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2018 08:59:27.4949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7b01a44-8030-49ec-bdc6-08d6290e882c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5008 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Oct 2018 08:59:34 -0000 -----Original Message----- > Date: Wed, 3 Oct 2018 08:53:22 +0000 > From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Lu, Wenzhuo" > <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, > "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" > <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, > Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" > <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, > Olivier Matz <olivier.matz@6wind.com> > CC: "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com" > <shahafs@mellanox.com> > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > > > Hi Jerin, Hi Konstantin, > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > failure. > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Looks ok to me in general. > Just wonder is there any PMD that supports all these new features? octeontx2 PMD has this feature. I am planning to push the PMD for v19.02. Before that I adding all the common code change to avoid the dependency. > Konstantin