From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0045.outbound.protection.outlook.com [104.47.34.45]) by dpdk.org (Postfix) with ESMTP id 834F85F54 for ; Wed, 3 Oct 2018 11:26:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1e3upyTnkycj+C8xY56tjQoVO5cyjlPVg3o8hbtv0QM=; b=ibjsOa8bNkCy1ErL+WxD0Z/36xktVrWzjSYpvtfQn9ch1/VdB0t2RRCvJhH+ZG4WNMooy77SG5QmtdUykMIsk7lGqBlFiyBEdUvGBqEsJphdtOEQh7FV+ksuKdNaNBeEebXu1V9Pzyl1K8sDNQzo8ojWg4/UwdBtDHcGNQMhdzE= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB4600.namprd07.prod.outlook.com (52.135.204.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Wed, 3 Oct 2018 09:22:12 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c465:d2a1:d4ad:3af7]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c465:d2a1:d4ad:3af7%5]) with mapi id 15.20.1185.024; Wed, 3 Oct 2018 09:22:12 +0000 From: Jerin Jacob To: "Ananyev, Konstantin" CC: "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Thomas Monjalon , "Yigit, Ferruh" , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" Thread-Topic: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Thread-Index: AQHUWvaVqlbv1ZSGSUOluj5PysSmxqUNlPeA//+o3wCAAAFQAA== Date: Wed, 3 Oct 2018 09:22:11 +0000 Message-ID: <20181003092159.GB9894@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> <20181003085909.GA9894@jerin> <2601191342CEEE43887BDE71AB9772580102FE152A@IRSMSX106.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE152A@IRSMSX106.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.93.218.67] x-clientproxiedby: BYAPR07CA0049.namprd07.prod.outlook.com (2603:10b6:a03:60::26) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4600; 6:6FHCe1l4KBm68TNf2rTganSWIZXVr9SMvAUvjXlk2I7jEObBYCebXG6By0+ywvgywEjE31yWj1f/EOqSFxQBiiLK0LOHfkwSvDnCUtvRNe4Cs/CwIrLUimo0tg0CJOtro7W0zV6HpqztsCw14ksJBOmHmpmFZvAb5Al55sGsC0FyKbURUqcHxFGsZBdeRmaW/n5nTe2zRri0nnTdB9hlJAS6XBXW8VpOrBmhmrXRQdy456GPhpcdCpMl8ZyLmC+R0C5i9Gl2mq9mzauWlSL9VFQvvggwVHE+CFdyIom0Zfo+33p5WEHGKQ6GbCV6DSr2StVzY/tgz5LnjUoocKo+6pBrza4XIV0wnPBYuVLZ6AUgNVQj0i0RwccuxF/NzCo5d/5a8EWSAB5yZaJfTrQSKbke22e5aYPbaPm88KkZv8ufxW3cPTBFZ1Li5jo0QtCDsN9L3yTAzWj9oGyXHqwtcQ==; 5:LND357Fl0aTZaTi/wdAYFWQcIIMoo2vIT2ShdN4+6stt7bBmQ7XViDFNv5Fq5ME0xNUQ4s7XdcoGVYLpbFtSKkM5VlYCRVLUQHi5tWIkqeGeS5xWyxq956i/BxECj+n31u8iLsLAfbiy2YsXX1y+QXbC1FsxgE2t43esb2Pf3Qw=; 7:ENf4TLrR1knq2JS+Y61HbPFkCZIHfYseJD9kHk0jYjfupu3pNuDosTSOn2bgaFawfHccBaDhhpiAAK60rg2GeitCL6peJs3gw7JG4x3imNlFfHkbRcWWmUQFyADfIaaLSC230OAvWGJH+mwmYnuHFJxdDIzxC2ExUt/JV55PANc67qlc61rzSMiCxxdNz2toEWbZTpyZv6F7/wwTutwaAkLdx6zHib56IO1ScYucrLuM12R1TtgTKoZC7XsnT3wZ x-ms-office365-filtering-correlation-id: ba4c3aca-3c15-484b-f2f5-08d62911b30b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4600; x-ms-traffictypediagnostic: BYAPR07MB4600: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(93006095)(3231355)(944501410)(52105095)(10201501046)(149066)(150057)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(201708071742011)(7699051); SRVR:BYAPR07MB4600; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4600; x-forefront-prvs: 0814A2C7A3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(346002)(376002)(136003)(396003)(366004)(39860400002)(199004)(189003)(13464003)(102836004)(229853002)(97736004)(33896004)(478600001)(52116002)(105586002)(76176011)(5250100002)(33716001)(186003)(6486002)(72206003)(2900100001)(14454004)(6436002)(42882007)(93886005)(1076002)(26005)(386003)(6506007)(2906002)(6116002)(316002)(81166006)(6246003)(54906003)(446003)(11346002)(68736007)(81156014)(99286004)(476003)(6916009)(3846002)(14444005)(256004)(66066001)(4326008)(33656002)(106356001)(9686003)(6512007)(8936002)(486006)(7416002)(53546011)(53936002)(5660300001)(71200400001)(7736002)(305945005)(71190400001)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4600; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tDm3rSNSNsgPYlTtcgRlF/j3/bezxheOAsVUxGduikW8+Ddj6ajo4yzGi5GQUZSbMPov+5n/R0VDCRx0ANWfOa6kF+kDAyvcm6y8uW3doc6n5BU7h276AIJsa+eVARD7lwM2J3CmloG413fImdJWGns8vcJ+hOw9Q2UWMXVFylyZZCW5SVAmV2q+rWL6Xy5dypFtOBP1Y8m4PJ0UfCV6DP3bQbtcqeXr9nJVeQCLjvXEKKkkoei0O6pEzjKAQR0Js2HJkNYx0Uy3AdaGxQEvLbFni7Hsg2so0bjMdZbVyYBmQTuzF/1tYoYMWFRaxRdS++vsXGqR62DZwmpRXrbJwTUiQJ/WOBL6BGHCsdJgyDA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <2F2B446F4515D34FABB467DCF1174876@namprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba4c3aca-3c15-484b-f2f5-08d62911b30b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Oct 2018 09:22:12.0115 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4600 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 09:26:07 -0000 -----Original Message----- > Date: Wed, 3 Oct 2018 09:17:18 +0000 > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "Lu, Wenzhuo" , "Wu, Jingjing" > , "Iremonger, Bernard" > , "Mcnamara, John" , > "Kovacevic, Marko" , Thomas Monjalon > , "Yigit, Ferruh" , Andrew > Rybchenko , Olivier Matz > , "dev@dpdk.org" , > "shahafs@mellanox.com" > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition >=20 >=20 > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, October 3, 2018 9:59 AM > > To: Ananyev, Konstantin > > Cc: Lu, Wenzhuo ; Wu, Jingjing ; Iremonger, Bernard ; > > Mcnamara, John ; Kovacevic, Marko ; Thomas Monjalon > > ; Yigit, Ferruh ; Andrew R= ybchenko ; Olivier Matz > > ; dev@dpdk.org; shahafs@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP= checksum definition > > > > -----Original Message----- > > > Date: Wed, 3 Oct 2018 08:53:22 +0000 > > > From: "Ananyev, Konstantin" > > > To: Jerin Jacob , "Lu, Wenzhuo" > > > , "Wu, Jingjing" , > > > "Iremonger, Bernard" , "Mcnamara, John" > > > , "Kovacevic, Marko" , > > > Thomas Monjalon , "Yigit, Ferruh" > > > , Andrew Rybchenko , > > > Olivier Matz > > > CC: "dev@dpdk.org" , "shahafs@mellanox.com" > > > > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer U= DP > > > checksum definition > > > > > > > > > Hi Jerin, > > > > Hi Konstantin, > > > > > > > > > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > > > failure. > > > > > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum = failure > > > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > Looks ok to me in general. > > > Just wonder is there any PMD that supports all these new features? > > > > octeontx2 PMD has this feature. I am planning to push the PMD for v19.0= 2. > > Before that I adding all the common code change to avoid the dependency= . >=20 > Ok, but why then ethdev/mbuf changes has to go into 18.11? It it is a generic change then why not? What is the real concern here? > Do you plan your new PMD backward compatible with 18.11 LTS? Yes. > Konstantin