From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0061.outbound.protection.outlook.com [104.47.36.61]) by dpdk.org (Postfix) with ESMTP id 999F31B10A for <dev@dpdk.org>; Wed, 3 Oct 2018 13:16:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s+Zez9+gCH9bXGYVHhZIjj+SDwqHuADf6WnZ+fVweD4=; b=HLZRKVuvMqn/F4Kqv2FD6MeQHnqcSxZDhxrsaq337OnwzFfT2Uaq8S15mX+uVclVstzHwfZicx5Lqz+IDGIy/5XaCLtcrz7/pa1O4m4GqT3rrb8VOAmjww/D+cI05y0tMS7GaQI0LzJ6ia43xZTaD8ga5oRY2lB10ApSorJznNg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (111.93.218.67) by BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.25; Wed, 3 Oct 2018 11:16:08 +0000 Date: Wed, 3 Oct 2018 16:45:51 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com" <shahafs@mellanox.com> Message-ID: <20181003111550.GA9248@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181002192451.19119-1-jerin.jacob@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772580102FE1479@IRSMSX106.ger.corp.intel.com> <20181003085909.GA9894@jerin> <2601191342CEEE43887BDE71AB9772580102FE152A@IRSMSX106.ger.corp.intel.com> <20181003092159.GB9894@jerin> <2601191342CEEE43887BDE71AB9772580102FE159A@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE159A@IRSMSX106.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BM1PR01CA0087.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::27) To BYAPR07MB4999.namprd07.prod.outlook.com (2603:10b6:a03:5b::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3426fcb0-e49e-4a96-848c-08d62921a05d X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4999; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 3:euW1II/FnXeMpq2VRKuTVYQSVMfOkMWjwl81dKUWa7IEXUlpu+EJVRnPrDjvV7JwD8suOMrKaexgxTZE+DBLhmP0MmmgT3ias/ekbWaIr34BzImFA4Fe2F51cXJBETSp5xPg7VGZVExHTxaXHVD7EPvN3/dLZ+DJDDjDF74MiNbLtVKpzETQr/e2wA34Jl/ITjWU6Qb17lntFXZvknkVc9y2UwCT7NPYRSalJcf98JK9niSJztajFZab8Y+Zf5X1; 25:KNjq2JBfZOXbrIANC4QwKuy+8bpxEt4q6+B2j+SwqEN/Zq2mZaTC64roZ95Im3Rmw7fPuZBghbXe6r+faNqthiGYGiRX7GMd4RvfMzTqN14IOb1UNNvCU4AazrKC0kFdA058QGSWX2aBGJNyBpgd4dNBvt5k78/J3Wmwq3GK2PmWmKo6tEXI4nBqmlbKFErIHH6txYbTFlGx7N5GrDMxc6reEZ+eplLupp5hD9VuiFwyFOLJDICqvcm7PZOWcjnXxrRorcAMmmHKQhs2SKwHYsADkWtSH1O0N2FxFDTYmr1ewPAh+Zo3Y9d/qWG8QkALHjsV1TKcLFc1vBlBVksrDA==; 31:Szvl9qjcLiNObloeN50m+ZErrJJvwp9DYDH+Gk2qaUiWPyhyQ5xAzXHDgASLpyd2ZFwVAKphm8V7rdGvEE5Ise15Cv3hL9YQQtodaBAZLtvfUnQ1I5GUulsxgKGUGWaOdWMWt+gJ1bztM1KOf2fAVKK7QfPlPMdodo0jr6Ik1e5mo1f/z01vNtFNUz23GBQ29J7gIowgn0pF9KJomJahD8RP46U4ronSRCfsPHAsRBI= X-MS-TrafficTypeDiagnostic: BYAPR07MB4999: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 20:m8gUG7o+69frewpt0Yj1l99xBf0Rqayu9Blo6+tqnGSEOfOb1NIRZgnypW5lRC4Gapfg2xKhdNDihuPfkPmZo7OV4jhVjhmV/ZCEeWPc1wXR2pgY3fKpq1ioyZDZJRvmeeQAhu7+yl9qaOWm9YM3uLn3sSNsCwVNSlesqAJ+5mCurzZ8PUvvlkzYJxb/TpYdbFtOc9YpzIJDM4Ky+/7t7fF/t/sIzjiO/97ShR8nC87JH/zq+VOLwCfbu0z/og0ocSJivsuzWbwkqeVYFOnBf4lyN8wNq+BFu3uuqXpp5X6yUF+TNFlpo1YhJ08qM3J6JjnUr/kWt9JHtkgTHz6AU0m8oV05tnapw7fcYeSAEyKV5T/Cttzs6CNWyQkDBzHnpDUzJZfi91M2Mowcf8Ynl+dQSocLFGkXrtSlwQx8XipJq2cf0QTQlQAT0p5NXH9Q5eE6DXmCBaqTls4GTS9QLEbCgQIlXq4wku1MdYc2cq8j6m76luClFnukT1BI+3tAjUmoI3Gj/gE0GbA9i5vANgIwDso/3J962C3OSpeI0CPl9LjqKsG3pOkb6Df7v+sZ8NSUtx62AGJ3CwvOS5wxIGkKcSE3R1DRYPDiDipt9RQ=; 4:cFEsE+/6YRnxWCWed1yvPKPLHPKu+K4eE+TQhU4gMe6/Yr/Cz4Gps7N29vL3THnBZWlbKuIMeNYkAaDkYfT3FPCTPDGeC3RXzkZk3wVhCIoI9vCUR6xX4wCf2HAdnzjdfAgZrdool3FjpAD/Mezy2LVNwAqQsD1iLuVzPMNMtWpFY4EmdA6NOHFAKNf8Zc1J2jMZvapXqpjcjMSnm6BLLf5LH4bm6GKU8BTtaj1q5g12y+JldHuehJTsDlW6FVGE3M0AnzSnojSCg66yKw6UE5KgfqFTDjoLuIfR3Ne4o/iPi2gUBON9/P/sieDs6L5/ X-Microsoft-Antispam-PRVS: <BYAPR07MB49990CF4BB4DE084670EF408E3E90@BYAPR07MB4999.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051); SRVR:BYAPR07MB4999; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4999; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(136003)(376002)(366004)(346002)(13464003)(199004)(189003)(956004)(11346002)(16526019)(6496006)(476003)(386003)(53546011)(97736004)(7736002)(446003)(72206003)(486006)(26005)(186003)(478600001)(54906003)(58126008)(6916009)(5660300001)(42882007)(44832011)(55016002)(53936002)(7416002)(52116002)(14444005)(229853002)(76176011)(2906002)(9686003)(33656002)(3846002)(68736007)(25786009)(81156014)(4326008)(6246003)(305945005)(33716001)(33896004)(23726003)(93886005)(1076002)(66066001)(106356001)(16586007)(47776003)(105586002)(6666003)(81166006)(5009440100003)(50466002)(316002)(8936002)(6116002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4999; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4999; 23:KSKWxn99i73vSYCGX6tA1aCFPvFccloAWcHrqyxNF?= =?us-ascii?Q?GvOx70UTzN57yECzz60vRBnyEZRoVZUiKivSfOJ+D4Yzt/4fvInUXTpg0BvY?= =?us-ascii?Q?dCM+G7RwPrX+DskDeRkjpwA54rIuVMUDT7lVb3OSOsFqKl+bhbmv8tMN+UC0?= =?us-ascii?Q?xViRkAqEhcN2700/u0uMZGeUjYI5/3toC/OuuzLoJEwefiIzMIZellFZzouE?= =?us-ascii?Q?HLyL1MIkIGpzuP73mb+LW3SbMFhiPZP+vQmg5Vs9ztrkpVzj1+ytYseW0STG?= =?us-ascii?Q?n5WFTwGiM7xojeimIbo6KgGa+9MQnXCpjxoc6mArFzFH/9n9dkrcQPGq3Pns?= =?us-ascii?Q?t3vzBQe+pZziRn0Vrwer7cJTF6R3pSkesnyfJBLDxEA1MvLv3A4Vr6ZMLSvI?= =?us-ascii?Q?/RN57Pw1kEihvcjsomCx7fqXKRQiDLBZ+Fn5RRG5VYFHTKxi21444sC+RNGZ?= =?us-ascii?Q?eBaJ5l8NGv9wBcjfI2FTwxUPRZXY8WdOcxQpCEV3aQTmYFNmbyg22TB68OZy?= =?us-ascii?Q?82iOAXeFfsVucFEbotBlFmuJiKGmtHKQ4tGWa975qHZtQtGQT4O2dDatqiyM?= =?us-ascii?Q?f3sPEQL1kSv7aVx/KEvY7EAjNSCAbzk1SRxRu8YF5zHPXvyPTTJkw0JG9GKE?= =?us-ascii?Q?bIFMSE2bvqAgcWcWrtZtICdSeM/NbISXFrPByjZEdTZoVokYqIu0SCiWuyJL?= =?us-ascii?Q?A2WBEFOCgJDGjsu9ULzBap8Lp0LFnbgfovww2CKzeOP/SJe4+yV9ou/+r2BM?= =?us-ascii?Q?pMHMLxOwKgZVOOfNhtl4n+0Wm+GxF+vzRSeoLyzaRVIMb5ZufR5I6VKLGvxV?= =?us-ascii?Q?IjF7wt2UqygD06Aeh/pG2Q3iVIG7X+B6F8UWALcwGBTJPdZQh/5uZhX2SaF6?= =?us-ascii?Q?Lh/QCoq8b7xWOOPJts06NHbx5P7NWrF/N9TGtngvNuYc7g8VZarG8HDxXOK2?= =?us-ascii?Q?+kzpmBjQY6L3LVXDD55/dqS69RuyVT8LhRktLz6af36jpEPEhRHodg/EyZXp?= =?us-ascii?Q?s/JGiSNgHRqnnBlQzX7H1HW2Thtuir34yo8pvlGFDfjSbvcOGDwC5QMXyRKd?= =?us-ascii?Q?jOioIAqO6eo6StJYPJ8WtZnI8GkeD4Q5Qqw8XcGNZ46ewpyKKVK3/0zfKfpN?= =?us-ascii?Q?Su13zTQ+NWBIFvXMLYAOnO9DbC760wBgjvV1/ExR3NkJcmi0+mvHGs3ivTVK?= =?us-ascii?Q?JNYsds+as3S5L1mUgdZpQrIJ0HnEeX1zL0n22idxcfnsnDHTqUI/oTU4yFtX?= =?us-ascii?Q?4zqELwz04ZM8W/e9qNPzx1KrnqA3QRctf10aI2aTGmM136l0tFTx72m8rLzh?= =?us-ascii?Q?T75YoPxUBhL1Uu304xpQLRHLt6M3mAoi6HfbCU3RyveupvjNFBT2DxD1aEbs?= =?us-ascii?Q?iZltZ+WkyOOK10Bcd7EIC6c6Ncexm4SBPKo96VQB2tZ8p1TxP/xijnHp1b6m?= =?us-ascii?Q?MITiz5zOlfvTYdMc214NmG9CI+Cyu0=3D?= X-Microsoft-Antispam-Message-Info: Zuds2x/KV0voDYyQiSbK1s78rUAC10ZLMm6xznGsKk7/f7YVTG8aNhZkx4+f2RlI31RE29uHL7D5V1JjpvhnsAhdyHgmdCHUQMCr36HjPvPc4+wtZ+FzVFo6A39EaQunidkY7CbpaFFO4hwIA/WKXkorayCB+N/OYwT0Gq9bDCEF7mohXBfjsYwSSrcjHXc8qldIum/vH2Y1FsR9dhEZyG91XHb+V/0UWIuDOinRALEIr7sova0hbx6+tYcCvgTK7z/gMgfUPmrsFAWRIulO5xPA296d74OnG/G1IBz2Z3/cIxNIy9wY1pDlt54LwPs1J4eSLEk7fwHc/3EQ0/BdXBBo0SkrTYdmSaRE6Kyf6LY= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4999; 6:zyCmnrB5sdAFaXp8eAr9aoVCOwu/7qW2Ox4tY10nlooVfBbKTEteDKgRjtfzZamEFcV1f9NZOdRp27HhJglWEP4oVxrqa1Q7m0dTgJ45CGwVIdWKVtvL4gQYXdnL6+yYAPHd6ZBlqNaS3+93PRrew9dviknWW41fRsnF1FNCCOIobFlGH9SADf+WFaKTkQFZThLh7rcgcKOc864Yu4NBtGqul15prN1X6GdaSCTlPijj6RqA9fsacYtxusXZTD1/hplDZmK9D8sVBnoHHKePO/ZEiK2YJu0KfiB//66DOQE81AEgGusrY9pW7HsbeoUwhapr+6HLJ+GGmqww+e4ZHPMO/zztw+b14v2eIQ899El9jdr3nHo6nhMRVU3I0Nm1cfjI8EevNJvZQFr7srcKnIZEGMjflbD/0X7ij/V0J2oeInqaCFMcjaIPbIu51V9L8wJAkZeUE4kKHdWUBnUPUg==; 5:aCRWl3Vff3ezHRfr2ez5UZch0PCtgsjDua3Gcq07zHUJeFzxEljx6IXOzT2dHlQPKjeUPCZN95EBdlLfwFakZwEE7XHpntwJtSaouhVdtpTQDvAqu7aVr3EAKT5Ch/k5DsY2NxS7tSGEeV59IBP5dGlt7eb9ggEK3QSF8vHOx8I=; 7:q7dwrZWxR/tlWlkQCsS7BrGN+VIxVOVC890E1zFSjYgTE4NX9zK8++ozAOZXIBIcE5MKZZ8NBtv0xe+Lw79/kPjnqCG1Uc5XD94ox1b6EvWZweaSePetonJGZDuK9cRN0e2rudo010KcjfnZM5KAtUjiyjL2lmBZK6keSrYmuljhMsg2C+8twd+ywSUpbtDVuz9vUOmO8aC0caHfhMztIBe3KoUYE2blauF4cU+BHaZUGj4rxs4/dXVlFfxfvdMJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2018 11:16:08.2521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3426fcb0-e49e-4a96-848c-08d62921a05d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4999 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 03 Oct 2018 11:16:16 -0000 -----Original Message----- > Date: Wed, 3 Oct 2018 10:16:31 +0000 > From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" > <jingjing.wu@intel.com>, "Iremonger, Bernard" > <bernard.iremonger@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, > "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon > <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew > Rybchenko <arybchenko@solarflare.com>, Olivier Matz > <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, > "shahafs@mellanox.com" <shahafs@mellanox.com> > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, October 3, 2018 10:22 AM > > To: Ananyev, Konstantin <konstantin.ananyev@intel.com> > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; > > Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>; Thomas Monjalon > > <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>; Olivier Matz > > <olivier.matz@6wind.com>; dev@dpdk.org; shahafs@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > > > > -----Original Message----- > > > Date: Wed, 3 Oct 2018 09:17:18 +0000 > > > From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > CC: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" > > > <jingjing.wu@intel.com>, "Iremonger, Bernard" > > > <bernard.iremonger@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, > > > "Kovacevic, Marko" <marko.kovacevic@intel.com>, Thomas Monjalon > > > <thomas@monjalon.net>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew > > > Rybchenko <arybchenko@solarflare.com>, Olivier Matz > > > <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, > > > "shahafs@mellanox.com" <shahafs@mellanox.com> > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > checksum definition > > > > > > > > > > -----Original Message----- > > > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > > > Sent: Wednesday, October 3, 2018 9:59 AM > > > > To: Ananyev, Konstantin <konstantin.ananyev@intel.com> > > > > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger, Bernard > > <bernard.iremonger@intel.com>; > > > > Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>; Thomas Monjalon > > > > <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>; Olivier Matz > > > > <olivier.matz@6wind.com>; dev@dpdk.org; shahafs@mellanox.com > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > > > > > > > > -----Original Message----- > > > > > Date: Wed, 3 Oct 2018 08:53:22 +0000 > > > > > From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> > > > > > To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Lu, Wenzhuo" > > > > > <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, > > > > > "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" > > > > > <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, > > > > > Thomas Monjalon <thomas@monjalon.net>, "Yigit, Ferruh" > > > > > <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, > > > > > Olivier Matz <olivier.matz@6wind.com> > > > > > CC: "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com" > > > > > <shahafs@mellanox.com> > > > > > Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > > > > > checksum definition > > > > > > > > > > > > > > > Hi Jerin, > > > > > > > > Hi Konstantin, > > > > > > > > > > > > > > > > > > > > > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and > > > > > > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum > > > > > > failure. > > > > > > > > > > > > - To use hardware Rx outer UDP checksum offload, the user needs to > > > > > > configure DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath. > > > > > > > > > > > > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure > > > > > > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag. > > > > > > > > > > > > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > > > > > > > > Looks ok to me in general. > > > > > Just wonder is there any PMD that supports all these new features? > > > > > > > > octeontx2 PMD has this feature. I am planning to push the PMD for v19.02. > > > > Before that I adding all the common code change to avoid the dependency. > > > > > > Ok, but why then ethdev/mbuf changes has to go into 18.11? > > > > It it is a generic change then why not? What is the real concern here? > > If there is no implementation for it, how we can conclude that it is really 'generic' one? :) > My main concern is that we already have several features in rte_ethdev and rte_security > that supposed to be 'generic' but right now no-one support them. I think, this case is pretty straight forward changes. > I wouldn't to object about these particular features, they look reasonable to me. OK. > But in general I think we need some better defined policy - > about what is allowed to propagate without real evidence (particular implementation) > and what is not. I am open for the policy definition. > > > > > > Do you plan your new PMD backward compatible with 18.11 LTS? > > > > Yes. > > I see. > Konstantin >