Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Wed, 3 Oct 2018 10:51:36 +0000
> From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Lu, Wenzhuo"
>  <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Mcnamara,
>  John" <john.mcnamara@intel.com>, "Kovacevic, Marko"
>  <marko.kovacevic@intel.com>, Thomas Monjalon <thomas@monjalon.net>,
>  "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko
>  <arybchenko@solarflare.com>, Olivier Matz <olivier.matz@6wind.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com"
>  <shahafs@mellanox.com>
> Subject: RE: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
>  checksum definition
> 
> 
> Hi Jerin,

Hi Iremonger,

> 
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> > Sent: Tuesday, October 2, 2018 8:25 PM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>;
> > Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko
> > <marko.kovacevic@intel.com>; Thomas Monjalon <thomas@monjalon.net>;
> > Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko
> > <arybchenko@solarflare.com>; Olivier Matz <olivier.matz@6wind.com>
> > Cc: dev@dpdk.org; shahafs@mellanox.com; Jerin Jacob
> > <jerin.jacob@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum
> > definition
> >
> > Introduced DEV_RX_OFFLOAD_OUTER_UDP_CKSUM Rx offload flag and
> > PKT_RX_EL4_CKSUM_BAD mbuf ol_flags to detect outer UDP checksum failure.
> >
> > - To use hardware Rx outer UDP checksum offload, the user needs to configure
> > DEV_RX_OFFLOAD_OUTER_UDP_CKSUM offload flags in slowpath.
> >
> > - Driver updates the PKT_RX_EL4_CKSUM_BAD mbuf ol_flag on checksum failure
> > similar to the outer L3 PKT_RX_EIP_CKSUM_BAD flag.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > ---
> >
> > v2:
> > - Removed DEV_RX_OFFLOAD_OUTER_TCP_CKSUM and
> > DEV_RX_OFFLOAD_OUTER_SCTP_CKSUM as there is no realworld use case for
> > it.
> > See: http://patches.dpdk.org/patch/44692/
> >
> > This patch series is depended on http://patches.dpdk.org/patch/45840/
> >
> > --
> >  app/test-pmd/config.c          | 9 +++++++++
> >  doc/guides/nics/features.rst   | 3 +++
> >  lib/librte_ethdev/rte_ethdev.c | 1 +
> >  lib/librte_ethdev/rte_ethdev.h | 1 +
> >  lib/librte_mbuf/rte_mbuf.c     | 2 ++
> >  lib/librte_mbuf/rte_mbuf.h     | 3 +++
> >  6 files changed, 19 insertions(+)
> >
> 
> <snip>
> 
> This patch fails to apply to the latest master branch, a rebase may be needed.


Have you applies the depended series http://patches.dpdk.org/patch/45840/
as mentioned above? If yes and then still has issue then let me know.




> Regards,
> 
> Bernard.