From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E0BAC5F32 for ; Wed, 3 Oct 2018 15:24:31 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181003132430euoutp01cc955c5705892b49294b8309434e85bf~aHA5mngB31310913109euoutp01k for ; Wed, 3 Oct 2018 13:24:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181003132430euoutp01cc955c5705892b49294b8309434e85bf~aHA5mngB31310913109euoutp01k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1538573070; bh=n0LuBVKdAyMUEAiYaldp12qweH1Pu1V0QRxPR3+BGAk=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=VT7dZth/97Px6KXztz4fyMyvMv88sXFx1Y888FUMytGrwDAPTBznHhj5WCbEcTTnF 4l1Y2Qvj/UZ5EsrSNllyXUKexXX03FEO8fGzCqb0q7NEmR/X11TovVcgVdFNs/u1FU jcoFr2bkLMnSOHX9BkEL0yJmhp00SYerWL17rpVY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181003132430eucas1p1a800995ae9e6e739e7a613098cbf333a~aHA5Kkxoj1728217282eucas1p1S; Wed, 3 Oct 2018 13:24:30 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 28.00.04294.D03C4BB5; Wed, 3 Oct 2018 14:24:30 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181003132429eucas1p195b034c06ad265826eee360abc775cd8~aHA4HDRm11505315053eucas1p1U; Wed, 3 Oct 2018 13:24:29 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181003132428eusmtrp24ea51bc0669617761cfd6486687026ce~aHA31zf1N3069330693eusmtrp2L; Wed, 3 Oct 2018 13:24:28 +0000 (GMT) X-AuditID: cbfec7f4-84fff700000010c6-9a-5bb4c30d9425 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id B7.F9.04128.C03C4BB5; Wed, 3 Oct 2018 14:24:28 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181003132428eusmtip22d81f9d0c47c5bcf076a3f9261018984~aHA2-8kOM3072830728eusmtip2x; Wed, 3 Oct 2018 13:24:28 +0000 (GMT) To: Maxime Coquelin , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, jfreimann@redhat.com, nicknickolaev@gmail.com, bruce.richardson@intel.com, alejandro.lucero@netronome.com Cc: dgilbert@redhat.com, stable@dpdk.org From: Ilya Maximets Date: Wed, 3 Oct 2018 16:26:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181002093651.24795-3-maxime.coquelin@redhat.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA01SfSyUcRzf73meu+dxOR5H+U5v6+aPMiHT9syal6Z2lj9aK1O3VSfPMA67 81qrkMnLvGSVuVSsnYuUynkXOm9DQ6IobzW9UBiOpuzkPCz/fb6fl+/L9qVwUTPPhgoOi2QV YbJQMV9AVLYtdx80a9ZKnQpLMaZ7vghjBkvcmZn5KozJqBwlmf6byyTTXaommLbUeoLpKnxP MIaUFZKpiF/FmPK3OZjHNsmfAjVPUqMaISWP6icxSW76Z1wy2zDAl2RqS9BJ/jnBkQA2NDia VTi6XRQEDQ2ZRzw0jX2WXoXHowxBGjKhgHaByalhIg0JKBH9GEFn8QjJFXoEqbdUhNElohcQ VOg8NxN5v/M3EhoEve8SeFwxh6CupAEZXZb0aWhZysGMghU9jKBf3cc3Cji9H8oGJtZNfNoe Op+0rGOCtoXsL/GYEW+n/aBlvHCdF9IW0JE3sb6GCe0BvZobONfHGhL1xTwO74Wq6XzcOAzo PhJWa7+TXDgaXjX94nF7e0HZQhLGYUuYateSHN4FqzUPN/jrMJY0ibhGKQhydYYNwR20P7vX AtTatANQVuvI0Z4wlvUUM9JAm8HgtAW3jxnkVObiHC2ElGQR57aFv681OIdtYGhmgcxGYtWW K1VbLlNtuUz1f24BIkqQNRullAeySucwNsZBKZMro8ICHS6Fy1+itdfqMrTrq1Htir8O0RQS mwqrC8ulIp4sWhkn1yGgcLGVkH6ulYqEAbK4y6wi/IIiKpRV6tBOihBbC4sevJCK6EBZJBvC shGsYlPFKBObeFSh/9Ga2RHbc2LR3v+MnZ8h0Vqd9DHBe1+dz1VvTeO13oqYCbVN6CnLiSrM 19nvSkJr4+1RzWr9jun8T67jd2bdvMvJFMu5jEGf5MWO5azEFv2HHqSuNhcJvqXnnQ2Rj987 etz3fJb07ptjhq8RS16xrsLe+y7NiU17nPzM0g637RYTyiDZITtcoZT9A+10DG5WAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t/xe7o8h7dEG1y+YWZx7tMyJosbq+wt 3n3azmTRu+0eu8WV9p/sFufWLGWxONa5h8Xi9MJrLBb/Ov6wW2xt+M9ksfniJCYHbo9fC5ay euycdZfdY/Gel0we07sfMnu833eVzaNvyyrGALYoPZui/NKSVIWM/OISW6VoQwsjPUNLCz0j E0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYybN/kL5vNUrOveztzA2MvVxcjJISFgIjHz+xyW LkYuDiGBpYwSlw4sZIJISEn8+HWBFcIWlvhzrYsNoug9o8T9Xz1gCWGBEIkj3yYxgSREBO4w SmyZdYYRJMEsoCGx/uoTRoiOk4wSjafug3WwCehInFp9BKyIV8BO4trJW2wgNouAisSERw1g q0UFIiRWL3/BClEjKHFy5hMWEJtTwEHiwvJmZogF6hJ/5l2CssUlmr6sZIWw5SW2v53DPIFR aBaS9llIWmYhaZmFpGUBI8sqRpHU0uLc9NxiI73ixNzi0rx0veT83E2MwEjdduznlh2MXe+C DzEKcDAq8fAmzN8cLcSaWFZcmXuIUYKDWUmEV2DDlmgh3pTEyqrUovz4otKc1OJDjKZAz01k lhJNzgcmkbySeENTQ3MLS0NzY3NjMwslcd7zBpVRQgLpiSWp2ampBalFMH1MHJxSDYzFbxia jiQK3ZaQneDNel5icUvnuZlTDojbc3CJfwuVcfz5yOe7rnLpLesNUpmau2xsVW6pNSQZc2yr Sc4tvByXVV8p8/CqWUNMSqtl5T/x8JUTpj/RO6QrWV51wD9P73m5wqHcfULP5l1jbp284/ei t1mrXgo3fxfWD7ome/Rlyqud9xQr+5RYijMSDbWYi4oTASqjd7jqAgAA Message-Id: <20181003132429eucas1p195b034c06ad265826eee360abc775cd8~aHA4HDRm11505315053eucas1p1U@eucas1p1.samsung.com> X-CMS-MailID: 20181003132429eucas1p195b034c06ad265826eee360abc775cd8 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181002093714epcas1p2152f47240f9d18bea5f3da7b695b5037 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181002093714epcas1p2152f47240f9d18bea5f3da7b695b5037 References: <20181002093651.24795-1-maxime.coquelin@redhat.com> <20181002093651.24795-3-maxime.coquelin@redhat.com> Subject: Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 13:24:32 -0000 On 02.10.2018 12:36, Maxime Coquelin wrote: > VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE > and VHOST_USER_SET_LOG_BASE require replies, so their handlers > should return VH_RESULT_REPLY, not VH_RESULT_OK. > > Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature") > > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c > index 060b41893..ce0ac0098 100644 > --- a/lib/librte_vhost/vhost_user.c > +++ b/lib/librte_vhost/vhost_user.c > @@ -1161,7 +1161,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev, > > msg->size = sizeof(msg->payload.state); > > - return VH_RESULT_OK; > + return VH_RESULT_REPLY; > } > > /* > @@ -1218,7 +1218,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev, > msg->payload.u64 = protocol_features; > msg->size = sizeof(msg->payload.u64); > > - return VH_RESULT_OK; > + return VH_RESULT_REPLY; > } > > static int > @@ -1298,7 +1298,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg) > > msg->size = sizeof(msg->payload.u64); Maybe we need to set size to zero? This message should not have "Slave payload" according to docs and QEMU does not check it. > > - return VH_RESULT_OK; > + return VH_RESULT_REPLY; > } > > static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused, >