Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour forwarding mode

[Jens Freimann <jfreimann@redhat.com>]

On Tue, Oct 02, 2018 at 11:20:14AM +0000, Iremonger, Bernard wrote:
>Hi Jens,
>
>> -----Original Message-----
>> From: Jens Freimann [mailto:jfreimann@redhat.com]
>> Sent: Tuesday, October 2, 2018 8:44 AM
>> To: dev@dpdk.org
>> Cc: ailan@redhat.com; jan.scheurich@ericsson.com; Richardson, Bruce
>> <bruce.richardson@intel.com>; thomas@monjalon.net;
>> maxime.coquelin@redhat.com; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> Iremonger, Bernard <bernard.iremonger@intel.com>; ktraynor@redhat.com
>> Subject: [PATCH v8] app/testpmd: add noisy neighbour forwarding mode
>>
><snip>
>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>> 9220e1c1b..97e0dfa49 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>
>The usage() function needs to be updated with the  noisy information after line 192.

Added in v9.

>
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index 3a73000a6..99a005a0c 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>
><snip>
>> -Example::
>> +* ``noisy``: Noisy neighbour simulation.
>> +  Simulate more realistic behavior of a guest machine engaged in
>> +receiving
>> +  and sending packets performing Virtual Network Function (VNF).
>>
>> +Example::
>A line has been deleted after the above line, it should be restored to correct the formatting in the html output

Also restored in v9. Thanks for the review!

regards,
Jens