From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jfreimann@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id D566D1B183
 for <dev@dpdk.org>; Wed,  3 Oct 2018 20:52:08 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com
 [10.5.11.16])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id CA66983F3D;
 Wed,  3 Oct 2018 18:52:07 +0000 (UTC)
Received: from localhost (ovpn-116-20.ams2.redhat.com [10.36.116.20])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 4045369F02;
 Wed,  3 Oct 2018 18:52:04 +0000 (UTC)
Date: Wed, 3 Oct 2018 20:52:01 +0200
From: Jens Freimann <jfreimann@redhat.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "ailan@redhat.com" <ailan@redhat.com>,
 "jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "ktraynor@redhat.com" <ktraynor@redhat.com>
Message-ID: <20181003185201.syu2o7ptvqzigqwn@jenstp.localdomain>
References: <20181002074419.24164-1-jfreimann@redhat.com>
 <8CEF83825BEC744B83065625E567D7C260D0B7ED@IRSMSX107.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D0B7ED@IRSMSX107.ger.corp.intel.com>
User-Agent: NeoMutt/20180716
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Wed, 03 Oct 2018 18:52:08 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: add noisy neighbour
 forwarding mode
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Oct 2018 18:52:09 -0000

On Tue, Oct 02, 2018 at 11:20:14AM +0000, Iremonger, Bernard wrote:
>Hi Jens,
>
>> -----Original Message-----
>> From: Jens Freimann [mailto:jfreimann@redhat.com]
>> Sent: Tuesday, October 2, 2018 8:44 AM
>> To: dev@dpdk.org
>> Cc: ailan@redhat.com; jan.scheurich@ericsson.com; Richardson, Bruce
>> <bruce.richardson@intel.com>; thomas@monjalon.net;
>> maxime.coquelin@redhat.com; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> Iremonger, Bernard <bernard.iremonger@intel.com>; ktraynor@redhat.com
>> Subject: [PATCH v8] app/testpmd: add noisy neighbour forwarding mode
>>
><snip>
>
>> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>> 9220e1c1b..97e0dfa49 100644
>> --- a/app/test-pmd/parameters.c
>> +++ b/app/test-pmd/parameters.c
>
>The usage() function needs to be updated with the  noisy information after line 192.

Added in v9.

>
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index 3a73000a6..99a005a0c 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>
><snip>
>> -Example::
>> +* ``noisy``: Noisy neighbour simulation.
>> +  Simulate more realistic behavior of a guest machine engaged in
>> +receiving
>> +  and sending packets performing Virtual Network Function (VNF).
>>
>> +Example::
>A line has been deleted after the above line, it should be restored to correct the formatting in the html output

Also restored in v9. Thanks for the review!

regards,
Jens