From: Ilya Maximets <i.maximets@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, nicknickolaev@gmail.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies
Date: Thu, 4 Oct 2018 08:49:15 +0300 [thread overview]
Message-ID: <20181004054656eucas1p252be07faa7dab41e09c7133e223f4f6c~aUarRVz0w2351423514eucas1p2B@eucas1p2.samsung.com> (raw)
In-Reply-To: <9ab6a638-f89d-5509-fd99-7d4be219aa04@redhat.com>
On 03.10.2018 17:49, Maxime Coquelin wrote:
>
>
> On 10/03/2018 03:26 PM, Ilya Maximets wrote:
>> On 02.10.2018 12:36, Maxime Coquelin wrote:
>>> VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE
>>> and VHOST_USER_SET_LOG_BASE require replies, so their handlers
>>> should return VH_RESULT_REPLY, not VH_RESULT_OK.
>>>
>>> Fixes: 2cfbbb86c62a ("vhost: unify message handling function signature")
>>>
>>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>> ---
>>> lib/librte_vhost/vhost_user.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
>>> index 060b41893..ce0ac0098 100644
>>> --- a/lib/librte_vhost/vhost_user.c
>>> +++ b/lib/librte_vhost/vhost_user.c
>>> @@ -1161,7 +1161,7 @@ vhost_user_get_vring_base(struct virtio_net **pdev,
>>> msg->size = sizeof(msg->payload.state);
>>> - return VH_RESULT_OK;
>>> + return VH_RESULT_REPLY;
>>> }
>>> /*
>>> @@ -1218,7 +1218,7 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,
>>> msg->payload.u64 = protocol_features;
>>> msg->size = sizeof(msg->payload.u64);
>>> - return VH_RESULT_OK;
>>> + return VH_RESULT_REPLY;
>>> }
>>> static int
>>> @@ -1298,7 +1298,7 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg)
>>> msg->size = sizeof(msg->payload.u64);
>>
>> Maybe we need to set size to zero? This message should not have
>> "Slave payload" according to docs and QEMU does not check it.
>
> I agree with the fix, but it's here since the beginning, not related to
> this series. I will add it at the beginning of the series though.
OK.
>
> I think the spec could also be updated, to clarify what payload is
> expected when VHOST_USER_PROTOCOL_F_LOG_SHMFD is negotiated.
Yeah. There was an attempt few years ago, but it wasn't merged because of
code changes, I guess:
https://lists.gnu.org/archive/html/qemu-devel/2015-11/msg03526.html
>
>>
>>> - return VH_RESULT_OK;
>>> + return VH_RESULT_REPLY;
>>> }
>>> static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,
>>>
next prev parent reply other threads:[~2018-10-04 5:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 9:36 [dpdk-dev] [PATCH v2 00/17] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 01/17] vhost: fix messages error checks Maxime Coquelin
2018-10-02 14:15 ` Ilya Maximets
2018-10-03 7:50 ` Maxime Coquelin
2018-10-03 7:57 ` Ilya Maximets
2018-10-03 8:02 ` Maxime Coquelin
2018-10-03 8:32 ` Ilya Maximets
2018-10-03 9:07 ` Ilya Maximets
2018-10-03 14:39 ` Maxime Coquelin
2018-10-04 5:42 ` Ilya Maximets
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 02/17] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-03 13:26 ` Ilya Maximets
2018-10-03 14:49 ` Maxime Coquelin
2018-10-04 5:49 ` Ilya Maximets [this message]
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 03/17] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 04/17] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 05/17] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 06/17] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 07/17] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 08/17] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 09/17] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 10/17] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-02 14:11 ` Ilya Maximets
2018-10-03 7:46 ` Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 11/17] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 12/17] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 13/17] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 14/17] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-02 14:18 ` Ilya Maximets
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 15/17] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 16/17] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-02 9:36 ` [dpdk-dev] [PATCH v2 17/17] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181004054656eucas1p252be07faa7dab41e09c7133e223f4f6c~aUarRVz0w2351423514eucas1p2B@eucas1p2.samsung.com' \
--to=i.maximets@samsung.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).