From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0074.outbound.protection.outlook.com [104.47.32.74]) by dpdk.org (Postfix) with ESMTP id 0E59A4C9F for ; Thu, 4 Oct 2018 16:17:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MjiZ099syulkEXVEJnlERKZKxAmM61crcEyD3G3BTTE=; b=mga6PMCCao7STd3wl514JJUBFk4/fqfZqRWNAnoICblRmoOK7+OsgfdhYxxHb7w32kbjd7g0pgkxITjQR/yA609uDV6cBK9FYjtzwE7kPPWW61CwDRlgo5q5UB/b8EvwxA37Eye2KyQ1G0CQIf97uIA3G8ifMUHTBUFVOFTwlOc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.57.251) by SN6PR07MB5005.namprd07.prod.outlook.com (2603:10b6:805:ac::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.22; Thu, 4 Oct 2018 14:16:59 +0000 Date: Thu, 4 Oct 2018 19:46:49 +0530 From: Jerin Jacob To: "Iremonger, Bernard" Cc: "Lu, Wenzhuo" , "Wu, Jingjing" , "dev@dpdk.org" , "shahafs@mellanox.com" Message-ID: <20181004141647.GA10128@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-1-jerin.jacob@caviumnetworks.com> <20181003181657.32236-4-jerin.jacob@caviumnetworks.com> <8CEF83825BEC744B83065625E567D7C260D0C9DE@IRSMSX107.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D0C9DE@IRSMSX107.ger.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [106.201.57.251] X-ClientProxiedBy: SG2PR02CA0026.apcprd02.prod.outlook.com (2603:1096:3:18::14) To SN6PR07MB5005.namprd07.prod.outlook.com (2603:10b6:805:ac::31) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f37cc77-ba02-4082-8fa6-08d62a040db5 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5005; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 3:3/e86OHSuWaolKBQdh5OOjxQEHLK0cRT6ORwPB1dvNKxPCZno9VKwkm/rm2IJeXqhs+/8I0fbaU3k+pDl8IAFPaYg+0Bh52U6+MoY9jJW0s8OtCS/+eDDloUDrUdayEMkf6nqWkrXZdTvJoBYQVxpyR3c8vfTz/KzEYQPArD+OBsuuUFXBtEdYca0e93YFS1WUPEU+/AVdmYxruOgkCa2AkAWT4p792J8SE5BeMr5HkYF7iXDmgNJGy43w6Yij8k; 25:wsvOWh2i5S4lZrqrsuq20JZOOWMjnf1Kvop3WIv2/hEwJjrNGCbgc0OQlgFeRhhREUzTziUPYMZSzisR9e760stBVKGaGaXNkjwJ+DTCzaoVFyRvTwrfdhNlWI9gopw4OvCQkRXg8SyKOh/sJkMgYmq19UGcFB/fVuzDb2o1IY4QQwnI2h2k8QPdjTb7zo7pVWl5LIx92cLLlkGc7W6rcpBcyWvs+5hVMKRoY67KyZDMKqfIYWZuAn35osrIaBxEPsOMM68HDWEgRFk+Nre3uzKYok0BO7X/yuGjapqfPM597zjnimAkZjmeGLosJrJ8K0IXmxlTew0sbGtytRJHSg==; 31:3tFxtEJqFNczRPnT4csOqxveBbAITY7jo115I6tE5BlPkJpPbHbfM0vjHZK5p2x54GMUTszBayagUD73M7q11/cwO0EvaIlgZRvxuu2KpP7ksGsoCd+rWuNFn3lQtNUMmJ6DB6fiZiFKAlRub1f7xV4NmvU2NRPFZMbna5R/qX/cA29MWwqFgQoTvwDQxppRHhU9zhjdQe4Xe+HE5C6tFAezFutegcZP3pBFbEVft1k= X-MS-TrafficTypeDiagnostic: SN6PR07MB5005: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 20:jIZfNnDZUR74O2GqvTCoTsHjGYpOMyeYf8Be5HCHbU2+ubMncjcdVXaXsRuR+aPHBroUIxtEerxkkzZ0gcss0d1Wxr20X3izqmUR1OZLQH/z17PEFe4B1Hk36e7do+zyGB4OCO3iU3qFGoRzj/VZvCIduWZa1y2CH0gJNejKSWJFl5igBLThVWKPJSdoEQ3lVxZMTWe0RlRZUxzLtac+9e+0gcNykqPmsuCmCYf2d7JHytC7gmVt0KXm0l3PWzCKILUuId1YqY84/fqyTlaqaLlhg3pfT4Wo3gI1B/9J6BFZ5+tIlzA7O+OU88Yzmu8CyPOTs4fktY9T0LPPUw4GwtYlCMbwbxhOHFzL1vUVqMJfFb2ZKaqjf4MgCN1cO4Kijqbj63FaPw5988pBZv/JSZjmhmYF2KQkeDj/oVEIz7Ldl/JrtP+qNXX45/JN1I3aoTSowpBac5xAoJAdaalXhBDerSJjzaVVQM3zIYzUTB7Use6K4R/4LjUBHrvm5P8TfG/5RYw1P14wJYRHlWDCDiRhhh5vPMbGnr0btrHerBoBn+AjSICf2qKhKwyj3FoW4yX9fGG1x/Sc8yvltNIdDzuPlSl9BT+5d2zqq7/mdM4=; 4:qEL1mj1XN0B1c2Vp8Fd6fgkbF4VgTbZW5sKkUm3ehGErV5WwmtRoDCItQKN847sqIAHM2VVEBontnrPVGlCnWF7rCNd0luisU3C8Us6Zdq7pXOmhy3rm+S/ZffDk3nmGblx+Nxa6Dfbg7fgvJztCPDcmtdNEHJyiXttVkD7e/jBarM4JgY4LhEfYTUf0I+iolWvTkWPjQlhnsi4aInTgBwpB/0oMiOX7/v4ICg6xKKHT2MD4OUyKmlDZzExW8ria5vgjLzGNfr5HcJzwKNR4JS8MX97ckzKD9LZYugGEuaGI8XQt3PRfFaUc9TAA2GMy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(10201501046)(93006095)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:SN6PR07MB5005; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5005; X-Forefront-PRVS: 0815F8251E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39860400002)(136003)(376002)(346002)(189003)(199004)(13464003)(1076002)(55236004)(476003)(72206003)(446003)(11346002)(956004)(44832011)(16586007)(54906003)(106356001)(7736002)(97736004)(14444005)(305945005)(5660300001)(2906002)(486006)(58126008)(33716001)(6916009)(6666003)(105586002)(25786009)(16526019)(6246003)(53546011)(186003)(26005)(42882007)(6116002)(3846002)(23726003)(8936002)(5009440100003)(53936002)(66066001)(4326008)(33656002)(55016002)(9686003)(33896004)(478600001)(93886005)(76176011)(6496006)(229853002)(52116002)(47776003)(50466002)(386003)(81166006)(8676002)(81156014)(68736007)(316002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5005; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5005; 23:nsTlrO9WwKUle5iqT5zX4mWkXtSLUCQUTJHL2XUjv?= =?us-ascii?Q?IMrBLotoMrZ+LBf69i+pc++yx8UsmPSl8WnhNtusiGNstMMjg9UWjoJZtwvR?= =?us-ascii?Q?gI4ryvVO5A+Ar/OWzAldWo8z2iHxFpYsc2mbotkQqH34cXcwVCLX1qP8nqZ2?= =?us-ascii?Q?woBntCaYx3nQbdoxPft/VdFyEjOmyRdkYfbHPbOMiDJdhXhj1bvDCBXtzFdB?= =?us-ascii?Q?OeAxN7IKDQW8W3MoKtz/xguVOQJHyo5q+h1wsWXy7ZqYvERktLfHbuTugMoO?= =?us-ascii?Q?lCdCX9G9Z9SiWC/cz8+/6YX57kOMS2yVRGftBxlJ+c12Ed+1TvXhk1WRUjyv?= =?us-ascii?Q?BxAf6JGvZ7uDFKJLo0wBj0r4sRMD16hQTIxgf9UkXt1XmnA7GfVlUEw3khFa?= =?us-ascii?Q?sy07mNEXId69GxuLAxEBfive2dCCRyftfqYTLSXpmHWjIV2qjPX6GHDulQRl?= =?us-ascii?Q?jK1ZUXCEOA+CBOfjK2Ni2LV4/Jvh+pnbaSodDlJwHUKkDMNUFXj2cyO/05ol?= =?us-ascii?Q?EDP6L4s0CFl85mpO3Oc3j7ypMgwoxGgp25GdR78UUMSqle1NT3NpAXudI1Yi?= =?us-ascii?Q?JWUnCVgy2QtpFuAsIxO/NBl0nA4lz1hDEDLDxzoEvE6oGnkEBlkbo863PUMu?= =?us-ascii?Q?tKJ3BiyI4IdtUOstF+Ta8TzCHoeDEj+ilsjMcY4zxAaxNKmzG98kDCXowzSQ?= =?us-ascii?Q?D0CIT3P44/7HUmDrIR2qbwsdU0uD1WJgbArwljauLEh/z1hmVPdhi1fO0r0/?= =?us-ascii?Q?wxRZdxcO0it9X+vKXaTFhIEnkU0tZWVW2WN2NI7x61ncvxgIp6hIFaHM9UQg?= =?us-ascii?Q?r9LfFJVLVTXhtLyMRs0VRzo1rQqa3tr9Idmy0RYYETvPcYI2QN6ckJyA0ke0?= =?us-ascii?Q?dGFNw7NGnYFm6ikQpzO2jpjcCWRXQUYxm2pXTVC67SGV+RVRmkZZKC5ONbUa?= =?us-ascii?Q?aKkvOrl2I7rkKY1vAC9h7/1e/p/O4Ubv6MBmSBIrnLVhClioVC0wXuzsOzmT?= =?us-ascii?Q?NCeU1v965JcIRATo9MKnZa6Ku1FNdr+tl8K55NqgJhL4Lg8JCa9UfOSg07sr?= =?us-ascii?Q?gqvgNeSFYs8nqnYV5uBnl9wBcPnebBYYV/RfhaaRdtrCkmhQpjo30hcwk0fi?= =?us-ascii?Q?Te3xaD0Ga/Ggy4tlYZSuBGwEAc4xwjy+NSnKoWihjl0lngtTV1jMXhZUlXWe?= =?us-ascii?Q?7713jw/hdx6LHu519Jd1F42AESdj48h7T7Xjxr5uf2Kk+TktdrPlXitaa5mC?= =?us-ascii?Q?SnZzsvxxyNtshT/SdENJJWUiFLld1Fsj3P8zdsbncBPMSgKcWbW51xkVNzug?= =?us-ascii?Q?JbkuNL1gj+tOFYm3JSwi6TH7ePk/4jX5U89cRMZy55q8zlV9q44/7+n7CaNd?= =?us-ascii?Q?JDqKe17m9qZ3FY1RxkgCWeaw0m60YiS9wIi3LoOa9HiBNAaPuPGTwQkGOqmC?= =?us-ascii?Q?kbggg+EKAl4YVWSVAQ7UMpE+ITxm1cfey1APvM6g+mATfplH2Tm?= X-Microsoft-Antispam-Message-Info: DVxP1H+eIZPetsgleG2uFFkQ+pFj00Edf9zoCMGddePsm3PABsdx0LyUj2NjR6BexfjR3UMPL+8GwTKV7F4Q4dRrZG2t+dVTKc2Ll/fCZdE2kKqW32OqKY5r7lHSKupGnv+R79I2K4phgAWNrtpNPA7+l9fdbwVJgIn5YKBmki4ZI5rKvlh1cgFww1Tsp3QU/iWN5YX0eukmidHnfjmYCKBMatzFyGBKF7cHRFfLWWM/grD9X6Cj36rNNAxALCLOHIbyqjLv8YGzNsnu4fy+m4a5kR8vxUM2hR23PpXsDv7GrrlL8A13G7N7INhdOOe7lGJK0JzmCQdAM38PYvsiPQCUbEQS/g6oQulwqysYfoA= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5005; 6:Wdezj1Lr05wm5iACD164beIqHXC2Va2iztB6uuw5G+X44uT0JDKbYyh1FmEIUYquRwmB1j7DEMllQ5ZUZ+Dl2nfWDCLoNy58K84s06WVM6ot9daqoFGu6m7wCCvNs/WTd3WBQZOPSLsbaaabacz0X4wnApe9DhqoyndzmcNLEDuliPjuL/rnMZ3OOG0RkGkCMyQMDrUstdbl8rfL2XAXDFheAqZ5IfVNFxUwvUISz7OlYwlk9Fj+KAA9xsowaoyBIUEROYuZqCCPj/Ta9PNxfMT4SPLXKgzKVboQrHRqauDHmKSxMgzwUi16r05PprRYiw3cAZNpqyT1CTVdlK6tFb3EcnG473JZEjplPcBsmCmujuS+0CaXhQwTzvuBh1EuAz2NGy+VvX6IgiSjQiMPB/NS+f7KGPxIiI8HGQhP1ZmCk0IUtnKLenzIuOZ3E7dUIo9+Xb5AnvEQ63uIOBW2gg==; 5:k+zTHC3P/ItjbHk64bqNxYbMmlGtZ2N0G7HaOzaIOn/nC6RppaPXS4AsPnog+YSd/kpQb/8xIKx4hN8fZcVGk7Aisjt08odgyROMN0hamSEwpL4/ECUoU3e/COKZRjJQ6XMDyHUSqmvzP8r3DKzP19pAoIIIPz3QTF0ng0bYlXM=; 7:vNZ3ugrIcbfhTYPZVrYNrkyE+GCBp3lWH0FSceCX354yzsRh+w5NkhrgrIW+xs2kVpO75Al7FPgNg+tOG/upMb0xZkQmPH/+Hbl/I6BlsKtQGljaPC4S32hnp6R3LISPRaAdSRDz2bLPyUpz71koA7ZWgO8IYs7m+zsDHtYVNgtiLvnfZ+3wF1BNUeylB311Jme+4OROrBZ/rWklGyqIBZz67WfasSZTmMHl0bq/eMTI9I6P702yspsJYPgeGBAF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2018 14:16:59.7117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f37cc77-ba02-4082-8fa6-08d62a040db5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5005 Subject: Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 14:17:04 -0000 -----Original Message----- > Date: Thu, 4 Oct 2018 13:45:42 +0000 > From: "Iremonger, Bernard" > To: Jerin Jacob , "Lu, Wenzhuo" > , "Wu, Jingjing" > CC: "dev@dpdk.org" , "shahafs@mellanox.com" > > Subject: RE: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > checksum for csum engine > > Hi Jerin, Hi Iremonger, > > > -----Original Message----- > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Sent: Wednesday, October 3, 2018 7:17 PM > > To: Lu, Wenzhuo ; Wu, Jingjing > > ; Iremonger, Bernard > > > > Cc: dev@dpdk.org; shahafs@mellanox.com; Jerin Jacob > > > > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > > checksum for csum engine > > > > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. > > > > Signed-off-by: Jerin Jacob > > Reviewed-by: Andrew Rybchenko > > --- > > > > The following checkpatch warnings should probably be fixed > > WARNING:LONG_LINE: line over 80 characters > #86: FILE: app/test-pmd/testpmd.c:1043: > + printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n", > > WARNING:LONG_LINE: line over 80 characters > #98: FILE: app/test-pmd/testpmd.c:1063: > + printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"PRIu64" Bad-outer-l4csum: %-14"PRIu64"\n", > AFAIK, printf's string can be >80 to allow string strip