From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680074.outbound.protection.outlook.com [40.107.68.74]) by dpdk.org (Postfix) with ESMTP id 87E3B375B; Fri, 5 Oct 2018 09:06:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UmizzTD9mEySgxUU2iJwGNFvTe0pz9sN8A3gWNAuypc=; b=JtSHMhGzi8FmpJq5o+PA4UhLXfI0piHcV0QjsS64hT3bgV8VH25pCE5dw5XmZ4/y2B14aZwW1q4KOQDw9cEQ5aHX2j335mr94O1SAova/0IAJJqg/5B6QuQ9mYGxbW6iTpA3r4uZJHvSPIeP8UHlMn9iEoc51wDRE8CgW4q14nE= Received: from BYAPR07MB4997.namprd07.prod.outlook.com (52.135.238.214) by BYAPR07MB5654.namprd07.prod.outlook.com (20.177.231.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1185.20; Fri, 5 Oct 2018 07:06:15 +0000 Received: from BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a]) by BYAPR07MB4997.namprd07.prod.outlook.com ([fe80::c5c:4d86:b353:175a%4]) with mapi id 15.20.1207.024; Fri, 5 Oct 2018 07:06:15 +0000 From: Jerin Jacob To: Andrew Rybchenko CC: John McNamara , Marko Kovacevic , "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "olivier.matz@6wind.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite Thread-Index: AQHUXGZyt/XALDcMrkajWzSoKSDhg6UQNP6AgAAF+4A= Date: Fri, 5 Oct 2018 07:06:15 +0000 Message-ID: <20181005070605.GA6990@jerin> References: <20181005044606.27026-1-jerin.jacob@caviumnetworks.com> <8c49c8fe-db03-8d2c-bce0-eb6998544f30@solarflare.com> In-Reply-To: <8c49c8fe-db03-8d2c-bce0-eb6998544f30@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [111.93.218.67] x-clientproxiedby: BYAPR04CA0029.namprd04.prod.outlook.com (2603:10b6:a03:40::42) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB5654; 6:62jreRuAqcD6s5hkZKasSuCRsx/ehN5tnYsurnnLsmDSlTBIAzraKA1qsGXv4ZH6lHJsvm61GCGOvsFZUliqWTl9Eb4G7xiqBew2i3JtnNlhBRUHobr2UeZUDrheIgD3aZ5aiz4BM+h7AIsXeHBosI7shajIGvWkZ5DBXE5rnLdIruZXS0MPfzLsl3sn5eI5LYwe4m8qLlN7xqi6yRFvnSkIPgQ/8fwhMYQMD2YDTrMqPJZqk13346loSXMFsy7LfJSmtKMJp4/niw/KhHQbY+6ccng/MS45VyvevOQhFwtmmsUjpCgrEnv5Th7nntuk4Klj/1yZjJx2mjAQNfLrXP997wIBl2CzBG1VyMbCDZIGNQIIv/hw8FTcpJ9zjk1YM9faHr/r2OGIqsDWJdSbhUVX9RPa9lJn3N0TUK6DbiLMOKJl/tDltAYR2qnWh+kDNAOjlRgEdxkwyXFpAYj7Bg==; 5:vC7mY04yF5NbmVkvsRkzykM4xVSRcw1ED/5GjaK/iLM3PZv7cxHNGPwevYVt/V46sM8fLoqPx5G/dWY0A/Kjcd6oLcN2xvKxirJNpS7H3ufJEH4vhcRdTMzfTnn+Zq0k5xh/6qIGUv0V4dXQ5nByjgaxnXxg9gwhegECzmXyivo=; 7:v7fML8cFQbcWwvJxCr8p/fkKFn83/LcdZKfiCdGx5/TGv0oARImSApFN6Z8HNiCNYTbrEjpFtt27xy03Jd6sUiB1PUhM88tBUTjDa10vBwQrRPR9u9bSRU6hIxRli5r2AjA/j7oy2dYWsZfNpjaOt7kwuR1yS6e9G5+Et/uklKOQMWkdyh6CbX1C7fh6rOBpjudUBBGPMTcHLHkzRivzaGE4gp3ftGVSkmp/cfzaNQRasg2HgQRhmVpRT2pTvf5H x-ms-office365-filtering-correlation-id: 5d41ebf1-eea0-49d1-9668-08d62a910a09 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB5654; x-ms-traffictypediagnostic: BYAPR07MB5654: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991048); SRVR:BYAPR07MB5654; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5654; x-forefront-prvs: 0816F1D86E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916004)(136003)(39860400002)(346002)(396003)(366004)(376002)(13464003)(199004)(189003)(71190400001)(26005)(14454004)(1076002)(486006)(6506007)(54906003)(446003)(53546011)(53936002)(52116002)(3846002)(2906002)(81166006)(6306002)(386003)(229853002)(76176011)(478600001)(316002)(6116002)(33896004)(6436002)(81156014)(186003)(71200400001)(9686003)(102836004)(6916009)(2900100001)(305945005)(6486002)(6512007)(8676002)(5660300001)(14444005)(256004)(105586002)(42882007)(66066001)(5250100002)(33656002)(4326008)(106356001)(7736002)(8936002)(72206003)(97736004)(11346002)(68736007)(33716001)(6246003)(99286004)(966005)(25786009)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5654; H:BYAPR07MB4997.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: XlVUGNUsYbRVGDzXv4vvAwbYo0THB9bI4tJwBjnL454MmvQnfL40KtfobDLKZxvDSgkoJXD+FiskKfP46UAQG2EViDz9/ToTASENWaY8tP6kwAEpSqBZUMOh55Fod8I38nrXEqabchHaQxxP+qtjUbYkbfFbvCUyHxIQsvW1YCt0Btmy9i/5tnad0CEQZb54AHDlwytKjyiKkNZho02h9ycAooo3tV7R+7TIaMQDk7XvfX/QQgPAo3nv3vMK2xn+kQtXakBGo7Hh/neA5KJGAC789/9rpc3GnfC/CWFxTPRxhXmMQruamDA5fei735KQ/mwU98neO1rHUt+HZ1hlgbXpWHN1etj/wtBHBlj3qOU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d41ebf1-eea0-49d1-9668-08d62a910a09 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2018 07:06:15.4028 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5654 Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 07:06:20 -0000 -----Original Message----- > Date: Fri, 5 Oct 2018 09:44:43 +0300 > From: Andrew Rybchenko > To: Jerin Jacob , John McNamara > , Marko Kovacevic > CC: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@intel.com, > olivier.matz@6wind.com, stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequis= ite > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 > Thunderbird/60.0 >=20 > External Email >=20 > On 10/5/18 7:46 AM, Jerin Jacob wrote: >=20 > Based on PKT_TX_IP_CKSUM definition the user needs > to fill l2_len and l3_len mbuf fields before issuing > HW Tx checksum request. >=20 > Fixes: dad1ec72a377 ("doc: document NIC features") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jerin Jacob >=20 > Acked-by: Andrew Rybchenko >=20 > plus one question below >=20 >=20 > --- >=20 > See PKT_TX_IP_CKSUM at > https://git.dpdk.org/dpdk/tree/lib/librte_mbuf/rte_mbuf.h#n283 >=20 > --- > doc/guides/nics/features.rst | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst > index b085bda86..e726a6bb8 100644 > --- a/doc/guides/nics/features.rst > +++ b/doc/guides/nics/features.rst > @@ -562,6 +562,7 @@ Supports L3 checksum offload. > * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD= _IPV4_CKSUM``. > * **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_IP_CKSUM``, > ``mbuf.ol_flags:PKT_TX_IPV4`` | ``PKT_TX_IPV6``. >=20 > Shouldn't PKT_TX_IPV6 be removed above since L3 checksum offload is not a= pplicable for IPv6? I think, some HW(What I am aware of) need to provide following[1] info in T= x descriptors for checksum. IPV6 may be used by the HW in case, packet is tunneled to see where inner start etc(thought it has outer_l3_len)(not stri= ctly from outer checksum perspective) [1] - IPV4 - IPV4 with csum - IPV6 >=20 >=20 >=20 > +* **[uses] mbuf**: ``mbuf.l2_len``, ``mbuf.l3_len``. > * **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_IP_CKSUM_UNKNOWN`` | > ``PKT_RX_IP_CKSUM_BAD`` | ``PKT_RX_IP_CKSUM_GOOD`` | > ``PKT_RX_IP_CKSUM_NONE``. >=20 >=20