From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700063.outbound.protection.outlook.com [40.107.70.63]) by dpdk.org (Postfix) with ESMTP id 308323572 for ; Sat, 6 Oct 2018 10:16:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nEmz6yUQdePoVBSEfzNRkEUZp6lc3uepJqVVGRbC8pE=; b=AVh3YU2XVFFZUtI+t0PPypMHcF/pwV0x/c8NBoXGlckZqB4Xaat1lpsxgXg2eZFbsdKbaLXzr1XAlHvza08CQyCqZabT2IAbIPy/TT6IwTBPtukdjGHgkywrR2Xb6JxGf76++rSbeNii0NByUJUsWWGCfnivMS3xoSnj+o42x94= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.23; Sat, 6 Oct 2018 08:15:57 +0000 Date: Sat, 6 Oct 2018 13:45:38 +0530 From: Jerin Jacob To: Thomas Monjalon Cc: Ferruh Yigit , Andrew Rybchenko , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Olivier Matz , dev@dpdk.org, shahafs@mellanox.com, "Ananyev, Konstantin" , didier.pallard@6wind.com Message-ID: <20181006081537.GB21149@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181004055930.GA4406@jerin> <26087815.IDbtF1NTBH@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26087815.IDbtF1NTBH@xps> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: PN1PR0101CA0046.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:c::32) To BYAPR07MB4997.namprd07.prod.outlook.com (2603:10b6:a03:5b::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d8d4681-0c51-457f-f2dd-08d62b63f480 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4997; X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 3:QWaE/zmtC9ENh04gfOva7hUoq1YyOvkeTyle7Z5BTZn+/K+PWgBSI/OYbxR8XDRPm8fo7gkQZH6F9f/vN0lWYUJL9MtkAylILHp5XC2A3lhzFhLXlL+HEk2690J8+ovreOhAzb9n0Df/Q4RSqBWjv/9Wt/AGre5nEu7mOIyTg9Coj/LSV6nr20r1hdvc0nGFr/LLBZZrmSVWgHQpDRxt14lIIQ+tpIelpEh1JicSqUb+InWIeIchx/EDpsxsmkNv; 25:EYGoIGE8yzDvr+317iONxoZUaqep6F7tK7ju672bAgKP01T1Lc0D5LS1V5N23nqq58aX3sFwSqaxl4iRLDupP202oRuRISYbEGQ4NfSgQ3W4R46s0NsoG5zVPJzmEZ+bZDmnqaqDQa5MjBBg7AXJnFSXohJ9G5RfhGuwXJHzjwZ19s3FrnDbZ8c3eQU3rwhzZPxBPgTZfrQh8QBQZCik4gK8NCvWlpW8Wzhnrv0Aj8GpPGaMN8IoXxEjwHgRz3wK3zkk56OCMNU0MnRUnF7bs6mXElGrVo15GVgI9h0fk021Jo88bgWHGGBnuIJ+fVzEp0a+MEkkDeRirzsB6D5S7g==; 31:S6onFLZ6zB/ZGykSIj8/naq/5VDx7qGkHWOPnjT0/a/t0E2HomfMzJkg0k3mNzEkdK7inMMtdAqymKlCmTM4bC2c96zCe6ca3HlsqtSuOREgHHwDO6H1rB6M2xmQqrd36FPO+wxNofbR/Md82VqgdBrv1aY7Z7eVRSns7imgsBo9loLKzS9BQla1yQ7QJdSLHFW7QZ2vqfHK/ogB5M14U4Ft0RLX1lN9izNs3XvXn2o= X-MS-TrafficTypeDiagnostic: BYAPR07MB4997: X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 20:1D4V9uY1XXefel+YBFSGj4T9kHMw8iAgFT34Qh/BLJ6ITYEYKuldMP9WXgCQn58M2Bq1s7+xh8X3UIkkoKCV9qbNJmGsd0gUIZw4HBmkwAheHEAUc1d+cuLMZHIeUi0SLapKChl/iO6SSIJX5eNW1XasmdHJb8iNECKWk9hXGLVVZx73smZ8qGslo6TXizQjlGVfme+KdpzMWZ/+fnB17wGRc6+iTd23SQLwowzTjaXAFP+26FDOcBoUV7zGHpPf51wGvnzCeetwW95ySk+xp5rnKc3GtTYkRjuhuvo3bQOcEKqgZLmhoiogpqv6VchIzIHrRFYnwoVL//TA2iSumoX05igyPNeiJ8pMB+tuwoJ47JAOzDnRaoUSOgBvsZiumMEs5AxCFB2b64WH1imCCckBFdypGwe/ib7IqRzDlZ5JymYKBInSlM0ESjJqw97iDIHXp3VsHB6EDzqHjfxyP+dgYnf2aut1Tv03aOg4S6/9GfeIWn1pw7v7LpCQc7/zn2iXQQXMh88yqmkelofvmkAIijw8JqQeO9JAL8ABNGz6mzt9mXU8YDo0VgBmCx5q7/W6M1G/YhQuHUVe5nL89u6c5w1LL5yrSdf5iImqeeY=; 4:+xQAe8QiFmNl5JXjhndTUlSTTTKDh8BjMS6MzADH+Y0/AVTyQp3E3Xp6vRw11K8dTaCWyT8AHWuaZMiVlhsXc6U9xpEUyaR+Kl5HGwaJdc78Q5Ink8sR8oq4GsaP/AP95fOZdca9SmVkfWtiLDNTsdtZQ61Kc1xSNXdoaUb44c1JYPZwwf7ScYk+YlKWLXoJpKYKqnzNlS3RLm4cxxU+OGMbz4gXKB3V8aP8j2jyHblSM7BU2rvaz1gYLNCrOBXnk8syioZ71ucxYFQfueSJpCAa4QBbL6hyIBHquG2pXJ/9gvOrAylx5BLAozauVevn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231355)(944501410)(52105095)(10201501046)(3002001)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(201708071742011)(7699051); SRVR:BYAPR07MB4997; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4997; X-Forefront-PRVS: 0817737FD1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39850400004)(396003)(366004)(346002)(136003)(13464003)(57704003)(199004)(189003)(53936002)(316002)(50466002)(81166006)(81156014)(6496006)(8676002)(76176011)(33896004)(2906002)(44832011)(55016002)(33656002)(106356001)(305945005)(105586002)(7736002)(9686003)(16586007)(3846002)(478600001)(6116002)(23726003)(72206003)(1076002)(66066001)(6666003)(47776003)(52116002)(33716001)(7416002)(6246003)(14444005)(229853002)(25786009)(476003)(26005)(16526019)(186003)(6916009)(55236004)(956004)(53546011)(11346002)(446003)(42882007)(386003)(93886005)(4326008)(54906003)(97736004)(8936002)(5660300001)(68736007)(486006)(58126008)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4997; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR07MB4997; 23:Yo4bNGrqE7tL9EjDjDH0W0dcm/TWuwE/BghjvyKVI?= =?us-ascii?Q?UZPiKMauqX9/EJTGWEsVONkZlWtkJLOi8+tyiclMVZzvkwVgh3I+XwIWFXHz?= =?us-ascii?Q?qCxfOYuWZu+YQTKXnRtfF6191q+XTivP8XXeU9mKhZN8tFcM5HphgdOL0yL6?= =?us-ascii?Q?KrycCT0gYmVv2aGWu6ZhKwLmoCbV9FJqwzelFpC0JDNESbj6AlOSExQ/DYbE?= =?us-ascii?Q?YTheoA4jRV+C+A6RxZfgzBCatGkQ/IPfo6p3BhCWDbmUt5/VWYCweZhudOBu?= =?us-ascii?Q?SFsA6jZyoFlZi9+lp1v+oYO6xiItyMzICqTGbAZZaQ+j/UbxIFbj/Uit9TJ7?= =?us-ascii?Q?prGJQ8qdMR/xqEpwjBRIEDfYQyOvjOLLQqM6xo+KTJEBYdP7K3/tyuFo4+UR?= =?us-ascii?Q?louF+AaKcXLWwN9uc3UqFjJY+OEvfOCxoMwbxHAPqAbSQkgAO8Gja4tjGkEy?= =?us-ascii?Q?sWG/A13YiqRuA3wCwo6IoVYb6m4he1jvD+IYoMp73ljkMriXZv80p9pkrLF/?= =?us-ascii?Q?Z2k0SwzyzvEGLMqcmp+f0HmrbKLjcL5krWsh+p8kkum7NjzlUOoAcm9bWQAb?= =?us-ascii?Q?+Gb1Lr7clRsyJzmRUEl/YRAFhneolaSnnEm8wCNGnTBRDWEaHI7ogTB7P+xY?= =?us-ascii?Q?p6gRZH6g+nLVBut8zwmu4LC+H1a/5kNUn5V0aYBzUtnEJvArHsFA8hcOa7d5?= =?us-ascii?Q?20fVexJvIpbKILhWM833fyKg1RVE5AWKYSb66uxUiyOvgkhUzfRDwmOkmqml?= =?us-ascii?Q?H7wXTdgzha8VN0S6BskDlvjjJL3ETvW6CvbASy8Qvdu7OYCwxD5o1UE4pBpw?= =?us-ascii?Q?4xsL30tm3Tejx8fJLjD0Wl9OAiAeUqeqyrCi44fMeElIpqRyAKgJYr5kcsAN?= =?us-ascii?Q?i5oWS2v8rIQmx5oH61Q5eXPiiHJWr/kkH2c87XYgzDiKHEjj3Qxlp2/74Dcg?= =?us-ascii?Q?ZOeQ2V0L25PJBd+p/1Fou0T4nzPz2UQ8ks+SwrNWo5PafW9AdZ3wTKRNqA8t?= =?us-ascii?Q?hRxg34xVyucctFfuZMz/mCqml3XuWA/S37B6LFb7Ax8Z41L6h7TiBvN+JCLL?= =?us-ascii?Q?z72DUhZBY2L1lZXfqwMH94nvMJb4NfvbML+MK2VvRnwVPZCHQVOQyQ6Ev8s+?= =?us-ascii?Q?HDj573FEhQxQC7lI858VgQl/FAOXjvxMdsnmvuQo4JzR0NR/JTrn/1TdN5Ow?= =?us-ascii?Q?t9eTkKkijdTmctCuU96Y1F9zaD58bojgOUfeUr79RCDCa6GpDLdyFZnGHPh3?= =?us-ascii?Q?xtDaD6DxwO0FAOC16PxEzHairwL6Yw1ZiWsHfOW6CN6k+V/q+iifib89BGnB?= =?us-ascii?Q?2EM5AbsXRDFXtzmclK4oZofcqQbKRPJ6FSt8FwZT7HhG3QiYPDCn5obNuymf?= =?us-ascii?Q?YXXgI2mYca6ThlUuQ9fA3I49eTtmAiUnnU+zJTVz6m8pX32u9MN3k0H5a5ff?= =?us-ascii?Q?ycIZHXmbfUzk7bYuc6P34oZNIrvRBivqrMizwRvINRMz4PxZU2Q?= X-Microsoft-Antispam-Message-Info: vAQT8Xhnx4es3aj2V0UtyfXTcbg4mPgIazWWDR0WP69FG8bF6JgpnjNrGkOZLAVPEiV+8y4uO+qsZ8mphSmGJYjmHEoHZtcsFuGnTTIITULPC9LqbwqDFKQcD+8D5BgRRYw3LGffMXwUEUqQxmreda7+iXVw1raxZFayV0IAOJYzKp1YwcqCC4/yyssCaCmXVdUuUz3WEX9LC9pwqrcOyILLAGBLxIB+aexMqm3gbb5YodFZ3WQ0ko4B4MhMbu34swqQ6wp+pJSQdCudhWD+QauWc0p0902VWBmrSyAksjNNz70584uoI5p9p0tSA/9UY1+ZBF8euxLuuv3NUC6eR0ictZIff+MXHxfkfpd4CEE= X-Microsoft-Exchange-Diagnostics: 1; BYAPR07MB4997; 6:7fpH177l2izn/SOXh/YwH7uwFj/Ukxhq6ZAS5WlZVuV1ALFc2dxz2s6Mw4E/vK6I4V2f6xbvQJLQUQ3cbn0fcam3CC3/OCUHWjs/Bc03i5ifR8CRdhdJL27ennhmjjJNORcY3bMmTQV8GEcMa/JdV7ao+KlGaEMKTvA2GxCzsRsbbcj2dcftgv5bocexqTsbY7rED1HYMdLVErR5S2Sa36YkLRu0fbOnxQrxuCJ1YQko8NxwWqnafE1Zjsz79xb+vj6Tvvw4mKKDGGw91KZVYOH0Pm1l4JmxayNTvJE90ccJHj84NRTBykxrxbu/mGH/PxZ3e5tp8j6ZmdrXHE5Ru6/wPGlH3V4qMF3N3zHiD4smML8mgtGnbR9H8AgoQz0B7FTnC8AZX4gZYTdtLoXyYg0KcLs13Ykeuo+kcqKiYw3lTuIfupu4WQlRf4lUklUHA/gIpKgO2XdAnFszheQ7HQ==; 5:z/F2qoyor9r8vgI+U5zLGUuPrBtlbnFH8KT6Qmp4CLlEAdmGDBEnmcMqdhGdgABL4cixOBYo5LB5BjbpBvyjkCSHOvQUo4a1K99RSqnzf0Ckxc08DcAWUHWIz1gRHUSwfwB8fkcqURHTo2zV5YV4IEQyV8bjmiaKB1uWsYpcALI=; 7:3JCxw4N7MJhoeHxqmScMUFp/oq1L2sSzs+9+QOYJHRlCs8JRreCgvyemaPyO8bUO7/cQ1CKG1ljgXVBSzgtdPBWMO+keXAowAD1oolgh3u9W0jyOgrqPTs5JCf/SoPj3pHzddhsGWFUlsZ8XywKoGV1cJ/XOLuzDGM6U7TzOX9/PYB5lN1jboOgZyXqF+kH861UK2275atvbsOPmtfOU/50RIppa/+NlylkuyPADhQE/9NoQzA+XWqUz8+0QBvi6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2018 08:15:57.1320 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6d8d4681-0c51-457f-f2dd-08d62b63f480 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4997 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Oct 2018 08:16:05 -0000 -----Original Message----- > Date: Sat, 06 Oct 2018 00:44:52 +0200 > From: Thomas Monjalon > To: Ferruh Yigit , Jerin Jacob > , Andrew Rybchenko > > Cc: Wenzhuo Lu , Jingjing Wu , > Bernard Iremonger , John McNamara > , Marko Kovacevic , > Olivier Matz , dev@dpdk.org, shahafs@mellanox.com, > "Ananyev, Konstantin" , > didier.pallard@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > > > 05/10/2018 22:04, Ferruh Yigit: > > On 10/4/2018 6:59 AM, Jerin Jacob wrote: > > > From: Andrew Rybchenko > > >> On 03.10.2018 21:14, Jerin Jacob wrote: > > >>> From: Andrew Rybchenko > > >>>> On 03.10.2018 20:12, Jerin Jacob wrote: > > >>>>> From: Jerin Jacob > > >>>>>> From: Andrew Rybchenko > > >>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner or outer. > > >>>>>>> May be it is not directly related to changeset, but I think it would be really > > >>>>>>> useful to clarify it. > > >>>>>> I will update the comment. > > >>>>> Hi Andrew, > > >>>>> > > However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD definition? I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and mbuf maintainers in this list. So what else I need make forward progress on this patch? I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It is safe to assume that ALL HW can support CKSUM BAD if the feature is available and hence it is more portable. > >