From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com,
qi.z.zhang@intel.com, ferruh.yigit@intel.com,
ktraynor@redhat.com
Subject: [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and hotplug functions
Date: Sun, 7 Oct 2018 11:32:39 +0200 [thread overview]
Message-ID: <20181007093244.20659-1-thomas@monjalon.net> (raw)
In-Reply-To: <20180907222727.20521-1-thomas@monjalon.net>
This is a follow-up of an idea presented at Dublin
during the "hotplug talk".
Instead of changing the existing hotplug functions, as in the RFC,
some new experimental functions are added.
The old functions lose their experimental status in order to provide
a non-experimental replacement for deprecated attach/detach functions.
It has been discussed briefly in the latest technical board meeting.
Changes in v6 - after Gaetan's review:
- bump ABI version of all buses (because of rte_device change)
- unroll snprintf loop in rte_eal_hotplug_add
Changes in v5:
- rte_devargs_remove is fixed in case of null devargs (patch 2)
- a pointer to the bus is added in rte_device (patch 3)
- rte_dev_remove is fixed in case of no devargs (patch 5)
Changes in v4 - after Andrew's review:
- add API changes in release notes (patches 1 & 2)
- fix memory leak in rte_eal_hotplug_add (patch 4)
Change in v3:
- fix null dereferencing in error path (patch 2)
Thomas Monjalon (5):
devargs: remove deprecated functions
devargs: simplify parameters of removal function
eal: add bus pointer in device structure
eal: remove experimental flag of hotplug functions
eal: simplify parameters of hotplug functions
doc/guides/rel_notes/release_18_11.rst | 23 ++++--
drivers/bus/dpaa/Makefile | 2 +-
drivers/bus/dpaa/dpaa_bus.c | 2 +
drivers/bus/dpaa/meson.build | 2 +
drivers/bus/fslmc/Makefile | 2 +-
drivers/bus/fslmc/fslmc_bus.c | 2 +
drivers/bus/fslmc/meson.build | 2 +
drivers/bus/ifpga/Makefile | 2 +-
drivers/bus/ifpga/ifpga_bus.c | 6 +-
drivers/bus/ifpga/meson.build | 2 +
drivers/bus/pci/Makefile | 2 +-
drivers/bus/pci/bsd/pci.c | 2 +
drivers/bus/pci/linux/pci.c | 1 +
drivers/bus/pci/meson.build | 2 +
drivers/bus/pci/private.h | 2 +
drivers/bus/vdev/Makefile | 2 +-
drivers/bus/vdev/meson.build | 2 +
drivers/bus/vdev/vdev.c | 9 +--
drivers/bus/vmbus/Makefile | 2 +-
drivers/bus/vmbus/linux/vmbus_bus.c | 1 +
drivers/bus/vmbus/meson.build | 2 +
drivers/bus/vmbus/private.h | 3 +
drivers/net/failsafe/failsafe_eal.c | 3 +-
drivers/net/failsafe/failsafe_ether.c | 3 +-
lib/librte_eal/common/eal_common_dev.c | 90 +++++++++++++--------
lib/librte_eal/common/eal_common_devargs.c | 41 ++--------
lib/librte_eal/common/include/rte_dev.h | 36 +++++++--
lib/librte_eal/common/include/rte_devargs.h | 81 +------------------
lib/librte_eal/rte_eal_version.map | 10 +--
29 files changed, 155 insertions(+), 184 deletions(-)
--
2.19.0
next prev parent reply other threads:[~2018-10-07 9:32 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 22:27 [dpdk-dev] [RFC] eal: simplify parameters of " Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 0/4] eal: simplify devargs and " Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-09-27 8:24 ` Ophir Munk
2018-09-27 21:31 ` Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-09-26 21:47 ` [dpdk-dev] [PATCH v2 4/4] eal: simplify parameters " Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 0/4] eal: simplify devargs and " Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-10-01 11:24 ` Andrew Rybchenko
2018-10-01 17:10 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-01 11:25 ` Andrew Rybchenko
2018-10-01 19:47 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-01 11:26 ` Andrew Rybchenko
2018-10-01 19:54 ` Thomas Monjalon
2018-10-02 10:28 ` Ferruh Yigit
2018-10-03 8:42 ` Thomas Monjalon
2018-09-28 16:21 ` [dpdk-dev] [PATCH v3 4/4] eal: simplify parameters " Thomas Monjalon
2018-10-01 11:26 ` Andrew Rybchenko
2018-10-01 20:03 ` Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 0/4] eal: simplify devargs and " Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 1/4] devargs: remove deprecated functions Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 2/4] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 3/4] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-01 20:52 ` [dpdk-dev] [PATCH v4 4/4] eal: simplify parameters " Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 0/5] eal: simplify devargs and " Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 1/5] devargs: remove deprecated functions Thomas Monjalon
2018-10-04 9:19 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 2/5] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-04 9:21 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure Thomas Monjalon
2018-10-04 9:31 ` Gaëtan Rivet
2018-10-04 9:48 ` Thomas Monjalon
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 4/5] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-04 9:33 ` Gaëtan Rivet
2018-10-03 23:10 ` [dpdk-dev] [PATCH v5 5/5] eal: simplify parameters " Thomas Monjalon
2018-10-04 9:44 ` Gaëtan Rivet
2018-10-04 11:46 ` Thomas Monjalon
2018-10-04 11:51 ` Gaëtan Rivet
2018-10-07 9:32 ` Thomas Monjalon [this message]
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 1/5] devargs: remove deprecated functions Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 2/5] devargs: simplify parameters of removal function Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 3/5] eal: add bus pointer in device structure Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 4/5] eal: remove experimental flag of hotplug functions Thomas Monjalon
2018-10-07 9:32 ` [dpdk-dev] [PATCH v6 5/5] eal: simplify parameters " Thomas Monjalon
2018-10-08 21:45 ` [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and " Stephen Hemminger
2018-10-11 12:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007093244.20659-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=ktraynor@redhat.com \
--cc=ophirmu@mellanox.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).