From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 34AC42C38
for <dev@dpdk.org>; Sun, 7 Oct 2018 11:32:56 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id CDCC321F00;
Sun, 7 Oct 2018 05:32:55 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Sun, 07 Oct 2018 05:32:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding; s=mesmtp; bh=tC/ZZEBFAk
4P92cF0OzwkfYkNA8jG6tEB++ZvPDE7dg=; b=Wit6l3S01Zn38VAdMcCKgUUQZS
jVHnYjkjRaKuEupnDFS1drfoBxFHSds2QQTyHwQrxq/oAqVw/cDkPJNz4sdupTTb
cvLLh9/QkV43do2rcrsQ6RJYOrsfepOSi+/9FIvkADB1sLDekRlrO1wgdlZnFAhx
UHuHflFQIwx0Ozz3U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:date:from
:in-reply-to:message-id:mime-version:references:subject:to
:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
fm3; bh=tC/ZZEBFAk4P92cF0OzwkfYkNA8jG6tEB++ZvPDE7dg=; b=rLYqgRZA
ViR3UwSgNYFW5XSIsYO99OGIP5LADGh1cFBQnG5UVv4n06fsPW9chgOOXbe6sCgO
XwK8Is8DonCb7b+yxy9HIP73RwgNvvUezQoT3bv6mXLIInfIef36bOKekQnXcMTu
YmmgefHlaB8ld/U/PC3iAxbQkL1xfNnlfnDIJ2LUU2a1aQErVb0qO18BHygpz/nc
HlRdOvbwOHObz5lGxe0uAb4TQo6PFDadiREL4qECcs+eAzuaLuHtkjw0B4MYneMw
BhsL9ul786mY2/t8XaKmXjc7H/OmwdG3pQnMcydecMsBmcOEC07nR7QkQqyR/7sl
rRTEhDYFlLNPIA==
X-ME-Sender: <xms:x9K5W2bOlfUhnd8DY04b4pORA2bGUmRps_28f3rw2jZnL7SMRv-XgQ>
X-ME-Proxy: <xmx:x9K5W2I5mB01yobKiRAoW8b-uBW0gQV2mCl7iIzATmW5kjkkcUWjHA>
<xmx:x9K5W2aOXBvnIEtjezgPx4CU_uqF49xpzl8SzmFtRPn3E75d_VdAwg>
<xmx:x9K5W3EyfU5yx1z1JDamfKkL9CgHvKJ6G76F64DOerABCjA2lBZAWA>
<xmx:x9K5W5pME_YXwtUlOIxEQ8rqXHnNzmAiV2REeZgzdxHB5lhyza783A>
<xmx:x9K5Ww6bW-031hV0aKuIsxd3kqqqgGr78ASp4RG7NOcI0uG4EPDbEA>
<xmx:x9K5WxtGdfY0khFGizXG45NhV3oQDquy_xW5P_GZGgZVEQ2zrc2x5w>
Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id D5441102E8;
Sun, 7 Oct 2018 05:32:54 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com,
ferruh.yigit@intel.com, ktraynor@redhat.com
Date: Sun, 7 Oct 2018 11:32:43 +0200
Message-Id: <20181007093244.20659-5-thomas@monjalon.net>
X-Mailer: git-send-email 2.19.0
In-Reply-To: <20181007093244.20659-1-thomas@monjalon.net>
References: <20180907222727.20521-1-thomas@monjalon.net>
<20181007093244.20659-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v6 4/5] eal: remove experimental flag of hotplug
functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Oct 2018 09:32:56 -0000
These functions are quite old and are the only available replacement
for the deprecated attach/detach functions.
Note: some new functions may (again) replace these hotplug functions,
in future, with better parameters.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_eal/common/eal_common_dev.c | 7 ++++---
lib/librte_eal/common/include/rte_dev.h | 11 ++---------
lib/librte_eal/rte_eal_version.map | 4 ++--
3 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c
index e1d9e8ec7..ce6d145fb 100644
--- a/lib/librte_eal/common/eal_common_dev.c
+++ b/lib/librte_eal/common/eal_common_dev.c
@@ -127,8 +127,9 @@ int rte_eal_dev_detach(struct rte_device *dev)
return ret;
}
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
- const char *devargs)
+int
+rte_eal_hotplug_add(const char *busname, const char *devname,
+ const char *devargs)
{
struct rte_bus *bus;
struct rte_device *dev;
@@ -193,7 +194,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
return ret;
}
-int __rte_experimental
+int
rte_eal_hotplug_remove(const char *busname, const char *devname)
{
struct rte_bus *bus;
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h
index d82cba847..d6c5d48a9 100644
--- a/lib/librte_eal/common/include/rte_dev.h
+++ b/lib/librte_eal/common/include/rte_dev.h
@@ -190,9 +190,6 @@ __rte_deprecated
int rte_eal_dev_detach(struct rte_device *dev);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Hotplug add a given device to a specific bus.
*
* @param busname
@@ -205,13 +202,10 @@ int rte_eal_dev_detach(struct rte_device *dev);
* @return
* 0 on success, negative on error.
*/
-int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devname,
+int rte_eal_hotplug_add(const char *busname, const char *devname,
const char *devargs);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
* Hotplug remove a given device from a specific bus.
*
* @param busname
@@ -221,8 +215,7 @@ int __rte_experimental rte_eal_hotplug_add(const char *busname, const char *devn
* @return
* 0 on success, negative on error.
*/
-int __rte_experimental rte_eal_hotplug_remove(const char *busname,
- const char *devname);
+int rte_eal_hotplug_remove(const char *busname, const char *devname);
/**
* Device comparison function.
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 3df7f9831..6bff37f4b 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -261,6 +261,8 @@ DPDK_18.08 {
DPDK_18.11 {
global:
+ rte_eal_hotplug_add;
+ rte_eal_hotplug_remove;
rte_strscpy;
} DPDK_18.08;
@@ -288,8 +290,6 @@ EXPERIMENTAL {
rte_devargs_remove;
rte_devargs_type_count;
rte_eal_cleanup;
- rte_eal_hotplug_add;
- rte_eal_hotplug_remove;
rte_fbarray_attach;
rte_fbarray_destroy;
rte_fbarray_detach;
--
2.19.0