From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Ashish Gupta <ashish.gupta@cavium.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>,
Keith Wiles <keith.wiles@intel.com>,
Nipun Gupta <nipun.gupta@nxp.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals
Date: Sun, 7 Oct 2018 17:48:04 +0530 [thread overview]
Message-ID: <20181007121803.GA2335@jerin> (raw)
In-Reply-To: <20181005162612.31906-1-ferruh.yigit@intel.com>
-----Original Message-----
> Date: Fri, 5 Oct 2018 17:26:08 +0100
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> To: Reshma Pattan <reshma.pattan@intel.com>, Hemant Agrawal
> <hemant.agrawal@nxp.com>, Shreyansh Jain <shreyansh.jain@nxp.com>, Ashish
> Gupta <ashish.gupta@cavium.com>, Fiona Trahe <fiona.trahe@intel.com>,
> Pablo de Lara <pablo.de.lara.guarch@intel.com>, Akhil Goyal
> <akhil.goyal@nxp.com>, Declan Doherty <declan.doherty@intel.com>, Fan
> Zhang <roy.fan.zhang@intel.com>, Rahul Lakkireddy
> <rahul.lakkireddy@chelsio.com>, Gaetan Rivet <gaetan.rivet@6wind.com>, Qi
> Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Beilei
> Xing <beilei.xing@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>,
> Konstantin Ananyev <konstantin.ananyev@intel.com>, Rasesh Mody
> <rasesh.mody@cavium.com>, Harish Patil <harish.patil@cavium.com>, Shahed
> Shaikh <shahed.shaikh@cavium.com>, Andrew Rybchenko
> <arybchenko@solarflare.com>, Jasvinder Singh <jasvinder.singh@intel.com>,
> Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Keith Wiles
> <keith.wiles@intel.com>, Nipun Gupta <nipun.gupta@nxp.com>, Anatoly
> Burakov <anatoly.burakov@intel.com>, Thomas Monjalon
> <thomas@monjalon.net>, Jerin Jacob <jerin.jacob@caviumnetworks.com>,
> Olivier Matz <olivier.matz@6wind.com>
> CC: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [PATCH v2 1/4] add missing static keyword to globals
> X-Mailer: git-send-email 2.17.1
>
> External Email
>
> Some global variables can indeed be static, add static keyword to them.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Series is based on next-net tree
> ---
./devtools/check-git-log.sh has following warning.
Wrong headline format:
add missing static keyword to globals
Other than that:
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
next prev parent reply other threads:[~2018-10-07 12:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 3:40 [dpdk-dev] [PATCH] fix static variables Ferruh Yigit
2018-10-05 8:38 ` Rao, Nikhil
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Ferruh Yigit
2018-10-05 15:55 ` Andrew Rybchenko
2018-10-28 11:04 ` Thomas Monjalon
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-05 16:27 ` Maxime Coquelin
2018-10-08 12:18 ` Shreyansh Jain
2018-10-10 5:56 ` Zhang, Tianfei
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 3/4] fix global variable issues Ferruh Yigit
2018-10-07 12:21 ` Jerin Jacob
2018-10-05 16:26 ` [dpdk-dev] [PATCH v2 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-07 12:22 ` Jerin Jacob
2018-10-08 8:45 ` Shreyansh Jain
2018-10-08 9:11 ` Ferruh Yigit
2018-10-08 9:27 ` Shreyansh Jain
2018-10-07 12:18 ` Jerin Jacob [this message]
2018-10-08 9:43 ` [dpdk-dev] [PATCH v2 1/4] add missing static keyword to globals Shreyansh Jain
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 " Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 3/4] fix global variable issues Ferruh Yigit
2018-10-29 6:57 ` Hyong Youb Kim
2018-10-28 23:57 ` [dpdk-dev] [PATCH v3 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-29 1:35 ` Thomas Monjalon
2018-10-10 6:23 ` [dpdk-dev] [PATCH] fix static variables Zhang, Tianfei
2018-10-11 6:56 ` Xing, Beilei
2018-11-02 10:58 ` [dpdk-dev] " Tomasz Cel
2018-11-02 11:09 ` Cel, TomaszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007121803.GA2335@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=akhil.goyal@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=ashish.gupta@cavium.com \
--cc=beilei.xing@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=jasvinder.singh@intel.com \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=nipun.gupta@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=reshma.pattan@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shahed.shaikh@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).