From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <Jerin.JacobKollanukkaran@cavium.com> Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700063.outbound.protection.outlook.com [40.107.70.63]) by dpdk.org (Postfix) with ESMTP id 109DC160 for <dev@dpdk.org>; Mon, 8 Oct 2018 10:24:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xc72qgMW4xjrjpgMUAthpoMoTXMPPFCDs6I/BlpqHxo=; b=KAW3LQ6jbgpfT0S3WdGEKQvMcoNveXWsDGdUdjZNDt3CXDarMk+v/IjsGPtgZgkD41sEHdZG87ASN1eCe5gJuejS38TDDP/oVTQd6gzXUqts80M7g9+YBWQbb6CsTDQKmfp9vEw//00PQtDBcZ2aEnFMX5ejQ4cf+0uxNgnY7Fg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (115.113.156.3) by SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.21; Mon, 8 Oct 2018 08:24:40 +0000 Date: Mon, 8 Oct 2018 13:54:24 +0530 From: Jerin Jacob <jerin.jacob@caviumnetworks.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko <arybchenko@solarflare.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, "shahafs@mellanox.com" <shahafs@mellanox.com>, "didier.pallard@6wind.com" <didier.pallard@6wind.com> Message-ID: <20181008082421.GA3554@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181004055930.GA4406@jerin> <c304808d-32d1-26e5-d3b7-88e79c4512c3@intel.com> <26087815.IDbtF1NTBH@xps> <20181006081537.GB21149@jerin> <2601191342CEEE43887BDE71AB9772580102FE2EE9@IRSMSX106.ger.corp.intel.com> <601d2413-e148-73c4-e7a5-59f09bd02451@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <601d2413-e148-73c4-e7a5-59f09bd02451@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [115.113.156.3] X-ClientProxiedBy: BM1PR0101CA0036.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::22) To SN6PR07MB5006.namprd07.prod.outlook.com (2603:10b6:805:ac::32) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec9c5900-638f-4c0e-ab54-08d62cf780ba X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5006; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 3:vztvL+bH+fxRrgqMRro7akxvSKF5kyosUvW4Ksl69Vim+Y4ag2KvuibRANYfP2OGXi3uJVEL341qBJOBTPiruQ4jrB7b/1+K2ckStNNYTlmcWlkEw15HBbLyF41pPrnd4ZhNYm+rgmxCJiRMVWNXxEmF3J50iVnucDcQaJVSWzrlj9dcVSer4ShlG+sQqXbAkOb4yVb8X2liX/OHbjqzlWwSNLQvVq3/F4F6S2Krn1vcr9Oz39MUR9r1rwL17vmf; 25:CPpXpL184GUqLXFcxRwesLOy4fhysijNchDdhfPHXkngOKyKC6L5H/3qm1hJlY57wI+4Evzh7qwQOXA3/wavuS02XVIBF/0rUBjhRcl5/CK/YCxiARldHesIM/mRR0d4Sv8pvaGh6yeiCGSA8P0Xvj7L0QU8rdSMT9uFtnV2Oi9Ufq0gJcZC1ScCCA2j3ovLBfr4bo8pnhgLr3HO8XtRUkkE0j3xlLlHh11DE5bbfMApDgb58pl6Z9mC0a3LeT+r6YvJ37RQm56LGi30y1hmkDk+GFO4HvP9ONIsJ1r3kIM/bfC2sF4oETF6qb0Lo+XHPVkSxtIJH2eRk6fScItp2Q==; 31:8GbnjxgHgbMY0HQElb8JJrM/re1WMhG1P9JIc4uptLd3EqysAU/XpYn+u8918GX2yDA5Pwi5lo0LZxHKpj9iwzHcsdKqOSwOl2RiTaGSW8f/iQugffqTYyBw8Mi71cHnAnP2SbEOmk76vUl1YLrdA1R96v7EiXGp9paTsr4PRBVkAmR39ySJDEm6IyIUrQcxq+OQLAdCHlx3UahTND8ikPmxjkrI//OZgSBrf2e6x/s= X-MS-TrafficTypeDiagnostic: SN6PR07MB5006: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 20:U5iOoEm3SxOd/ggyWt1c0eOVgMeOrxeq28AMojzhAUSnI5cS01sALwHTbFWNP4QUbu3PGuy/trtZ6onu9luvNqKHnuCm/OUcDDGu7b4hYK9TRfjbnpzhgClFDRssJQYWQj9QmovenBZeOfIksDVho3kc8WZpzT430acW4HS007m8JXAuqn/1GWU0NioIoUuu7uDlC5e1i1gGM4vcHn2gpNa5Q5jZzA1VEMpJNMzBxxcT7rW/+WsH5/rG4TgELMSr5tFxklg3rrQz7QY5j5FoEwQsfRB5NvCu8yt8tx3D14NrW/izVrd9GuEoWHARMXJdI9GeAtqt8aUvALRmsNX3JTAboJFsh7x8jMz5Kug4LHR/rOKipx+Uex+IzK0rMFTCHqf6C9CB9GnWSqgWSBH5lV1BXujsE+tBcv2Z8UZeigozVMAmcjVys6LiEsxnaGUjgevpKyjNqY7p4hZsCCRowY8L/AK4xrCWfIp0ui3o/zx7eXPZNTHevzs48o7ybGFIQyuv67Zpm6slQaDCFiIaufQgXoCcG2/5DQZ/7Us9b0YX3ACdC/SQ7jfhmHxME31/2N1TvKnPgL66d5mujNZcwBZEuN+BTjQVtkleFQu1tTM= X-Microsoft-Antispam-PRVS: <SN6PR07MB500682446F10C4B4505F2F22E3E60@SN6PR07MB5006.namprd07.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(211171220733660); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231355)(944501410)(52105095)(3002001)(93006095)(10201501046)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051); SRVR:SN6PR07MB5006; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5006; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 4:0c8HySuUB8r3DxOuD4JYpCGw1hOz88zbmbXGbazUd7sI0CsiHTmTOBeVyxK9iR0e7HSqHebvO4ecavRRjADnbCCTOGambGyE4EbSEc7Kfxa26h+8go+xGBVnFtlUZVA+XccXh7kW1tn65W+KrfghGkAmlTC9i7Q/iOHyB1h6dx+May0tkcbwS7wniwBLZCYCT7xKx4P+0El/YYB9Q0Do2w5FoJrieVqUi/LXrF9vLEA6NwJU2rxPp5p3ard4KDiHqf1gtEIBGRNlVQeHD43j7wRbM1P9fQrrULrMErETOXq57Fnsx8RoxfEDmeN3JQyImC1oylu0xot5EwPOqjogDNqJCgEf7OwQeAz/+0b8RKM= X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(136003)(366004)(199004)(189003)(13464003)(57704003)(105586002)(47776003)(33716001)(81156014)(6116002)(53936002)(4326008)(8676002)(6666003)(6916009)(106356001)(14444005)(54906003)(5660300001)(66066001)(93886005)(2906002)(6246003)(229853002)(58126008)(1076002)(8936002)(3846002)(81166006)(25786009)(55016002)(23726003)(68736007)(9686003)(6496006)(53546011)(44832011)(72206003)(446003)(42882007)(26005)(50466002)(76176011)(55236004)(52116002)(7736002)(11346002)(305945005)(476003)(33896004)(956004)(33656002)(386003)(486006)(7416002)(16586007)(478600001)(97736004)(316002)(16526019)(186003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5006; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5006; 23:cluLsX/ZPEKyOGOjw5wh1qe+Rh9IeR/VO/34jG6xn?= =?us-ascii?Q?VEI8E3cO5rfUZzljlzdfgQ7VeoY/crPj404XuNeOL0rFypy2xTcbkdb7pVlb?= =?us-ascii?Q?zTKT/IwIGjaGAxPYziA7Cd4FCpgWG9mpy+nJGKbOitsoz8qDw/hU5BgQyXJM?= =?us-ascii?Q?Z6nk1KLx/Ft4FME560KzSB/TJVV1E2mUZJXae0tgesomIBOx8HUDp8qhDwAn?= =?us-ascii?Q?DnTZtO5w1TrF/IBqi3ZtJd8IsJ0XlpcxRfgZPN0caYxOPj89f3+3VwKyxz+0?= =?us-ascii?Q?ote0VBeAuOF+fMZ/xbhguyJRepYLZSuFVEd2FESyqgd+0B2TbnCfHETd76YM?= =?us-ascii?Q?l16WyS3uLmkHS3Ul//x2rslMopZMRP6MHtafX+9lWHfbDy2vlhXG3Up0ImCi?= =?us-ascii?Q?k/9Du2eR0OdcC7eVaKFUjeuEOeJ9oG8+M/gzpnTu2TjKBgaiN/OEdtIMpjOO?= =?us-ascii?Q?7fc7THiFvn78xYuVYLerfwEpZ6k4OImTwEXQ35TX0ZvOhr8JQVs5E2mGz5vf?= =?us-ascii?Q?A1qhHONrVwRf+ZeNhImuqbsbAyVJRWHV2dYwNJMOmFl8NUtn/qQjEVqNMFZc?= =?us-ascii?Q?IOtq+S1cY3cHRM5dEE1RSZ6Go53LxRKe2AbtZLaYBIyx/RCGDPte3Q1PqhS7?= =?us-ascii?Q?DakAvQXn6GQo6SA1olRaSa5sRqFsfsgusGutncYjy+/G3e/oRXJg9XJ2ub4p?= =?us-ascii?Q?w48UUzmBEId5gdi1b1yJgszTz9mDvf+rVuBB9WQjDIxtscYk/V4v9qSrOAfH?= =?us-ascii?Q?BWus+1xIqOswV2q5/6K1kUv8un8Cmkl1+MIYHorFHLmRNaTkoyUh3vNNYsBz?= =?us-ascii?Q?IFWtwAgp+3gZOKShXKA5NMqofwscBH8JczGlrn8slodzq/D3/yBXWnBhU5yE?= =?us-ascii?Q?YF6BsdemE7zSbcRra0wQJ1dQ2RiDVns2P0zqASGxPDoQ7DKujSD9KtB2W/tN?= =?us-ascii?Q?cxKzY9QyKXah9/vLjfVf6zB+vAcPzB4Tu94UMdeyZQSSx74xq52ZEWXbbOoD?= =?us-ascii?Q?WxoUw9k7YQQOQGWwLYqjLYfNidmzzFrlgRwBhnM1UWTiuBEMq2065q/zfJTh?= =?us-ascii?Q?wZfjlsom0+BAoWLOuusZJkw7VPHWCPGAaLMBgYFPSEuo7R9FkhNu4e4hVnr/?= =?us-ascii?Q?8BazachBMaKDwaMJofVggXSDEEneJ55r3E6dktttyzB0+Vc2pKF3gQwLYzdR?= =?us-ascii?Q?vAJsgouSV2wwetCS/D+jwhd8nr3W2LmI7cMSHGY7xN6EadThAq3B4F5R/S74?= =?us-ascii?Q?bh8sejS5iqi0PJSM5/40npXF4dDjgU4QyefT7UxmU6g5ynSjndKSd2g1fvcP?= =?us-ascii?Q?rYE77wQinB2VqOaxSfjvzRWhSYbXfDc4Ekc+WIy8mdFzLOeH6hX6OAwDa4/K?= =?us-ascii?Q?A3qGCCePJt88NzFbNaGQaU4IpH2nCwSj0rkHs4N/HueELOqIs8iyr5ZnzJdz?= =?us-ascii?Q?B5dbUFyF5C2L3BIC2ossNhpjkImIyvdBBBR34KFSbWRm7/qfN95?= X-Microsoft-Antispam-Message-Info: IsKG5IqnE5EeUedEUc/JpSnf0nN7moaaSPdTu6vv0j4zFJkCPDQ/Ec4160qTcw9JfyrppIyCDPhiyGH4+o7tFbMcRbyQ84Um7XzcRYP7c4FQYgQQwLyal/BeTThouS7VqbDtlEhl1ikDN/nOudhmdQeJ7W/stIgvD4rZEtQmkqkvLtENUkNR5ZwIFTFNxyslzPBdai2Mp57ogl0JmW09+V+/ugsSB1HsNoGUNMmDXyYIBusG4nTXW/cMXDrpTaGwgkytnc3KXlwPUcjqwL1orRtWoreuhuPugcxHqtMILJQEXMLg4KFt9jOtKAfeXcjxt8td7lYhq4wuwwy+nidzUY9zABj50eJ6iA2dbnOfRkI= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5006; 6:LlPtybUOX95JvBZlmdLtjnG7QicTae1xycHzrmUmrSDrtz+0vJY35wS31Lh6cN94ak0xvGW3m/7cCzKFW5EBSklKMgOUc7pvCBxAuIpWxfcCwRszmnMsZ2+OKEGbVDvKX8n0xgN7rh3emA9NgawlqeIwymB6LraoEvd8PRc+ngfa+GLnBeY5hqADifZUg39bKUcPSlwlgBnx6x9c/jpsPkM7y0LnVsBXDF3DeJBVIc08ixXB8kLZu/cEQy561hg9mIg6+5T/Rb5h8OR4E+O2rhERMchYqv7nbsfvjihnM5cJZWLJw8uFIaos5JrnF8NDKZcsc9opucBgencwIXyjq4uS3iRlYy79x7uI5o3DY396hSP0Bb1YUTixwCa2bn/B3624uclI76NnRzoBuni+bbJrmbnmr5vVvSlANXK77vdu783Nq8o8udQj2rHfkfF4wHuURpVJLoTA01bMrOzRTw==; 5:fVr/RLB8E1RM72HzMX5AT6Ol4nEOpFjjZo3sSRYi45fCEf6u1Ml9nW5B+YPMmczIz7Bjzp14XvxkFnqGFVGJVMmbraEAxI3d0kp99J20hfXKztEjOMtQuM4s9vuSY37QKys5wzc2f4yyT3YOz4vh3AV2eM1Mav//UkfGX4jQPcY=; 7:DTQpQG+HePRNR2zWjbHF+VDcX0ovX+/fqF9dCOzmqjJi3YfRWcQoxPCbAp11gRLqBSUEhipNYA+tdbwilWO4I+L2Eryyrm4AMRDdO6ghDm29H+crXOuMhA6hs54kKbqNhnPzhgqUVPbUd8UJGe7BYrdjucODLt+BRhzOn34s7J5+AilHibERL549iJW+vHqOBJgfPsMYWEtMftkykeJbqu+FBR8zkVlY93z0PCHXCh8myYe3ZUPxFRlg/3pfl9vS SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 08:24:40.0108 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ec9c5900-638f-4c0e-ab54-08d62cf780ba X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5006 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 08 Oct 2018 08:24:47 -0000 -----Original Message----- > Date: Mon, 8 Oct 2018 09:12:34 +0100 > From: Ferruh Yigit <ferruh.yigit@intel.com> > To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Jerin Jacob > <jerin.jacob@caviumnetworks.com>, Thomas Monjalon <thomas@monjalon.net> > CC: Andrew Rybchenko <arybchenko@solarflare.com>, "Lu, Wenzhuo" > <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, > "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Mcnamara, John" > <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, > Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, > "shahafs@mellanox.com" <shahafs@mellanox.com>, "didier.pallard@6wind.com" > <didier.pallard@6wind.com> > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > > On 10/6/2018 1:18 PM, Ananyev, Konstantin wrote: > > > > > >> -----Original Message----- > >> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > >> Sent: Saturday, October 6, 2018 9:16 AM > >> To: Thomas Monjalon <thomas@monjalon.net> > >> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, > >> Jingjing <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Mcnamara, John <john.mcnamara@intel.com>; > >> Kovacevic, Marko <marko.kovacevic@intel.com>; Olivier Matz <olivier.matz@6wind.com>; dev@dpdk.org; shahafs@mellanox.com; > >> Ananyev, Konstantin <konstantin.ananyev@intel.com>; didier.pallard@6wind.com > >> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition > >> > >> -----Original Message----- > >>> Date: Sat, 06 Oct 2018 00:44:52 +0200 > >>> From: Thomas Monjalon <thomas@monjalon.net> > >>> To: Ferruh Yigit <ferruh.yigit@intel.com>, Jerin Jacob > >>> <jerin.jacob@caviumnetworks.com>, Andrew Rybchenko > >>> <arybchenko@solarflare.com> > >>> Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, > >>> Bernard Iremonger <bernard.iremonger@intel.com>, John McNamara > >>> <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, > >>> Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org, shahafs@mellanox.com, > >>> "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, > >>> didier.pallard@6wind.com > >>> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > >>> checksum definition > >>> > >>> > >>> 05/10/2018 22:04, Ferruh Yigit: > >>>> On 10/4/2018 6:59 AM, Jerin Jacob wrote: > >>>>> From: Andrew Rybchenko <arybchenko@solarflare.com> > >>>>>> On 03.10.2018 21:14, Jerin Jacob wrote: > >>>>>>> From: Andrew Rybchenko <arybchenko@solarflare.com> > >>>>>>>> On 03.10.2018 20:12, Jerin Jacob wrote: > >>>>>>>>> From: Jerin Jacob <jerin.jacob@caviumnetworks.com> > >>>>>>>>>> From: Andrew Rybchenko <arybchenko@solarflare.com> > >>>>>>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner or outer. > >>>>>>>>>>> May be it is not directly related to changeset, but I think it would be really > >>>>>>>>>>> useful to clarify it. > >>>>>>>>>> I will update the comment. > >>>>>>>>> Hi Andrew, > >>>>>>>>> > >>> > >>> However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. > >> > >> Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD > >> definition? > >> > >> I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and mbuf > >> maintainers in this list. So what else I need make forward progress > >> on this patch? > >> > >> I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It > >> is safe to assume that ALL HW can support CKSUM BAD if the feature is > >> available and hence it is more portable. > > > > Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM. > > Switching to two bit won't reduce the portability, HW supports only reporting > CKSUM_BAD can set BAD || UNKNOWN. UNKNOWN is not a bit. It is represented as 0. It spec has 2 bit, then driver need to report GOOD as well. Same applies for PKT_RX_EL4_CKSUM as well. > > And I think patch is not blocked by PKT_RX_EIP_CKSUM_BAD, it can be changed > separately, for this patch question is can we represent PKT_RX_EL4_CKSUM_* with > two bits, to have BAD/GOOD/UNKNOWN?