From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680059.outbound.protection.outlook.com [40.107.68.59]) by dpdk.org (Postfix) with ESMTP id D6BFC5F20 for ; Mon, 8 Oct 2018 14:25:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hb3lJSgNcEE4L704bhHMIgS09NMkyepbgDnPQvjDidE=; b=WDcFN62WfSb6S8HdTHGnQ9S+dwDJ+bA/d2UpgFNajb23jjRMkd1MMtVCQhwKsWzMxMapTWUqSZiUhmiwkOJdz5DGUPunwF02Dka6vXI49htHi9zcQ/qzJ06O+yknUTJ3GFYGxXmxCGWEvUPQdCxikMA3duOlbEV70mc9/IOKEIc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.167.112.78) by BL0PR07MB4995.namprd07.prod.outlook.com (2603:10b6:208:49::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.20; Mon, 8 Oct 2018 12:25:23 +0000 Date: Mon, 8 Oct 2018 17:55:10 +0530 From: Jerin Jacob To: Ferruh Yigit Cc: Thomas Monjalon , "Ananyev, Konstantin" , Andrew Rybchenko , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Mcnamara, John" , "Kovacevic, Marko" , Olivier Matz , "dev@dpdk.org" , "shahafs@mellanox.com" , "didier.pallard@6wind.com" Message-ID: <20181008122509.GA5158@jerin> References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <601d2413-e148-73c4-e7a5-59f09bd02451@intel.com> <20181008082421.GA3554@jerin> <2218090.RkeNvosNi6@xps> <20181008093741.GA11081@jerin> <20181008115524.GB28968@jerin> <80a5780a-f66b-ad7c-8327-37644c69efda@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80a5780a-f66b-ad7c-8327-37644c69efda@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [122.167.112.78] X-ClientProxiedBy: SG2PR0601CA0002.apcprd06.prod.outlook.com (2603:1096:3::12) To BL0PR07MB4995.namprd07.prod.outlook.com (2603:10b6:208:49::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 872eef39-53ea-4835-60f8-08d62d1921a9 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4995; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 3:FmNTNVnczvSqgC9FI2LWzbF54nCX1/ldDz8QDW9skH388rh09PvmAO0P/jJFnj5FGK/SQgulr/lo0Ap9pFWiwmvMYkgx67exOorruRyCGF0uMSxUYUSGHM2+iC8e6AZDopbAHGuTtVgElUTsv/T4zJC4s1tm5KNPXbq4svi3dpF5Pw3m4wSPw0YR7Ze1qkjX/uxGfW5wVwXVf2KnRRPi+IdSXfNpDxQIl2HHeMEFXRkUh7x+DtNaTl8wtmpCdQKP; 25:EqSjLXNzLUwO6QhbVrUCBhs2CQ0Y46QLncVXXdUhbbnVk8CZWFmbduRQhz6wSP4pjSH+F2a+40DjK64u9JgFbkOwHok6IbmuxePtk/51ivdKXd9idFxKvpfiaR9z4jESIwAuUHFggs10NtB5B9AIbIRpvMPc/gsuYkPqcL2RpHrSFtBny8TpDLX+r9Y1K/PRkWNxKOE10T1oTy6JDVA7OV0m5DqeJKcZE97vAnzVaR0eQi8zvavrZY3fPD9MPyuwtCb/LL3o8Lcx/pv+sq5vcoQ2H1N9Vve3SgVy2XYHbG+KqGAdbaP2JgKcomESAFTBl1Gs1ADRGog/MQiBz9nr6g==; 31:w6GaaJ1mU55e9pMpIbQB9P9COvPu80KQqMt73f6L7CGrYmoT4W5rPz/6onVF/Om1xQ1uEDghan7ni/JKGeBcvbecwdqXBj0znP9wPqbHjTcoWJLA9uf5nibZOnz/+010mrE5cyql0Funj5ra8EovweSBWts633RayqjlVScT+6noa4gKEiQX1hhj6j9hPcwO+JV0cue4W1gPYGAXIPNxUY8NtUw0kOanbFOFniruYPU= X-MS-TrafficTypeDiagnostic: BL0PR07MB4995: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 20:/V5N1kVndWZYUXEk1N3ph8w5Ic3bYKqGediq+NGIEyrsneL8k5RUcLaB5lVr7Lqfk3E1SGWufY3no9hXHNe3SiTTCZ987IcBtjJ9uj8ajrHKvNd/1DyyxNqplBeyvBySiHc7qMlPJ8W2ENYzQ4b8LXn2hKS/ZPQb+dZELu41nXuPehPMeFQu7652TffJmvN6x0C/KP94nnlHKU9TGoe0ezTZGUChr7eqVTau6jHSu/fdHf5L/dxFuQXRqu3WhryO0U/vomA26hvlBBkOYm6KQbVuxNnDgpo0sCK7Ij0YYN7ceMcAgLACyvOgAaHW9WAhvTzLvRI+LzriZIvWVd+E02OYLnQkUBauwTXvUqO6VuTHoNAscV/C3ZckOWUBXqAhC6Z/QsVH1AwaIfOSDJO4/EviBGfeugVcXUqPpp1Ru3r+BrIgTwojkV0urFt1JuMARJ8BWOiHeia6nXzMZEfYXGwMNBydgh0ky+fAeiaWqO8oQygZdMrYX5xi8yYl6E+6FntlGr3rrbB8oqXkcWgRTUGZXFEcd3elAX1BnqqNt6Gt1LUFSONTl3vgDoBntXpkU0zYO3wSTA3teqnLWqwp3dK3BVfHNf3SmanvCSSyujY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699)(211171220733660); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231355)(944501410)(52105095)(3002001)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991055); SRVR:BL0PR07MB4995; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4995; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 4:o2rsdaZHhYrrgNz2RbVg/iKYijPeZIrlqiq8ImOLdB51Me6Dugk/h+hg44q1BCRO57wKIgfkqot8fTo34S9bIHYBDyC37OPdFFzK2Rrp/mTDeKeRREALQzFfvK2HlsedK+OXJ9EMSPL7yxyA20r13iKPrV5yNqZRpkNfdzMhglYqb+ujxUZX9+B8GRlybcWKaal7O8R33TJh1SrLk2rfcXyJBAbCe0bOyHK9HRXsY+PBHLh7Bd++MVBm4qsOHQOBkEpEr2Iu/z6kPEjWvfSAvDpW09IQ4OQq312wU8hiXo5fcmswFseV7sZo6bqettJ7eeiQISkci6vekbCM+0AhMIHlpEhmSjrZCVRWk9NKocw= X-Forefront-PRVS: 081904387B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(39850400004)(136003)(396003)(366004)(376002)(189003)(57704003)(13464003)(199004)(16526019)(186003)(105586002)(26005)(42882007)(72206003)(14444005)(33656002)(8676002)(81166006)(81156014)(229853002)(50466002)(106356001)(47776003)(5660300001)(66066001)(8936002)(6666003)(478600001)(6916009)(486006)(93886005)(55016002)(316002)(4326008)(33896004)(476003)(16586007)(76176011)(44832011)(68736007)(23726003)(53546011)(386003)(53936002)(6246003)(97736004)(2906002)(3846002)(6116002)(54906003)(58126008)(11346002)(6496006)(1076002)(33716001)(446003)(7416002)(305945005)(7736002)(25786009)(52116002)(9686003)(956004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4995; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4995; 23:RrwnPKPfUAvSAE9giZYV10alJ5293Q2Jj7OGA/2ah?= =?us-ascii?Q?NAcLwTiy0h396pFMfe2dMOX3XSQ8DDvODAJvMZkraGdfWJgzJDxJ6H9mh3S2?= =?us-ascii?Q?XtVMvmPWU9KxhtX8rVOI6UEO4wZ99jF43BOPrZ6/LxRkpqVu4bAGrHArA0Oz?= =?us-ascii?Q?53+60Ttaacg5MibdFgkqgT/HGS6k5q8QGPK2Zu6VA9L17MkzAkPpT9PrXFlT?= =?us-ascii?Q?XuZoMa4hunwpiILoiiirLyPiNrtvMt8Xh1Gp0kF9+QBegCL5Kys4h6uQ/XaE?= =?us-ascii?Q?1iqDFXfiN7PcYMOsbueXrW52s/jS1ssrFzEfsotgDVwPbwNbJ8P+PEA3IydP?= =?us-ascii?Q?txnqB35qKv/XjL91tGRSBzTYo7h8mlHPcW4u9lkL/IuldLZh54si7mNgVoiJ?= =?us-ascii?Q?nUHggiLrJueuiqSzeRP6XY2UHzFT+VcSWHC4MjwtA8Mi1CfECLZqQQkVEgwY?= =?us-ascii?Q?XwPTItBRrND1jFHivT5JmhLchC1XQ/uYJORszezuBSkx7MpaVH3QNT0eglZS?= =?us-ascii?Q?pU/28ryoMmnqzP0PMvUyheiAG/OPrVZlN6OuzQwfBWqDLxVy8hRoxzdsiP6X?= =?us-ascii?Q?6t3JIzvgwGn3Wte0B2LqgiRZK27L5X2UQ4J4t4mWm2UDGD6jn+W2bkGJKcpH?= =?us-ascii?Q?cLjpAkpFWyEamF4hy3tsKj6BuAnxMtfODqxfC5YJo9alLxP4keICAxpzswRw?= =?us-ascii?Q?mp7v/4hSW56IIh3ZMcK2D9XnELUlH1W5fV9Y303KkqmYAJ8ituKO4bN4XHk/?= =?us-ascii?Q?HWekApbZkXjr6bxvsKTSYHBsNAdlA1XNb/egGKrLy/Cs8pCbeNU57JfIWS8c?= =?us-ascii?Q?QhZwIaReA5YSxfaj81rRs5uBuK8Pd0W1upKtwd23lu/r69NAlChe/H9919NE?= =?us-ascii?Q?dhg4cM0LIpjkfWhuJE/Pe36NaI3eNDDhMrd6VsDihMjf1N+8Uf3qjZCGoTqC?= =?us-ascii?Q?Y//NDZoDpidCMBgyKTIPY/o31+79klYsKn6r2Y8TtrrajIc5jHfVMlRPrRLw?= =?us-ascii?Q?irxgKkZxiHgg0yxjDHl4ZGSMkehXAEHx3B7AsBJ/gRAxYsxoaIwg+L5eP+6T?= =?us-ascii?Q?mZY+nFTqB++9UIMpht4CEm0O3NxXKGfwCOA4VWd0ec8EWBADTEelmt3R5fYv?= =?us-ascii?Q?0rJ1kV3o8PrryNfjuAvhAKMfasXJOz5TNl33brzzwpHVw2VteJXT9DLYat1D?= =?us-ascii?Q?3VxpvpohYBqxZJUADy+F6lV6ak6lFuafOdb80Pm/DfzlRXFNA923fxPlQtY5?= =?us-ascii?Q?wpkyJ+bxNq5I628lv2sRZYTyWUrJ7dfZh4B653P1pEgSaUOQ9j+rtuGQUuy/?= =?us-ascii?Q?EKp3QKKvN+SzbPZj+hxypuzC460BZFqhwpZ1AvEyA+Ay/s7/YlPcWciH4kHF?= =?us-ascii?Q?84+u0/N1BYY3abZmKRXDbDIQ18n/qa35LqzWyIP/pa5YvaOKhBS/YAbnd2ql?= =?us-ascii?Q?pI+CNs3xsQ1PaF0XNt+1RbKZEkGuWQ=3D?= X-Microsoft-Antispam-Message-Info: kplbGFYrNha+NGtgiDhN/nwUwdAKTENhfBokQrZ1Zl4RlgS/WpmbLryHcLfWBKnBA0i4/FV1k1CKH63q8HX6iy7FytsL04wgqJr//CQNSFZVMMvz61xB2WUyRLNxGooq1d7JQsDnJT0/ofoFEj2fe6x4o8BEnaqRom7uDBpH1Gnh2jRcG5LQz9MiGp/EV8yOpvz6gjTikFkbZkmGDzbJgQ3yjGsz1ltJXrAizTsOAMmw4jxUNOzpzC2DCPeokyvUsyHe2oqDgdl0Hv+hAfjW0RCuCvDUzZydrPWu9z3m73LLTcVQZtBaBAyn9YW3VPWPYz704jLvscltX6rw+NnHwrzwBtt+VgSWW1/jvpQsrhc= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4995; 6:q25oAeOEHFRKPWteVkANSTPJXFQl+lvEopPeH5f3kSyA5xn7dpuoahE+EUowIi/57BKqy8HpCePNdLgmGKFlFAmzTnT9GSx9D8KWZ2RQoEb8ORZqLx+/sq6H8DMNZoHqSiLzguRCYMejPDj9l0+UX+VeVWGHQmI7GiZobm9iJqrXCuCFyxA1gHKg5rTxMG5e9+xsWdN6YJlfHX7i8UcoWpt0+N1OekGO3ZDTnEK5GW6amvG6I/7j0pVq4B2E24Tw0obk6mk6ZuC7sWpJOn3b/bRv/P8wWoceK9OX3y8VBGRha5vZY7/Uw/apOQX0FBInK6blGYHJ15SajvktZCOFSLKIkIyvlCq2ah4YI2tuaRQeoLciEe/wJkByauuIHUuC9u/9UpBTV2gu+vHdgIf0cYf5M+Ij6FsdXHyCXg1qHe8pijTdPyYcOyQKKWQpYlGnbG1zzvnBOPUONpLUlc+Bow==; 5:2KNaoDIMWXHPGyw7ukB0K8jQ34g0hOhKyz05cliCJUiLo+3k3Rn89TVxyeS6+zQmGcEP5cx+SYnTeGjENDvTVCgpeGxPb7tUVancBnjb7SDLQvylmj40WT3FZ85fRX7z0NM4QaSJcX7iF1ETabqLAWRdulcvA366uwPetjZYQXc=; 7:hc79wbIHnTpBX4L8fSIx2YTrs1upi0g62z4oo0aQuRwNyl6TQoTPcmIIhmCZeYm3ChR6sR1Ck/bVdHYnG+P3hsmluaLxUTRzSh7ckk5OOIro8aY3l77vkSKXgt+LLAx7tqy3hgL4z9EkMLRA+GUdBTGkv578MPLI45KHxu/yZaWbgV+lg+x5P59+BlqSbxMOZ+I94nU/iN2TpaHNoreLb4feHhv72KbsfCreoK0He12Cxbo7l6tvgo5CoFB6u3SZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2018 12:25:23.2153 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 872eef39-53ea-4835-60f8-08d62d1921a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4995 Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 12:25:30 -0000 -----Original Message----- > Date: Mon, 8 Oct 2018 13:13:31 +0100 > From: Ferruh Yigit > To: Jerin Jacob > CC: Thomas Monjalon , "Ananyev, Konstantin" > , Andrew Rybchenko > , "Lu, Wenzhuo" , "Wu, > Jingjing" , "Iremonger, Bernard" > , "Mcnamara, John" , > "Kovacevic, Marko" , Olivier Matz > , "dev@dpdk.org" , > "shahafs@mellanox.com" , "didier.pallard@6wind.com" > > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > checksum definition > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > Thunderbird/52.9.1 > > On 10/8/2018 12:55 PM, Jerin Jacob wrote: > > -----Original Message----- > >> Date: Mon, 8 Oct 2018 11:53:01 +0100 > >> From: Ferruh Yigit > >> To: Jerin Jacob , Thomas Monjalon > >> > >> CC: "Ananyev, Konstantin" , Andrew Rybchenko > >> , "Lu, Wenzhuo" , "Wu, > >> Jingjing" , "Iremonger, Bernard" > >> , "Mcnamara, John" , > >> "Kovacevic, Marko" , Olivier Matz > >> , "dev@dpdk.org" , > >> "shahafs@mellanox.com" , "didier.pallard@6wind.com" > >> > >> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > >> checksum definition > >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 > >> Thunderbird/52.9.1 > >> > >> On 10/8/2018 10:37 AM, Jerin Jacob wrote: > >>> -----Original Message----- > >>>> Date: Mon, 08 Oct 2018 11:04:51 +0200 > >>>> From: Thomas Monjalon > >>>> To: Jerin Jacob , Ferruh Yigit > >>>> , "Ananyev, Konstantin" > >>>> > >>>> Cc: Andrew Rybchenko , "Lu, Wenzhuo" > >>>> , "Wu, Jingjing" , > >>>> "Iremonger, Bernard" , "Mcnamara, John" > >>>> , "Kovacevic, Marko" , > >>>> Olivier Matz , "dev@dpdk.org" , > >>>> "shahafs@mellanox.com" , "didier.pallard@6wind.com" > >>>> > >>>> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP > >>>> checksum definition > >>>> > >>>> 08/10/2018 10:24, Jerin Jacob: > >>>>> From: Ferruh Yigit > >>>>>> On 10/6/2018 1:18 PM, Ananyev, Konstantin wrote: > >>>>>>> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > >>>>>>>> From: Thomas Monjalon > >>>>>>>>> However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD. > >>>>>>>> > >>>>>>>> Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD > >>>>>>>> definition? > >>>>>>>> > >>>>>>>> I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and mbuf > >>>>>>>> maintainers in this list. So what else I need make forward progress > >>>>>>>> on this patch? > >>>>>>>> > >>>>>>>> I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It > >>>>>>>> is safe to assume that ALL HW can support CKSUM BAD if the feature is > >>>>>>>> available and hence it is more portable. > >>>>>>> > >>>>>>> Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM. > >>>>>> > >>>>>> Switching to two bit won't reduce the portability, HW supports only reporting > >>>>>> CKSUM_BAD can set BAD || UNKNOWN. > >>>>> > >>>>> UNKNOWN is not a bit. It is represented as 0. It spec has 2 bit, then > >>>>> driver need to report GOOD as well. > >>>>> > >>>>> Same applies for PKT_RX_EL4_CKSUM as well. > >>>>> > >>>>>> > >>>>>> And I think patch is not blocked by PKT_RX_EIP_CKSUM_BAD, it can be changed > >>>>>> separately, for this patch question is can we represent PKT_RX_EL4_CKSUM_* with > >>>>>> two bits, to have BAD/GOOD/UNKNOWN? > >>>> > >>>> Yes, exact. > >>>> > >>>> PKT_RX_EIP_CKSUM_BAD must be left aside. > >>>> We should just avoid taking it as a reference. > >>>> And we can reconsider its definition later. > >>> > >>> OK. > >>> > >>> IMO, Using 2 bit scheme for tunneled checksum has following performance > >>> issue from driver side. > >>> > >>> Driver need to mark the packet as GOOD. All the HW can support > >>> detection of BAD. That not necessary mean GOOD in case of tunnel packet, > >>> so driver has to detect the packet is tunneled and packet is not BAD > >>> then mark GOOD. > >> > >> Yes UNKNOWN is not a bit, but a state, why don't use it? Why driver has to check > >> it is GOOD? > > > > The application is going to check is it GOOD or not. Not the driver, > > Right? My concern was, If application starts dropping the packet instead checking the BAD, if > > it checks == !GOOD. > > Got it, but when 2 bits state introduced, app should check if check == BAD for > drop decision, because it is not GOOD || BAD anymore. Got it. > > > > >> > >> 0x0 => UNKNOWN > >> 0x1 => BAD > >> 0x2 => GOOD > >> 0x3 => ? (invalid perhaps) > >> > >> HW that supports detecting good packets can set BAD || GOOD state, HW can detect > >> only BAD packet can set BAD || UNKNOWN state. > >> > >> If BAD is not set, there is an ambiguity of state, lets clarify it in lower > >> level, if it is UNKNOWN, let application know it is UNKNOWN. > > > > OK. > > > > How about the following then? > > > > /** > > * Mask of bits used to determine the status of outer RX L4 checksum. > > * - PKT_RX_EL4_CKSUM_UNKNOWN: no information about the outer RX L4 checksum > > * - PKT_RX_EL4_CKSUM_BAD: the outer L4 checksum in the packet is wrong > > * - PKT_RX_EL4_CKSUM_GOOD: the outer L4 checksum in the packet is valid > > * - PKT_RX_EL4_CKSUM_INVALID: invalid outer L4 checksum state. > > * > > * The detection of PKT_RX_EL4_CKSUM_GOOD shall be based on the given > > * HW capability, At minimum, the PMD should support > > * PKT_RX_EL4_CKSUM_UNKNOWN and PKT_RX_EL4_CKSUM_BAD states > > * if the offload is available. > > */ > > #define PKT_RX_EL4_CKSUM_MASK ((1ULL << 21) | (1ULL << 22)) > > > > #define PKT_RX_IP_CKSUM_UNKNOWN 0 > > #define PKT_RX_IP_CKSUM_BAD (1ULL << 21) > > #define PKT_RX_IP_CKSUM_GOOD (1ULL << 22) > > #define PKT_RX_IP_CKSUM_INVALID ((1ULL << 21) | (1ULL << 22)) > > Looks good to me. If there is no objection with above flag definition, I will send the v3 with that. > > > > > > > > >