From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 496865F16 for ; Mon, 8 Oct 2018 23:45:19 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id y11-v6so7485592plt.3 for ; Mon, 08 Oct 2018 14:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DnI/tx9j2pCBb22iFZz0crTs42dk14KI06IZyBeOdJU=; b=AHN0Oi5vF7Z7zg1bc5baNK98DKY4vQ/lzyAGc7T0zfKe9c+Cl83sh0ga3lEIfHeZV+ +/hz4ZEDd28dy40EQ2nJlnQeOPvUi6fZbOxuSM2orVNqEhBajDAEqU3Fmk5m80jd6igv Fi5vJamvSc/nsV+al2cWu1/ji1Pcn3H4R9czLF71ONfBlvYWQBqtmq3tKQDzJCxxaODU 39i0RFR2XGrlNQVz8x4U96ZdsQk9pxsXcVMlQ69X4yQ2u3pO2Sa3BPvBRt3zEOG4/mYx G8p+UhFsywkJjWww3G4muVkNf1cy24ytm7J5NbwdV9uK4h4bYTYYMhS7hUpPyWdpPNoX TOPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DnI/tx9j2pCBb22iFZz0crTs42dk14KI06IZyBeOdJU=; b=thz1ZN+4lV57fO6NX4FnOe4rjF5DxSQt6LNPLmbxJRuoroZeVTTtggJVRKQW82UiVL gxphzG5wnea6esnnZys/vE29AOZ4n20RLJeeqsLGH4FtHryN6PJew4xnBjLWBUxy/qLQ cMlzeWXMr265kSOvNCB64pqhNz0sGwbFdio7IsQAOd8S/4e21oYG+UsFITyq0T2SlkiN wAWo9UnvOuQ9xvK2MqgNCImPcnUu4DydCeNm/Ys2/8/K84CVBtpiDLavwzKkaEpDRvjm HOcOmNQmiKtaLJ1lCQEoJEd01E5QElMA9Ctsji3BUdMWaIOpbg6W4Wbz2aLTPYhpghMT 9fcA== X-Gm-Message-State: ABuFfojIqY+ZpndG7UBL7i24opgW+gRY4J4NwrFljGtezkv+A0DvszjW BFGQxYn++40/0EhCzpGxKPgt4A== X-Google-Smtp-Source: ACcGV60WZz1U7LqfuwxAaVDm1SlfO6NSivj62dEO8v+DBU+440861Kdl8vhtGtwVlQ7YogA34qG81g== X-Received: by 2002:a17:902:d715:: with SMTP id w21-v6mr25064517ply.143.1539035118327; Mon, 08 Oct 2018 14:45:18 -0700 (PDT) Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id d18-v6sm36690952pfk.163.2018.10.08.14.45.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Oct 2018 14:45:18 -0700 (PDT) Date: Mon, 8 Oct 2018 14:45:09 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com Message-ID: <20181008144509.3c3a5933@xeon-e3> In-Reply-To: <20181007093244.20659-1-thomas@monjalon.net> References: <20180907222727.20521-1-thomas@monjalon.net> <20181007093244.20659-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 0/5] eal: simplify devargs and hotplug functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 21:45:19 -0000 On Sun, 7 Oct 2018 11:32:39 +0200 Thomas Monjalon wrote: > This is a follow-up of an idea presented at Dublin > during the "hotplug talk". > > Instead of changing the existing hotplug functions, as in the RFC, > some new experimental functions are added. > The old functions lose their experimental status in order to provide > a non-experimental replacement for deprecated attach/detach functions. > > It has been discussed briefly in the latest technical board meeting. > > > Changes in v6 - after Gaetan's review: > - bump ABI version of all buses (because of rte_device change) > - unroll snprintf loop in rte_eal_hotplug_add > > Changes in v5: > - rte_devargs_remove is fixed in case of null devargs (patch 2) > - a pointer to the bus is added in rte_device (patch 3) > - rte_dev_remove is fixed in case of no devargs (patch 5) > > Changes in v4 - after Andrew's review: > - add API changes in release notes (patches 1 & 2) > - fix memory leak in rte_eal_hotplug_add (patch 4) > > Change in v3: > - fix null dereferencing in error path (patch 2) > > > Thomas Monjalon (5): > devargs: remove deprecated functions > devargs: simplify parameters of removal function > eal: add bus pointer in device structure > eal: remove experimental flag of hotplug functions > eal: simplify parameters of hotplug functions > > doc/guides/rel_notes/release_18_11.rst | 23 ++++-- > drivers/bus/dpaa/Makefile | 2 +- > drivers/bus/dpaa/dpaa_bus.c | 2 + > drivers/bus/dpaa/meson.build | 2 + > drivers/bus/fslmc/Makefile | 2 +- > drivers/bus/fslmc/fslmc_bus.c | 2 + > drivers/bus/fslmc/meson.build | 2 + > drivers/bus/ifpga/Makefile | 2 +- > drivers/bus/ifpga/ifpga_bus.c | 6 +- > drivers/bus/ifpga/meson.build | 2 + > drivers/bus/pci/Makefile | 2 +- > drivers/bus/pci/bsd/pci.c | 2 + > drivers/bus/pci/linux/pci.c | 1 + > drivers/bus/pci/meson.build | 2 + > drivers/bus/pci/private.h | 2 + > drivers/bus/vdev/Makefile | 2 +- > drivers/bus/vdev/meson.build | 2 + > drivers/bus/vdev/vdev.c | 9 +-- > drivers/bus/vmbus/Makefile | 2 +- > drivers/bus/vmbus/linux/vmbus_bus.c | 1 + > drivers/bus/vmbus/meson.build | 2 + > drivers/bus/vmbus/private.h | 3 + > drivers/net/failsafe/failsafe_eal.c | 3 +- > drivers/net/failsafe/failsafe_ether.c | 3 +- > lib/librte_eal/common/eal_common_dev.c | 90 +++++++++++++-------- > lib/librte_eal/common/eal_common_devargs.c | 41 ++-------- > lib/librte_eal/common/include/rte_dev.h | 36 +++++++-- > lib/librte_eal/common/include/rte_devargs.h | 81 +------------------ > lib/librte_eal/rte_eal_version.map | 10 +-- > 29 files changed, 155 insertions(+), 184 deletions(-) > I like these changes. Reviewed-by: Stephen Hemminger I noticed there is only minimal places that devargs appear in the documentation. The relationship between whitelist and devargs is not obvious for new users. The one place is in the documentation of the documentation! So you want to pull rte_eth_dev_attach from documentation.rst.