From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com
[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id AFD141B57F
for <dev@dpdk.org>; Tue, 9 Oct 2018 17:07:20 +0200 (CEST)
Received: by mail-pg1-f196.google.com with SMTP id g2-v6so944729pgu.11
for <dev@dpdk.org>; Tue, 09 Oct 2018 08:07:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=BboN2/1XgS+XfmOcK9HsCVELBCd6/AKkio12yP+DMow=;
b=asbZieQZYB+AaR0TNaV8wdRkNSDxuHd9FSo7snu98rGL6tuyj5qfxAVy5zaoVd9K7b
SNTxZjMLv9dfNvHfxV1t67Ed1iz8tgTHA7qi9FceWPMJO/Kj63jPJdz9w1YfnqEgp/F4
hnE73Kv49bxcseYvA42Dhh3suNR2yU38V70QGjDMu3gh9dxpq+HpGC+Ku6E1kwrR4MzH
KPh55pEcssz0Dx1YibZZ9kXh5QsJDcJjG+m+9nlKJg2byX6JjyhqJzqXQMo7mg9NdECt
/dF78EeWMC0pbb8bvA2rOrNfqotaI3HcEZ1UxezsKPat4JlvMF7M6bCtklkrx2bXf3BJ
WBqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=BboN2/1XgS+XfmOcK9HsCVELBCd6/AKkio12yP+DMow=;
b=H5LAXKsByo9obHmZzCLt7u7N8iXFul2a+GEE/jDOvfRNSqq9bPEezs0LMfofpLoY8A
cJUer1s6vdFfDcP3Mov9FhgSzCZOID5yt2umHxGIGJJesos3+87I13iM+u0f+nHH6DI3
fgciMN/Mxa4bmmQYfUdRECyo+OZ8r+Yh1BwXgGQ3FY1/FTRae0hq97UuSvbABSCH+ZMS
03Ce7QsinSPQqW4ZDPe9QP4ORTOdcSR1rzKb5gRDGJ9RZWteYTHKWjOuZhO4LdRGuCgo
JjHV27xnoZIC6iu2JSLOTRMZfOaTnUvNI8pIKPdvPF7zPsBW7BpjqSDJBHkKCcbbvu1S
Ealw==
X-Gm-Message-State: ABuFfoiugNDk0B/TPEZoKozDAP2Hn3LOLPHm+umD0dMJQTgkvz7cr1wA
4x7SXS26b1E+Ea1h/izkAeBRKQ==
X-Google-Smtp-Source: ACcGV61nwqWIETPJMV4SpxUyNF+Rknr1oezKxQJcJK4eV/MxUCxAFqQkYqpNjRoomoSoEWyXAK4fhw==
X-Received: by 2002:a62:1f9d:: with SMTP id
l29-v6mr30016304pfj.121.1539097639546;
Tue, 09 Oct 2018 08:07:19 -0700 (PDT)
Received: from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id d2-v6sm15009797pfj.122.2018.10.09.08.07.19
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 09 Oct 2018 08:07:19 -0700 (PDT)
Date: Tue, 9 Oct 2018 08:07:11 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur
<somnath.kotur@broadcom.com>, Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>, Matan Azrad <matan@mellanox.com>,
dev@dpdk.org, stable@dpdk.org
Message-ID: <20181009080711.07236f72@xeon-e3>
In-Reply-To: <20181009115238.91288-1-ferruh.yigit@intel.com>
References: <20181009115238.91288-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] drivers/net: fix log type string
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Oct 2018 15:07:21 -0000
On Tue, 9 Oct 2018 12:52:38 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
>
> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 88e026c7d..858e65d00 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>
> RTE_INIT(bnxt_init_log)
> {
> - bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
> + bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
> if (bnxt_logtype_driver >= 0)
> rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
> }
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index a7b592eed..544e0cde4 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3598,7 +3598,7 @@ int bond_logtype;
>
> RTE_INIT(bond_init_log)
> {
> - bond_logtype = rte_log_register("pmd.net.bon");
> + bond_logtype = rte_log_register("pmd.net.bond");
> if (bond_logtype >= 0)
> rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
> }
> diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
> index 48717f2f0..16303ef5e 100644
> --- a/drivers/net/vdev_netvsc/vdev_netvsc.c
> +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
> @@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
> /** Initialize driver log type. */
> RTE_INIT(vdev_netvsc_init_log)
> {
> - vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
> + vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
> if (vdev_netvsc_logtype >= 0)
> rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
> }
Thanks for making drivers consistent.
Did you check the documentation?
Acked-by: Stephen Hemminger <stephen@networkplumber.org>