* [dpdk-dev] [PATCH] drivers/net: fix log type string
@ 2018-10-09 11:52 Ferruh Yigit
2018-10-09 15:07 ` Stephen Hemminger
2018-10-09 17:38 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
0 siblings, 2 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-10-09 11:52 UTC (permalink / raw)
To: Ajit Khaparde, Somnath Kotur, Declan Doherty, Chas Williams, Matan Azrad
Cc: dev, Ferruh Yigit, stable
Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 88e026c7d..858e65d00 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
RTE_INIT(bnxt_init_log)
{
- bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
+ bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
if (bnxt_logtype_driver >= 0)
rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
}
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index a7b592eed..544e0cde4 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3598,7 +3598,7 @@ int bond_logtype;
RTE_INIT(bond_init_log)
{
- bond_logtype = rte_log_register("pmd.net.bon");
+ bond_logtype = rte_log_register("pmd.net.bond");
if (bond_logtype >= 0)
rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
}
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index 48717f2f0..16303ef5e 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
/** Initialize driver log type. */
RTE_INIT(vdev_netvsc_init_log)
{
- vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
+ vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
if (vdev_netvsc_logtype >= 0)
rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] drivers/net: fix log type string
2018-10-09 11:52 [dpdk-dev] [PATCH] drivers/net: fix log type string Ferruh Yigit
@ 2018-10-09 15:07 ` Stephen Hemminger
2018-10-09 16:31 ` Ferruh Yigit
2018-10-09 17:38 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2018-10-09 15:07 UTC (permalink / raw)
To: Ferruh Yigit
Cc: Ajit Khaparde, Somnath Kotur, Declan Doherty, Chas Williams,
Matan Azrad, dev, stable
On Tue, 9 Oct 2018 12:52:38 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
>
> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 88e026c7d..858e65d00 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>
> RTE_INIT(bnxt_init_log)
> {
> - bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
> + bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
> if (bnxt_logtype_driver >= 0)
> rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
> }
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index a7b592eed..544e0cde4 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3598,7 +3598,7 @@ int bond_logtype;
>
> RTE_INIT(bond_init_log)
> {
> - bond_logtype = rte_log_register("pmd.net.bon");
> + bond_logtype = rte_log_register("pmd.net.bond");
> if (bond_logtype >= 0)
> rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
> }
> diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
> index 48717f2f0..16303ef5e 100644
> --- a/drivers/net/vdev_netvsc/vdev_netvsc.c
> +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
> @@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
> /** Initialize driver log type. */
> RTE_INIT(vdev_netvsc_init_log)
> {
> - vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
> + vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
> if (vdev_netvsc_logtype >= 0)
> rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
> }
Thanks for making drivers consistent.
Did you check the documentation?
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] drivers/net: fix log type string
2018-10-09 15:07 ` Stephen Hemminger
@ 2018-10-09 16:31 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-10-09 16:31 UTC (permalink / raw)
To: Stephen Hemminger
Cc: Ajit Khaparde, Somnath Kotur, Declan Doherty, Chas Williams,
Matan Azrad, dev, stable
On 10/9/2018 4:07 PM, Stephen Hemminger wrote:
> On Tue, 9 Oct 2018 12:52:38 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
>>
>> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
>> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
>> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>> drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
>> drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
>> index 88e026c7d..858e65d00 100644
>> --- a/drivers/net/bnxt/bnxt_ethdev.c
>> +++ b/drivers/net/bnxt/bnxt_ethdev.c
>> @@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
>>
>> RTE_INIT(bnxt_init_log)
>> {
>> - bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
>> + bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
>> if (bnxt_logtype_driver >= 0)
>> rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
>> }
>> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
>> index a7b592eed..544e0cde4 100644
>> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
>> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
>> @@ -3598,7 +3598,7 @@ int bond_logtype;
>>
>> RTE_INIT(bond_init_log)
>> {
>> - bond_logtype = rte_log_register("pmd.net.bon");
>> + bond_logtype = rte_log_register("pmd.net.bond");
>> if (bond_logtype >= 0)
>> rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
>> }
>> diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
>> index 48717f2f0..16303ef5e 100644
>> --- a/drivers/net/vdev_netvsc/vdev_netvsc.c
>> +++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
>> @@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
>> /** Initialize driver log type. */
>> RTE_INIT(vdev_netvsc_init_log)
>> {
>> - vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
>> + vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
>> if (vdev_netvsc_logtype >= 0)
>> rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
>> }
>
> Thanks for making drivers consistent.
> Did you check the documentation?
Description seems correct:
http://doc.dpdk.org/guides/contributing/coding_style.html#dynamic-logging
But "1.9.1. Specializations" needs an update, I will send a new version.
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] drivers/net: fix log type string
2018-10-09 11:52 [dpdk-dev] [PATCH] drivers/net: fix log type string Ferruh Yigit
2018-10-09 15:07 ` Stephen Hemminger
@ 2018-10-09 17:38 ` Ferruh Yigit
2018-10-11 10:48 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: Ferruh Yigit @ 2018-10-09 17:38 UTC (permalink / raw)
To: John McNamara, Marko Kovacevic, Hemant Agrawal, Shreyansh Jain,
Ajit Khaparde, Somnath Kotur, Declan Doherty, Chas Williams,
Matan Azrad
Cc: dev, Ferruh Yigit, stable
Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
Fixes: 7db274b9ada2 ("doc: describe dynamic logging format")
Fixes: a10a988a0ba6 ("net/dpaa2: support dynamic logging")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2:
* update doc too
---
doc/guides/contributing/coding_style.rst | 4 ++--
doc/guides/nics/dpaa2.rst | 2 +-
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-
drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst
index b1bf0d15c..19445c113 100644
--- a/doc/guides/contributing/coding_style.rst
+++ b/doc/guides/contributing/coding_style.rst
@@ -741,8 +741,8 @@ A specialization looks like this:
* PF/VF mailbox output: ``type.section.name.mbox``
A real world example is the i40e poll mode driver which exposes two
-specializations, one for initialization ``pmd.i40e.init`` and the other for
-the remaining driver logs ``pmd.i40e.driver``.
+specializations, one for initialization ``pmd.net.i40e.init`` and the other for
+the remaining driver logs ``pmd.net.i40e.driver``.
Note that specializations have no formatting rules, but please follow
a precedent if one exists. In order to see all current log topics and
diff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst
index 66c03e103..e2f385d42 100644
--- a/doc/guides/nics/dpaa2.rst
+++ b/doc/guides/nics/dpaa2.rst
@@ -558,7 +558,7 @@ which are lower than logging ``level``.
<dpdk app> <EAL args> --log-level=pmd.net.dpaa2:<level> -- ...
-Using ``pmd.dpaa2`` as log matching criteria, all PMD logs can be enabled
+Using ``pmd.net.dpaa2`` as log matching criteria, all PMD logs can be enabled
which are lower than logging ``level``.
Whitelisting & Blacklisting
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 88e026c7d..858e65d00 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)
RTE_INIT(bnxt_init_log)
{
- bnxt_logtype_driver = rte_log_register("pmd.bnxt.driver");
+ bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
if (bnxt_logtype_driver >= 0)
rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
}
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index a7b592eed..544e0cde4 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3598,7 +3598,7 @@ int bond_logtype;
RTE_INIT(bond_init_log)
{
- bond_logtype = rte_log_register("pmd.net.bon");
+ bond_logtype = rte_log_register("pmd.net.bond");
if (bond_logtype >= 0)
rte_log_set_level(bond_logtype, RTE_LOG_NOTICE);
}
diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c
index 48717f2f0..16303ef5e 100644
--- a/drivers/net/vdev_netvsc/vdev_netvsc.c
+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c
@@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,
/** Initialize driver log type. */
RTE_INIT(vdev_netvsc_init_log)
{
- vdev_netvsc_logtype = rte_log_register("pmd.vdev_netvsc");
+ vdev_netvsc_logtype = rte_log_register("pmd.net.vdev_netvsc");
if (vdev_netvsc_logtype >= 0)
rte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] drivers/net: fix log type string
2018-10-09 17:38 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
@ 2018-10-11 10:48 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-10-11 10:48 UTC (permalink / raw)
To: John McNamara, Marko Kovacevic, Hemant Agrawal, Shreyansh Jain,
Ajit Khaparde, Somnath Kotur, Declan Doherty, Chas Williams,
Matan Azrad
Cc: dev, stable
On 10/9/2018 6:38 PM, Ferruh Yigit wrote:
> Syntax for log type string is "pmd.<subsystem>.<driver>[.<pmd_local>]"
>
> Fixes: 3e92fd4e4ec0 ("net/bnxt: use dynamic log type")
> Fixes: d7f4562ab10a ("net/bonding: convert to dynamic logging")
> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
> Fixes: 7db274b9ada2 ("doc: describe dynamic logging format")
> Fixes: a10a988a0ba6 ("net/dpaa2: support dynamic logging")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-11 10:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 11:52 [dpdk-dev] [PATCH] drivers/net: fix log type string Ferruh Yigit
2018-10-09 15:07 ` Stephen Hemminger
2018-10-09 16:31 ` Ferruh Yigit
2018-10-09 17:38 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-10-11 10:48 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).