From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 068127CD2 for ; Tue, 9 Oct 2018 10:59:41 +0200 (CEST) Received: from rsa59-2-82-233-193-189.fbx.proxad.net ([82.233.193.189] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1g9nsp-0003h4-29; Tue, 09 Oct 2018 11:00:52 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Tue, 09 Oct 2018 10:59:37 +0200 Date: Tue, 9 Oct 2018 10:59:37 +0200 From: Olivier Matz To: Ferruh Yigit Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Beilei Xing , Qi Zhang , dev@dpdk.org, Hyong Youb Kim , John Daley Message-ID: <20181009085937.ztlmsacrglkehrgk@platinum> References: <20181002113642.83514-1-ferruh.yigit@intel.com> <20181003151912.81959-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181003151912.81959-1-ferruh.yigit@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3] mbuf: clarify QINQ flag usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 08:59:41 -0000 On Wed, Oct 03, 2018 at 04:19:12PM +0100, Ferruh Yigit wrote: > Update implementation that when PKT_RX_QINQ_STRIPPED mbuf ol_flags > set by PMD, PKT_RX_QINQ, PKT_RX_VLAN_STRIPPED & PKT_RX_VLAN > should be also set. > > Clarify mbuf documentations that when PKT_RX_QINQ set PKT_RX_VLAN also > should be set. > > So that appllication can rely on PKT_RX_QINQ flag to access both > mbuf.vlan_tci & mbuf.vlan_tci_outer > > Signed-off-by: Ferruh Yigit > Reviewed-by: Andrew Rybchenko Acked-by: Olivier Matz