From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8]) by dpdk.org (Postfix) with ESMTP id C79431B57C for ; Tue, 9 Oct 2018 20:34:53 +0200 (CEST) Received: from localhost (scalar.blr.asicdesigners.com [10.193.185.94]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w99IYice024361; Tue, 9 Oct 2018 11:34:45 -0700 Date: Wed, 10 Oct 2018 00:04:30 +0530 From: Rahul Lakkireddy To: Ferruh Yigit Cc: "dev@dpdk.org" , Indranil Choudhury , Nirranjan Kirubaharan , Thomas Monjalon Message-ID: <20181009183425.GA17233@chelsio.com> References: <1537777765-16798-1-git-send-email-rahul.lakkireddy@chelsio.com> <0093e5e2-2187-ff9e-53f6-041af4074018@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0093e5e2-2187-ff9e-53f6-041af4074018@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 18:34:54 -0000 On Tuesday, October 10/09/18, 2018 at 20:19:54 +0530, Ferruh Yigit wrote: > On 9/24/2018 9:29 AM, Rahul Lakkireddy wrote: > > This action is useful for offloading loopback mode, where the hardware > > will swap source and destination MAC addresses in the outermost Ethernet > > header before looping back the packet. This action can be used in > > conjunction with other rewrite actions to achieve MAC layer transparent > > NAT where the MAC addresses are swapped before either the source or > > destination MAC address is rewritten and NAT is performed. > > > > Must be used with a valid RTE_FLOW_ITEM_TYPE_ETH flow pattern item. > > Otherwise, RTE_FLOW_ERROR_TYPE_ACTION error should be returned by the > > PMDs. > > > > Original work by Shagun Agrawal > > Do you consider adding his sign off too, that is more formal way we do? > > If would like to update we can do it on the next-net before it get pulled. > Shagun is no longer working for Chelsio. He had done the original implementation and I've re-spun the series incorporating review comments. I couldn't add his Signed-off-by without his permission on the later revision series. Hence, the reason for "Original work by" line above. > > > > Signed-off-by: Rahul Lakkireddy > > Thanks, Rahul