From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8727C1B195 for ; Thu, 11 Oct 2018 15:02:19 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 06:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,368,1534834800"; d="scan'208";a="240472335" Received: from btwcube1.sh.intel.com (HELO debian) ([10.67.104.158]) by orsmga004.jf.intel.com with ESMTP; 11 Oct 2018 06:02:17 -0700 Date: Thu, 11 Oct 2018 21:01:01 +0800 From: Tiwei Bie To: Luca Boccassi Cc: Thomas Monjalon , dev@dpdk.org, maxime.coquelin@redhat.com, zhihong.wang@intel.com, bruce.richardson@intel.com, brian.russell@intl.att.com Message-ID: <20181011130100.GA628@debian> References: <20180827165240.28322-1-bluca@debian.org> <20180828101240.12597-1-bluca@debian.org> <20180828101240.12597-2-bluca@debian.org> <2276842.FSxJgd8eX6@xps> <1539255192.8721.31.camel@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1539255192.8721.31.camel@debian.org> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v6 2/2] net/virtio: fix PCI config err handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 13:02:20 -0000 On Thu, Oct 11, 2018 at 11:53:12AM +0100, Luca Boccassi wrote: > On Thu, 2018-10-11 at 12:27 +0200, Thomas Monjalon wrote: > > 28/08/2018 12:12, Luca Boccassi: > > > From: Brian Russell > > > > > > In virtio_read_caps and vtpci_msix_detect, rte_pci_read_config > > > returns > > > the number of bytes read from PCI config or < 0 on error. > > > If less than the expected number of bytes are read then log the > > > failure and return rather than carrying on with garbage. > > > > > > Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") > > > > > > Signed-off-by: Brian Russell > > > Signed-off-by: Luca Boccassi > > > --- > > > v2: handle additional rte_pci_read_config incomplete reads > > > v3: do not handle rte_pci_read_config of virtio cap, added in v2, > > >     as it's less clear what the right thing to do there is > > > v4: do a more robust check - first check what the vendor is, and > > >     skip the cap entirely if it's not what we are looking for. > > > v5: fetch only 2 flags bytes if the vndr is PCI_CAP_ID_MSIX > > > v6: fix 32bit build by changing the printf format specifier, fix > > > patch title > > > > Tiwei did a comment on v5 and provided his Reviewed-by. > > Is it OK to apply v6 with its tag? > > All is fixed? > > Hi, > > The title has been fixed (virtio -> net/virtio) and I just tried a > 32bit build and it works fine after the fix from v6. Thanks Luca! Reviewed-by: Tiwei Bie > > -- > Kind regards, > Luca Boccassi