[dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Vipin Varghese]

With the latest release, support for vdev ethernet devices like pcap,
tun and tap are been added. Hence collecting statistics using proc-info
is possible now.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 doc/guides/tools/proc_info.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst
index d5b5ed6a6..f62177dba 100644
--- a/doc/guides/tools/proc_info.rst
+++ b/doc/guides/tools/proc_info.rst
@@ -51,7 +51,7 @@ Limitations
   mismatch in PMD library arguments can lead to undefined behaviour and results
   affecting primary application too.
 
-* Stats retrieval using ``dpdk-procinfo`` is not supported for virtual devices like PCAP and TAP.
+* Stats retrieval using ``dpdk-procinfo`` is supported for virtual devices like PCAP, TUN and TAP.
 
 * Since default DPDK EAL arguments for ``dpdk-procinfo`` are ``-c1, -n4 & --proc-type=secondary``,
   It is not expected that the user passes any EAL arguments.
-- 
2.17.1

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Ferruh Yigit]

On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> With the latest release, support for vdev ethernet devices like pcap,
> tun and tap are been added. Hence collecting statistics using proc-info
> is possible now.

This support is enabled when device shared between primary & secondary. The
capability to share virtual devices added that is correct, but still user may
prefer to use virtual device as process only.
Not sure if it worth mentioning stats retrieving supported when virtual device
is shared between processes, what do you think?

> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
>  doc/guides/tools/proc_info.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst
> index d5b5ed6a6..f62177dba 100644
> --- a/doc/guides/tools/proc_info.rst
> +++ b/doc/guides/tools/proc_info.rst
> @@ -51,7 +51,7 @@ Limitations
>    mismatch in PMD library arguments can lead to undefined behaviour and results
>    affecting primary application too.
>  
> -* Stats retrieval using ``dpdk-procinfo`` is not supported for virtual devices like PCAP and TAP.
> +* Stats retrieval using ``dpdk-procinfo`` is supported for virtual devices like PCAP, TUN and TAP.
>  
>  * Since default DPDK EAL arguments for ``dpdk-procinfo`` are ``-c1, -n4 & --proc-type=secondary``,
>    It is not expected that the user passes any EAL arguments.
> 

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Varghese, Vipin]

Hi Ferruh,

Please find the answers embedded to the email. 
 
<snipped>

> 
> On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> > With the latest release, support for vdev ethernet devices like pcap,
> > tun and tap are been added. Hence collecting statistics using
> > proc-info is possible now.
> 
> This support is enabled when device shared between primary & secondary. The
> capability to share virtual devices added that is correct, 

The document update is for procinfo tool, which is secondary process to collect stats for NIC interfaces under primary process.
Earlier documentation states since DPDK multi process has limitation in sharing virtual interface stats. The correction updates the same.

but still user may prefer
> to use virtual device as process only.

Proc info info tool purpose is collect stats from primary. Hence whether the primary process uses physical or virtual it is user discretion. But collecting stats is possible for any NIC device via proc info tool.

> Not sure if it worth mentioning stats retrieving supported when virtual device is
> shared between processes, what do you think?
> 

With the above reasoning, I believe proc info tool is state it can collect stats from both virtual and physical NIC is correct.

<snipped>

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Ferruh Yigit]

On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> With the latest release, support for vdev ethernet devices like pcap,
> tun and tap are been added. Hence collecting statistics using proc-info
> is possible now.
> 
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Thomas Monjalon]

09/11/2018 23:03, Ferruh Yigit:
> On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> > With the latest release, support for vdev ethernet devices like pcap,
> > tun and tap are been added. Hence collecting statistics using proc-info
> > is possible now.
> > 
> > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

Sorry, I removed it from the pull to mainline.
I think it is wrong listing vdevs as supported in "Limitations".
Please send a patch for simply removing the line.

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Thomas Monjalon]

14/11/2018 02:52, Thomas Monjalon:
> 09/11/2018 23:03, Ferruh Yigit:
> > On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> > > With the latest release, support for vdev ethernet devices like pcap,
> > > tun and tap are been added. Hence collecting statistics using proc-info
> > > is possible now.
> > > 
> > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > 
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > 
> > Applied to dpdk-next-net/master, thanks.
> 
> Sorry, I removed it from the pull to mainline.
> I think it is wrong listing vdevs as supported in "Limitations".
> Please send a patch for simply removing the line.

No update?

Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats

[Varghese, Vipin]

Hi Thomas,

With DPDK 18.11-rc4 I still see issues at times, Hence more test is required before I can send the change in request.

Thanks
Vipin Varghese

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, November 23, 2018 4:25 AM
> To: Varghese, Vipin <vipin.varghese@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Byrne, Stephen1 <stephen1.byrne@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc/proc_info: update support for vdev stats
> 
> 14/11/2018 02:52, Thomas Monjalon:
> > 09/11/2018 23:03, Ferruh Yigit:
> > > On 10/12/2018 12:35 PM, Vipin Varghese wrote:
> > > > With the latest release, support for vdev ethernet devices like
> > > > pcap, tun and tap are been added. Hence collecting statistics
> > > > using proc-info is possible now.
> > > >
> > > > Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> > >
> > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > >
> > > Applied to dpdk-next-net/master, thanks.
> >
> > Sorry, I removed it from the pull to mainline.
> > I think it is wrong listing vdevs as supported in "Limitations".
> > Please send a patch for simply removing the line.
> 
> No update?
> 
>