From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 22DE81B512 for ; Fri, 12 Oct 2018 14:44:16 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id a13-v6so13300286wrt.5 for ; Fri, 12 Oct 2018 05:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fMcQaFwr71XK4lGGehZNEQe2dsyO1HmC9w6x889EcBA=; b=mo64yxdtDe3Qb/L0d2A8odM0wu2/40GnHTiLe3dZXBCpyr4M3FQ67n8GKMjz4BUtkl 9luIBlm8WvJdeyFuC0iaw/JF46nH6rcRDTPqIKKH9JusXcb7R3lq1d1rbnvYiqiuL8Ew EeQKJpbEWzioE8WTZp1pEF4WATtF+PBFMSmOIYqV7pWnBuFjfMzqR5VxFZ6T1Zw9VAIK nlFGCSEfUtCBNp433cImCIOJck4ltSV5Qqi+QooBlcOyzUJv6mvo/d67/kQPJkZj42F8 fuTOpDwvyxGBmOuNJosNt0uHGIVMaUBvD89kFFlExwAEdgwj8EbOAoRPiUcEhktH6cGk GLmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fMcQaFwr71XK4lGGehZNEQe2dsyO1HmC9w6x889EcBA=; b=FlXTcjbRPnIsnWaUJGdTjhrCjCJAgZaxTl1fdoXwmQLohX37p9ehxU4Sf3QrPMIBl/ 2eZuEtnxeFpNcqBr2d7h2X7uWgAND4XHnZcf7P7+yzC7KXrKgFxvyMQNuthXjLGR752U wZmE/Pd2x4Z1fcm5pqusdTFVJ3rhuszJjCRijNknOU/fnBV6z8SLof0AzPm3f07VfYr9 O7e6uO6VWKyB7v6vtBksd3Lc1bdPvBcIHeGnStTRMWugrkOclKEXVrNbfk67g9UKH8OZ mdpRqzL6TUqr8JbANmRlebmIh42xbxZMaAb6qpCUEZ+7euc74IYwgM262UtBpdEHA00M G4Pw== X-Gm-Message-State: ABuFfoi1uSSV1sDdKKKPangpdEXVwisPOUvX4fm1wSnFiwxsIBxUMyRX 8llRhGZWD8L2i8mGkuFfOACmug== X-Google-Smtp-Source: ACcGV62y9faPn90+SlCzzDnPu9x+sVnQEBU3+8JvQAPsjpWflPMxLjcZZ/B3MhZ/E0MkQr5Vo+cnpw== X-Received: by 2002:a5d:5649:: with SMTP id j9-v6mr4866491wrw.41.1539348255787; Fri, 12 Oct 2018 05:44:15 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g8-v6sm1187662wmf.45.2018.10.12.05.44.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 05:44:14 -0700 (PDT) Date: Fri, 12 Oct 2018 14:43:57 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Stephen Hemminger , thomas@monjalon.net, dev@dpdk.org, Gaetan Rivet Message-ID: <20181012124357.GR18937@6wind.com> References: <20181011175940.6800-1-stephen@networkplumber.org> <98717fc3-c3dd-cc4f-e5ff-b5310e47d6ee@intel.com> <696e6f90-3d0c-acd4-d72d-bbebe1ff6f54@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <696e6f90-3d0c-acd4-d72d-bbebe1ff6f54@intel.com> Subject: Re: [dpdk-dev] [PATCH] ethdev: add function name to log message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 12:44:16 -0000 On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: > On 10/12/2018 11:42 AM, Ferruh Yigit wrote: > > On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > >> @@ -161,8 +161,9 @@ extern "C" { > >> > >> extern int rte_eth_dev_logtype; > >> > >> -#define RTE_ETHDEV_LOG(level, ...) \ > >> - rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, "" __VA_ARGS__) > >> +#define RTE_ETHDEV_LOG(level, fmt, ...) \ > >> + rte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \ > >> + "%s():" fmt, __func__, ## __VA_ARGS__) > > > > +1 to adding function name, but > > > > failsafe is giving build error [1] with clang because of ## usage [2], that is > > why I add this as ` "" __VA_ARGS__` at first place but you can't do this trick > > if __VA_ARGS__ used after fmt. > > > > I am not aware of a solution for this, __VA_OPT__(,) also didn't worked with clang. > > +cc Adrien & Gaetan, > > I saw Adrien put some "workaround" to this for mlx5 Yes, through RTE_FMT() (rte_common.h). Something like this: #define RTE_ETHDEV_LOG(level, fmt, ...) \ rte_log(RTE_LOG_ ## level, \ rte_eth_dev_logtype, \ "%s():" fmt, \ __func__, \ ## __VA_ARGS__) Can be rewritten like that: #define RTE_ETHDEV_LOG(level, ...) \ rte_log(RTE_LOG_ ## level, \ rte_eth_dev_logtype, \ RTE_FMT("%s():" RTE_FMT_HEAD(__VA_ARGS__,), \ __func__, \ RTE_FMT_TAIL(__VA_ARGS__,))) Although not too pretty and convenient, it does the job. In short: - Remove "fmt" argument from prototype. - Enclose format string and its arguments in RTE_FMT(). - Replace "fmt" with RTE_FMT_HEAD(__VA_ARGS__,). - Replace "## __VA_ARGS__" with RTE_FMT_TAIL(__VA_ARGS__,). - Yes, trailing commas are mandatory in RTE_FMT_(HEAD|TAIL)(). - Note it quietly appends a dummy "%.0s" argument to the format string. > > [1] > > .../build/include/rte_ethdev.h:166:26: error: token pasting of ',' and > > __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments] > > "%s():" fmt, __func__, ## __VA_ARGS__) > > ^ > > > > [2] > > This seems because of "-pedantic" argument driver uses, and other PMDs using > > "-pedantic", like mlx, will have same error although they are disable by > > default and error not observed in default build. > > > -- Adrien Mazarguil 6WIND