From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D3E481B3AF for ; Fri, 12 Oct 2018 16:09:34 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2018 07:09:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,372,1534834800"; d="scan'208";a="82094267" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by orsmga006.jf.intel.com with SMTP; 12 Oct 2018 07:09:31 -0700 Received: by (sSMTP sendmail emulation); Fri, 12 Oct 2018 15:09:30 +0100 Date: Fri, 12 Oct 2018 15:09:30 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20181012140930.GA21308@bricha3-MOBL.ger.corp.intel.com> References: <20181011194629.4699-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181011194629.4699-1-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 14:09:35 -0000 On Thu, Oct 11, 2018 at 08:46:29PM +0100, Luca Boccassi wrote: > A Kbuild is also included to allow users to use DKMS natively without > additional code. > > Signed-off-by: Luca Boccassi > --- > build-tested on debian sid am64 > > kernel/linux/kni/Kbuild | 8 ++++++ > kernel/linux/kni/meson.build | 51 ++++++++++++++++++++++++++++++++++++ > kernel/linux/meson.build | 2 +- > 3 files changed, 60 insertions(+), 1 deletion(-) > create mode 100644 kernel/linux/kni/Kbuild > create mode 100644 kernel/linux/kni/meson.build > I get a couple of errors building this on Fedora 28. First problem is that I get a compilation error for a missing rte_fifo.h. The fix for that error is to ensure the current dir is on the include list: ' -I' + meson.build_root() + + ' -I' + meson.current_source_dir() + ' -I' + meson.current_source_dir() + '/ethtool/ixgbe' + Then I hit a second error, where the compile fails because the output directory for the ethdev files does not exist. Fatal error: can't create /home/bruce/dpdk-clean/build-gcc-static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o: No such file or directory make[1]: *** [scripts/Makefile.build:318: /home/bruce/dpdk-clean/build-gcc-static/kernel/linux/kni/ethtool/ixgbe/ixgbe_ethtool.o] Error 2 I haven't fixed this, but I think the easiest fix is probably to split the file lists so that each file is listed in a meson.build in its own subdirectory. Then using subdir to build up the file list rather than having it all at one gom should cause meson to create the subdirectory structure in the build directory. There may be other, better solutions, though. /Bruce