From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C16361BACD for ; Fri, 12 Oct 2018 18:29:44 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Oct 2018 09:29:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,373,1534834800"; d="scan'208";a="94701278" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.107]) by fmsmga002.fm.intel.com with SMTP; 12 Oct 2018 09:29:41 -0700 Received: by (sSMTP sendmail emulation); Fri, 12 Oct 2018 17:29:38 +0100 Date: Fri, 12 Oct 2018 17:29:38 +0100 From: Bruce Richardson To: Luca Boccassi Cc: dev@dpdk.org, ferruh.yigit@intel.com Message-ID: <20181012162938.GA11676@bricha3-MOBL.ger.corp.intel.com> References: <20181011194629.4699-1-bluca@debian.org> <20181012151221.11295-1-bluca@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181012151221.11295-1-bluca@debian.org> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 16:29:45 -0000 On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > A Kbuild is also included to allow users to use DKMS natively without > additional code. > > Signed-off-by: Luca Boccassi > --- > v2: add local directory to -I and build sources list recursively to > fix build on Fedora > Yep, now seems to build for me on Fedora. One minor suggestion is to look to use the "console" keyword on the custom_target if possible. It should help prevent noticable stalls as make runs in the background. [Unfortunately, it's meson 0.48 onward only, so if conditionals are needed, just ignore this suggestion] Also, do we want to use "make -j" for this, given the number of files? [Maybe -j4 just?] Tested-by: Bruce Richardson Acked-by: Bruce Richardson